Skip to content

Commit d457d8e

Browse files
authored
fix(express): Ensure we document error handler positioning (#10092)
1 parent 099b96e commit d457d8e

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

platform-includes/getting-started-add-top-level-import/javascript.express.mdx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ const app = express();
88

99
// Add your routes, etc.
1010

11-
// Add this after all routes and other middlewares are defined
11+
// Add this after all routes,
12+
// but before any and other error-handling middlewares are defined
1213
Sentry.setupExpressErrorHandler(app);
1314

1415
app.listen(3000);
@@ -24,7 +25,8 @@ const app = express();
2425

2526
// Add your routes, etc.
2627

27-
// Add this after all routes and other middlewares are defined
28+
// Add this after all routes,
29+
// but before any and other error-handling middlewares are defined
2830
Sentry.setupExpressErrorHandler(app);
2931

3032
app.listen(3000);

platform-includes/getting-started-use/javascript.express.mdx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ const app = express();
1010

1111
// Add your routes, etc.
1212

13-
// Add this after all routes and other middlewares are defined
13+
// Add this after all routes,
14+
// but before any and other error-handling middlewares are defined
1415
Sentry.setupExpressErrorHandler(app);
1516

1617
app.listen(3000);
@@ -28,7 +29,8 @@ const app = express();
2829

2930
// Add your routes, etc.
3031

31-
// Add this after all routes and other middlewares are defined
32+
// Add this after all routes,
33+
// but before any and other error-handling middlewares are defined
3234
Sentry.setupExpressErrorHandler(app);
3335

3436
app.listen(3000);

platform-includes/migration/javascript-v8/important-changes/javascript.express.mdx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ const app = express();
1818

1919
// Add routes etc. here
2020

21-
// Add this after all routes and other middlewares are defined
21+
// Add this after all routes,
22+
// but before any and other error-handling middlewares are defined
2223
Sentry.setupExpressErrorHandler(app);
2324

2425
app.listen(3000);
@@ -32,7 +33,8 @@ const app = express();
3233

3334
// Add your routes, etc.
3435

35-
// Add this after all routes and other middlewares are defined
36+
// Add this after all routes,
37+
// but before any and other error-handling middlewares are defined
3638
Sentry.setupExpressErrorHandler(app);
3739

3840
app.listen(3000)

0 commit comments

Comments
 (0)