Skip to content

Sign In takes me to Sentry instead of signing me into the docs #11557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bruno-garcia opened this issue Oct 13, 2024 · 7 comments
Closed

Sign In takes me to Sentry instead of signing me into the docs #11557

bruno-garcia opened this issue Oct 13, 2024 · 7 comments
Labels

Comments

@bruno-garcia
Copy link
Member

Steps to Reproduce

Image

When I hit Sign In, I end up in Sentry looking at my event stream

Expected Result

My Name would show at the top right, and I'd see proper DSN's on the docs instead of templates

Actual Result

Navigated away from the docs, into Sentry

Additional Info

No response

@stephanie-anderson
Copy link
Contributor

This is the desired behaviour (being redirected to the product, and not being redirected back to the platform on which you clicked Sign In). See changelog etc

@github-project-automation github-project-automation bot moved this from Backlog to Done in Docs Platform Oct 14, 2024
@whitep4nth3r
Copy link
Contributor

whitep4nth3r commented Oct 23, 2024

The DSN population is super useful and would be move obvious if there was an obvious "signed in" state in the nav or sidebar.

On a number of occasions, I have clicked "Sign in" and have been surprised each time it took me to Sentry.

As @bruno-garcia suggests (in Slack), perhaps the "Sign in" text should be changed to "Go to Sentry" or similar.

@rahulchhabria
Copy link
Contributor

i'm good with "go to sentry" but i find it super interesting that you both want to sign into docs. do other docs sites work that way?

@whitep4nth3r
Copy link
Contributor

do other docs sites work that way?

Yes, indeed!

Airtable is a great example — if you're signed in, the code samples come pre-populated with your own data — which is what we do on the Sentry docs. Stripe do this, too. And I'm sure many others.

@stephanie-anderson
Copy link
Contributor

Then let's find some other wording for Sign In as long as we want users to be redirected to the product afterwards.

Having a logged in state in docs is another issue though, and something that we have experimented with in the past (see #11124). The UX was really bad though, so we reverted the change (it wasn't easily possible to test this locally or on Vercel's preview environment).

For it to be a really great experience, we would need to

  • be able to test this properly
  • make the page dynamic (instead of statically generated files). Otherwise the right top section would always flicker with each new page request, which was not a solution we could live with

Having said that - having a logged in state was something that we came up with ourselves (docs team + docs platform engineers), but haven't heard much feedback from others. So we didn't see justification for spending the engineering effort into making it possible after this initial setback.

Will discuss this issue in our upcoming sync on Monday and revive the discussion. But for this particular Sign In button, which should lead to Sentry (as it does on all the pages), we should simply change the wording imo. And change it on all the pages, not only docs

@github-project-automation github-project-automation bot moved this from Done to In Progress in Docs Platform Oct 23, 2024
@rahulchhabria
Copy link
Contributor

@stephanie-anderson i'm good with "go to sentry"

@bruno-garcia
Copy link
Member Author

It's been done! thanks Salma

@github-project-automation github-project-automation bot moved this from Todo to Done in Docs Platform Nov 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants