Skip to content

Move the onFinishCallback before the span is finished #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stefanosiano opened this issue Feb 26, 2024 · 2 comments · Fixed by #3459
Closed

Move the onFinishCallback before the span is finished #3228

stefanosiano opened this issue Feb 26, 2024 · 2 comments · Fixed by #3459
Assignees
@stefanosiano
Labels
Platform: Android Platform: Java

Comments

@stefanosiano
Copy link
Member

Description

#3219 (comment)
@github-project-automation github-project-automation bot moved this to Needs Discussion in [DEPRECATED] Mobile SDKs Feb 26, 2024
@markushi
Copy link
Member

markushi commented Feb 27, 2024 •
edited
Loading

Let's also keep our SpanFrameMetricsCollector in mind, as it's onSpanFinished callback requires the finish date to be already set.

@markushi
Copy link
Member

markushi commented Feb 28, 2024 •
edited
Loading

Given that we have a mixed behavior for txn/spans, let's consider this broken and fix it.
Let's apply this to both Spans and Transactions.

@markushi markushi moved this from Needs Discussion to Todo in [DEPRECATED] Mobile SDKs Feb 28, 2024
@stefanosiano stefanosiano mentioned this issue Jun 5, 2024
Merged
7 tasks
@stefanosiano stefanosiano moved this from Todo to Needs Review in [DEPRECATED] Mobile SDKs Jun 5, 2024
@stefanosiano stefanosiano self-assigned this Jun 5, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in [DEPRECATED] Mobile SDKs Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanosiano stefanosiano

Labels
Platform: Android Platform: Java
Projects
[DEPRECATED] Mobile SDKs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move onFinishCallback before span or transaction is finished getsentry/sentry-java
2 participants
@markushi @stefanosiano