-
-
Notifications
You must be signed in to change notification settings - Fork 451
Improve log output during SDK init #4307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There are so many logs, including some about serialisation and installed modules. Honestly this all seems like debug info that's helpful to you, but should be silent for the end user. I would recommend that you put all those logs behind a flag, so they can enabled when you are developing the sdks. |
@feinstein just to clarify: You seem to have SDK logging enabled at the |
Ok, but I think there's a difference between the debugs logs that are useful for devs and the logs that are useful to the SDK development. I feel that the logs are just too verbose to the point where they are useful for SDK development, not the users. And this being |
@feinstein the |
I will try, but that's not my point, I mean that these shouldn't be the default levels as I believe it's too noisy for everyone that's not working in the SDK development, or correct me if I am wrong please. |
We use the |
hi @feinstein |
Thanks @stefanosiano. I did a test here and setup my level to D/Sentry ( 5032): Failed to delete: /data/user/0/uk.co.goshorty.goshorty.stg/cache/sentry/5b38cfeb18a05f1ef09960dd9b32f3dac5c1d97b/.options-cache/proguard-uuid.json It's way better than what I was getting before, but still, is this expected to happen at each hot restart? |
@feinstein Yes this is expected (those files probably don't exist, or not modifable during a hot-reload phase). |
Then why are they being logged as warning, if they are expected to happen? |
Good point, we'll get this checked and change the level. Thanks! |
I assume this also fixes this right? getsentry/sentry-dart#2673 cc @markushi |
Description
io.sentry.android.core.LoadClass.loadClass
spits out an exception to the log output if a certain class is not available (androidx libs, Jetpack Compose) - this can be quite confusing for anyone using our SDK.Fixes getsentry/sentry-dart#2824 (comment)
The text was updated successfully, but these errors were encountered: