-
Notifications
You must be signed in to change notification settings - Fork 41
Since 3.0.0, Sentry webpack plugin aborts build processes prematurely, breaking builds #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @controversial thanks for writing in! Seems like I was right to worry about #653. We'll find a fix ASAP.
I think the PR description of #653 describes this fairly well. Again, we'll fix this. Thanks for raising. |
The fix was released with |
Thanks for getting on the fix so quickly! I’m sorry for my tone in the original issue; I was writing it in a rush and didn’t mean to come across as rude. |
Confirming 3.1.0 fixes the issue for me. I appreciate your help! |
Environment
sentry/[email protected]
Steps to Reproduce
I use
@sentry/webpack-plugin
directly in my Next.js config, rather than using the parent function from@sentry/nextjs
:next.config.ts looks like:
Add a build script:
Expected Result
The project builds and uploads source maps to Sentry. The output should look something like:
Actual Result
The project does not build; the
build-1
process exits with a success error code before the project has actually been builtNote:
ls
output shows that most of the build outputs that should be present from the build are missingbuild-2
script fails because it’s missing required outputs frombuild-1
The sentry plugin exits the build-1 process, which causes the subsequent steps of the build to fail completely as they are missing the files that were to be generated after the process was exited by Sentry
Cause
Presumably this is caused by #653
@sentry/webpack-plugin
to comment out theprocess.exit(0)
lines added in fix(webpack): Ensure process exits when done #653 resolves this issue for me and allows the build to proceed normally.process.exit()
to terminate the build process was considered reasonable/safe; afaik this is not normal behavior for a webpack plugin.The text was updated successfully, but these errors were encountered: