Skip to content

Commit 32a171a

Browse files
committed
make options optional
1 parent a330df4 commit 32a171a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Diff for: packages/node/src/integrations/requestdata.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ type RequestDataIntegrationOptions = {
1010
/**
1111
* Controls what data is pulled from the request and added to the event
1212
*/
13-
include: {
13+
include?: {
1414
cookies?: boolean;
1515
data?: boolean;
1616
headers?: boolean;
@@ -27,15 +27,15 @@ type RequestDataIntegrationOptions = {
2727
};
2828

2929
/** Whether to identify transactions by parameterized path, parameterized path with method, or handler name */
30-
transactionNamingScheme: TransactionNamingScheme;
30+
transactionNamingScheme?: TransactionNamingScheme;
3131

3232
/**
3333
* Function for adding request data to event. Defaults to `addRequestDataToEvent` from `@sentry/node` for now, but
3434
* left injectable so this integration can be moved to `@sentry/core` and used in browser-based SDKs in the future.
3535
*
3636
* @hidden
3737
*/
38-
addRequestData: typeof addRequestDataToEvent;
38+
addRequestData?: typeof addRequestDataToEvent;
3939
};
4040

4141
const DEFAULT_OPTIONS = {
@@ -69,12 +69,12 @@ export class RequestData implements Integration {
6969
*/
7070
public name: string = RequestData.id;
7171

72-
private _options: RequestDataIntegrationOptions;
72+
private _options: Required<RequestDataIntegrationOptions>;
7373

7474
/**
7575
* @inheritDoc
7676
*/
77-
public constructor(options: Partial<RequestDataIntegrationOptions> = {}) {
77+
public constructor(options: RequestDataIntegrationOptions = {}) {
7878
this._options = {
7979
...DEFAULT_OPTIONS,
8080
...options,
@@ -154,7 +154,7 @@ export class RequestData implements Integration {
154154
/** Convert this integration's options to match what `addRequestDataToEvent` expects */
155155
/** TODO: Can possibly be deleted once https://github.com/getsentry/sentry-javascript/issues/5718 is fixed */
156156
function convertReqDataIntegrationOptsToAddReqDataOpts(
157-
integrationOptions: RequestDataIntegrationOptions,
157+
integrationOptions: Required<RequestDataIntegrationOptions>,
158158
): AddRequestDataToEventOptions {
159159
const { transactionNamingScheme } = integrationOptions;
160160
const { ip, user, ...requestOptions } = integrationOptions.include;

0 commit comments

Comments
 (0)