Skip to content

Commit 50589cd

Browse files
authored
fix(node): Replace dashes in generic-pool span origins with underscores (#13579)
Ref #13465 (comment)
1 parent 6dc8aab commit 50589cd

File tree

2 files changed

+5
-5
lines changed
  • dev-packages/node-integration-tests/suites/tracing/genericPool
  • packages/node/src/integrations/tracing

2 files changed

+5
-5
lines changed

dev-packages/node-integration-tests/suites/tracing/genericPool/test.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,18 @@ describe('genericPool auto instrumentation', () => {
1111
spans: expect.arrayContaining([
1212
expect.objectContaining({
1313
description: expect.stringMatching(/^generic-pool\.ac?quire/),
14-
origin: 'auto.db.otel.generic-pool',
14+
origin: 'auto.db.otel.generic_pool',
1515
data: {
16-
'sentry.origin': 'auto.db.otel.generic-pool',
16+
'sentry.origin': 'auto.db.otel.generic_pool',
1717
},
1818
status: 'ok',
1919
}),
2020

2121
expect.objectContaining({
2222
description: expect.stringMatching(/^generic-pool\.ac?quire/),
23-
origin: 'auto.db.otel.generic-pool',
23+
origin: 'auto.db.otel.generic_pool',
2424
data: {
25-
'sentry.origin': 'auto.db.otel.generic-pool',
25+
'sentry.origin': 'auto.db.otel.generic_pool',
2626
},
2727
status: 'ok',
2828
}),

packages/node/src/integrations/tracing/genericPool.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const _genericPoolIntegration = (() => {
2525
spanDescription === 'generic-pool.aquire' || spanDescription === 'generic-pool.acquire';
2626

2727
if (isGenericPoolSpan) {
28-
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.db.otel.generic-pool');
28+
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.db.otel.generic_pool');
2929
}
3030
});
3131
},

0 commit comments

Comments
 (0)