Skip to content

Commit f52fd16

Browse files
committed
add e2e tests to check for fetch proxy on versions 2.5.0 and ^2.16.0
1 parent 1d797ea commit f52fd16

File tree

3 files changed

+26
-5
lines changed

3 files changed

+26
-5
lines changed

dev-packages/e2e-tests/test-applications/sveltekit-2-twp/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"@sentry-internal/test-utils": "link:../../../test-utils",
2323
"@sentry/core": "latest || *",
2424
"@sveltejs/adapter-auto": "^3.0.0",
25-
"@sveltejs/kit": "^2.0.0",
25+
"@sveltejs/kit": "2.5.0",
2626
"@sveltejs/vite-plugin-svelte": "^3.0.0",
2727
"svelte": "^5.0.0-next.115",
2828
"svelte-check": "^3.6.0",
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
import { expect, test } from '@playwright/test';
2+
3+
test.describe('SDK-internal behavior', () => {
4+
test('Injects fetch proxy script for SvelteKit<2.16.0', async ({ page }) => {
5+
await page.goto('/');
6+
7+
const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
8+
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');
9+
10+
// sanity check
11+
expect(sentryCarrier).toBe('object');
12+
13+
// fetch proxy script ran
14+
expect(proxyHandle).toBe('function');
15+
});
16+
});

dev-packages/e2e-tests/test-applications/sveltekit-2/tests/sdk.test.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,14 @@ import { waitForInitialPageload } from './utils';
33

44
test.describe('SDK-internal behavior', () => {
55
test("Doesn't inject fetch proxy script for SvelteKit>=2.16.0", async ({ page }) => {
6-
await waitForInitialPageload(page, { route: '/client-error' });
7-
// @ts-expect-error - this is the variable the fetch proxy script sets if it would be injected
8-
const proxyHandle = await page.waitForFunction(() => globalThis._sentryFetchProxy);
9-
expect(proxyHandle).toBeUndefined();
6+
await waitForInitialPageload(page, { route: '/' });
7+
const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
8+
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');
9+
10+
// sanity check
11+
expect(sentryCarrier).toBe('object');
12+
13+
// fetch proxy script didn't run
14+
expect(proxyHandle).toBe('undefined');
1015
});
1116
});

0 commit comments

Comments
 (0)