Skip to content

Add Sentry integration for Hono #12424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FaureAlexis opened this issue Jun 10, 2024 · 8 comments · Fixed by getsentry/sentry-docs#10335
Closed

Add Sentry integration for Hono #12424

FaureAlexis opened this issue Jun 10, 2024 · 8 comments · Fixed by getsentry/sentry-docs#10335
Assignees

Comments

@FaureAlexis
Copy link

Problem Statement

Add tracing integration for Hono (https://hono.dev/) to @sentry/node like other frameworks like Express, fastify, nest etc.

Solution Brainstorm

If it's okay for you, I can create a PR with the integration within a week

@s1gr1d
Copy link
Member

s1gr1d commented Jun 10, 2024

Thanks for suggesting this! We were already talking about a hono integration. Hono already provides their own Sentry middleware. @yusukebe, you are the core maintainer of the middleware. What do you think of adding a hono integration to our Sentry repository? We could also mention the hono middleware in our docs.

@yusukebe
Copy link

Hi.

@s1gr1d

What do you think of adding a hono integration to our Sentry repository? We could also mention the hono middleware in our docs.

As you said, we have the middleware @hono/sentry, so creating a new one is unnecessary. I think the best approach is adding a description for the middleware in the sentry docs. Thanks!

@timfish
Copy link
Collaborator

timfish commented Jun 10, 2024

@hono/sentry currently uses toucan-js so that it can fully support all platforms including Cloudflare Workers.

toucan-js is awaiting an update to the v8 SDK robertcepa/toucan-js#234

@s1gr1d
Copy link
Member

s1gr1d commented Jun 13, 2024

cc @MathurAditya724

@vKongv
Copy link

vKongv commented Jun 13, 2024

does @hono/sentry support performance monitoring?

@wesleyakio
Copy link

@s1gr1d @yusukebe I believe the initial ticket was about supporting tracing, but as far as I could understand @hono/sentry only works for exceptions.

Are there plans to support tracing on @hono/sentry, adding hono to @sentry/node or neither?

@yusukebe
Copy link

Hi, @sam-lippert. What do you think of the above things?

@sam-lippert
Copy link

@wesleyakio @yusukebe The Sentry middleware for Hono is designed to be as lightweight as possible of a wrapper for toucan-js, so if a feature is supported by Toucan, it should be supported by @hono/sentry. Regarding performance monitoring specifically, I am unsure if Toucan supports it, as there has been an open issue on it since 2021. It is a feature that people have been asking about, and so I've been periodically trying to figure that out through the documentation over the past few months, and if it is supported by Toucan, I suspect that monitoring by default could be supported by adding performance spans to the middleware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants