Skip to content

Add dataloaderIntegration to Node #13313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mydea opened this issue Aug 12, 2024 · 2 comments · Fixed by #13664
Closed

Add dataloaderIntegration to Node #13313

mydea opened this issue Aug 12, 2024 · 2 comments · Fixed by #13664
Assignees
@onurtemizkan
Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry

Comments

@mydea
Copy link
Member

mydea commented Aug 12, 2024

Description

We want to instrument dataloader. There is an existing OTEL instrumentation for this:

https://www.npmjs.com/package/@opentelemetry/instrumentation-dataloader

### Tasks
- [ ] Add new `dataloaderIntegration` in `@sentry/node`
- [ ] This should set up the OTEL instrumentation
- [ ] Make sure to add an `origin` to all spans the integration emits
- [ ] Add node-integration-tests for the package
- [ ] The integration should be added by default

This is a cache integration, and thus must follow https://develop.sentry.dev/sdk/telemetry/traces/modules/caches/. You can see https://docs.sentry.io/platforms/javascript/guides/node/tracing/instrumentation/custom-instrumentation/caches-module/ for a reference, or look at the redis integration.
@mydea mydea changed the title Add dataloaderIntegration to node Add dataloaderIntegration to Node Aug 12, 2024
@mydea mydea mentioned this issue Aug 12, 2024
Closed
@onurtemizkan onurtemizkan self-assigned this Aug 29, 2024
@onurtemizkan onurtemizkan mentioned this issue Sep 11, 2024
Merged
@AbhiPrasad
Copy link
Member

Follow up tasks documented in #13724

@AbhiPrasad
Copy link
Member

Docs PR: getsentry/sentry-docs#11416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onurtemizkan onurtemizkan

Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(node): Add dataloader integration getsentry/sentry-javascript
3 participants
@mydea @onurtemizkan @AbhiPrasad