-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Remove use of whitelist/blacklist in sdk api #2640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Moving this to sentry-javascript as those parameters exist purely in JS. |
This opens up the opportunity to fix the behavior of this parameter as well. It currently supports a substring match which we discussed before we might want to remove for an host portion only check. |
I really appreciate your response on this. Thank you. |
Summary
Could you update your API terminology for
whitelistUrls
andblacklistUrls
to be more inclusive? This could be a breaking change or you could immediately accept additional properties alongside the existing ones and phase them out at the next scheduled release.Motivation
The Code of Conduct says to use welcome and inclusive language and there's certainly more inclusive language that could be used for this part of the api. In addition, you're in the position of setting an example with the terminology that you choose to use. This post does a good job of detailing why the terms derive from prejudice: https://www.ncsc.gov.uk/blog-post/terminology-its-not-black-and-white
Additional Context
If
allowList
anddenyList
don't fit exactly, alternative API properties could beexcludeUrls
,includeUrls
.Thank you.
Prior conversation on other repositories:
The text was updated successfully, but these errors were encountered: