Skip to content

Commit 54b32f2

Browse files
test(transport): Non-order-dependent discarded events assertion
Make the `report["discarded_events"]` assertion logic (in `test_data_category_limits_reporting`) not rely on the ordering of events or any sorting logic. Done in preparation of #3244, where the sorting logic cannot be relied on anymore, since the same number of spans will be discarded as transactions.
1 parent 69ecd87 commit 54b32f2

File tree

1 file changed

+15
-4
lines changed

1 file changed

+15
-4
lines changed

tests/test_transport.py

+15-4
Original file line numberDiff line numberDiff line change
@@ -422,10 +422,21 @@ def intercepting_fetch(*args, **kwargs):
422422
assert envelope.items[0].type == "event"
423423
assert envelope.items[1].type == "client_report"
424424
report = parse_json(envelope.items[1].get_bytes())
425-
assert sorted(report["discarded_events"], key=lambda x: x["quantity"]) == [
426-
{"category": "transaction", "reason": "ratelimit_backoff", "quantity": 2},
427-
{"category": "attachment", "reason": "ratelimit_backoff", "quantity": 11},
428-
]
425+
426+
discarded_events = report["discarded_events"]
427+
428+
assert len(discarded_events) == 2
429+
assert {
430+
"category": "transaction",
431+
"reason": "ratelimit_backoff",
432+
"quantity": 2,
433+
} in discarded_events
434+
assert {
435+
"category": "attachment",
436+
"reason": "ratelimit_backoff",
437+
"quantity": 11,
438+
} in discarded_events
439+
429440
capturing_server.clear_captured()
430441

431442
# here we sent a normal event

0 commit comments

Comments
 (0)