Skip to content

Commit b9e2c16

Browse files
committed
tests: Fix breadcrumb ordering tests
These tests were failing for me locally as the timestamps were without `tzinfo` and all were assumed UTC whereas my local timezone is BST at the moment. This patch fixes them by forcing things to have the UTC timezone.
1 parent 4f6ccc4 commit b9e2c16

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

tests/test_basics.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -397,11 +397,12 @@ def test_breadcrumbs(sentry_init, capture_events):
397397
def test_breadcrumb_ordering(sentry_init, capture_events):
398398
sentry_init()
399399
events = capture_events()
400+
now = datetime.datetime.now(datetime.timezone.utc)
400401

401402
timestamps = [
402-
datetime.datetime.now() - datetime.timedelta(days=10),
403-
datetime.datetime.now() - datetime.timedelta(days=8),
404-
datetime.datetime.now() - datetime.timedelta(days=12),
403+
now - datetime.timedelta(days=10),
404+
now - datetime.timedelta(days=8),
405+
now - datetime.timedelta(days=12),
405406
]
406407

407408
for timestamp in timestamps:
@@ -419,7 +420,7 @@ def test_breadcrumb_ordering(sentry_init, capture_events):
419420
timestamps_from_event = [
420421
datetime.datetime.strptime(
421422
x["timestamp"].replace("Z", ""), "%Y-%m-%dT%H:%M:%S.%f"
422-
)
423+
).replace(tzinfo=datetime.timezone.utc)
423424
for x in event["breadcrumbs"]["values"]
424425
]
425426
assert timestamps_from_event == sorted(timestamps)
@@ -428,11 +429,12 @@ def test_breadcrumb_ordering(sentry_init, capture_events):
428429
def test_breadcrumb_ordering_different_types(sentry_init, capture_events):
429430
sentry_init()
430431
events = capture_events()
432+
now = datetime.datetime.now(datetime.timezone.utc)
431433

432434
timestamps = [
433-
datetime.datetime.now() - datetime.timedelta(days=10),
434-
datetime.datetime.now() - datetime.timedelta(days=8),
435-
datetime.datetime.now() - datetime.timedelta(days=12),
435+
now - datetime.timedelta(days=10),
436+
now - datetime.timedelta(days=8),
437+
now - datetime.timedelta(days=12),
436438
]
437439

438440
for i, timestamp in enumerate(timestamps):
@@ -450,7 +452,7 @@ def test_breadcrumb_ordering_different_types(sentry_init, capture_events):
450452
timestamps_from_event = [
451453
datetime.datetime.strptime(
452454
x["timestamp"].replace("Z", ""), "%Y-%m-%dT%H:%M:%S.%f"
453-
)
455+
).replace(tzinfo=datetime.timezone.utc)
454456
for x in event["breadcrumbs"]["values"]
455457
]
456458
assert timestamps_from_event == sorted(timestamps)

0 commit comments

Comments
 (0)