Skip to content

Commit f5dd9ce

Browse files
sentrivanaantonpirker
authored andcommitted
fix(tests): Add Spark testsuite to tox.ini and to CI (#3199)
1 parent 71c5f40 commit f5dd9ce

File tree

3 files changed

+23
-3
lines changed

3 files changed

+23
-3
lines changed

Diff for: .github/workflows/test-integrations-data-processing.yml

+9-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
strategy:
2626
fail-fast: false
2727
matrix:
28-
python-version: ["3.6","3.7","3.8","3.11","3.12"]
28+
python-version: ["3.6","3.7","3.8","3.10","3.11","3.12"]
2929
# python3.6 reached EOL and is no longer being supported on
3030
# new versions of hosted runners on Github Actions
3131
# ubuntu-20.04 is the last version that supported python3.6
@@ -64,6 +64,10 @@ jobs:
6464
run: |
6565
set -x # print commands that are executed
6666
./scripts/runtox.sh "py${{ matrix.python-version }}-rq-latest" --cov=tests --cov=sentry_sdk --cov-report= --cov-branch
67+
- name: Test spark latest
68+
run: |
69+
set -x # print commands that are executed
70+
./scripts/runtox.sh "py${{ matrix.python-version }}-spark-latest" --cov=tests --cov=sentry_sdk --cov-report= --cov-branch
6771
- name: Generate coverage XML
6872
run: |
6973
coverage combine .coverage*
@@ -118,6 +122,10 @@ jobs:
118122
run: |
119123
set -x # print commands that are executed
120124
./scripts/runtox.sh --exclude-latest "py${{ matrix.python-version }}-rq" --cov=tests --cov=sentry_sdk --cov-report= --cov-branch
125+
- name: Test spark pinned
126+
run: |
127+
set -x # print commands that are executed
128+
./scripts/runtox.sh --exclude-latest "py${{ matrix.python-version }}-spark" --cov=tests --cov=sentry_sdk --cov-report= --cov-branch
121129
- name: Generate coverage XML
122130
run: |
123131
coverage combine .coverage*

Diff for: scripts/split-tox-gh-actions/split-tox-gh-actions.py

+1
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@
8282
"celery",
8383
"huey",
8484
"rq",
85+
"spark",
8586
],
8687
"Databases": [
8788
"asyncpg",

Diff for: tox.ini

+13-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
[tox]
77
requires =
88
# This version introduced using pip 24.1 which does not work with older Celery and HTTPX versions.
9-
virtualenv<20.26.3
9+
virtualenv<20.26.3
1010
envlist =
1111
# === Common ===
1212
{py3.6,py3.7,py3.8,py3.9,py3.10,py3.11,py3.12}-common
@@ -219,6 +219,10 @@ envlist =
219219
{py3.7,py3.11}-sanic-v{23}
220220
{py3.8,py3.11}-sanic-latest
221221

222+
# Spark
223+
{py3.8,py3.10,py3.11}-spark-v{3.1,3.3,3.5}
224+
{py3.8,py3.10,py3.11}-spark-latest
225+
222226
# Starlette
223227
{py3.7,py3.10}-starlette-v{0.19}
224228
{py3.7,py3.11}-starlette-v{0.20,0.24,0.28}
@@ -564,6 +568,12 @@ deps =
564568
sanic-v23: sanic~=23.0
565569
sanic-latest: sanic
566570

571+
# Spark
572+
spark-v3.1: pyspark~=3.1.0
573+
spark-v3.3: pyspark~=3.3.0
574+
spark-v3.5: pyspark~=3.5.0
575+
spark-latest: pyspark
576+
567577
# Starlette
568578
starlette: pytest-asyncio
569579
starlette: python-multipart
@@ -643,6 +653,7 @@ setenv =
643653
gcp: TESTPATH=tests/integrations/gcp
644654
gql: TESTPATH=tests/integrations/gql
645655
graphene: TESTPATH=tests/integrations/graphene
656+
grpc: TESTPATH=tests/integrations/grpc
646657
httpx: TESTPATH=tests/integrations/httpx
647658
huey: TESTPATH=tests/integrations/huey
648659
huggingface_hub: TESTPATH=tests/integrations/huggingface_hub
@@ -659,14 +670,14 @@ setenv =
659670
requests: TESTPATH=tests/integrations/requests
660671
rq: TESTPATH=tests/integrations/rq
661672
sanic: TESTPATH=tests/integrations/sanic
673+
spark: TESTPATH=tests/integrations/spark
662674
starlette: TESTPATH=tests/integrations/starlette
663675
starlite: TESTPATH=tests/integrations/starlite
664676
sqlalchemy: TESTPATH=tests/integrations/sqlalchemy
665677
strawberry: TESTPATH=tests/integrations/strawberry
666678
tornado: TESTPATH=tests/integrations/tornado
667679
trytond: TESTPATH=tests/integrations/trytond
668680
socket: TESTPATH=tests/integrations/socket
669-
grpc: TESTPATH=tests/integrations/grpc
670681

671682
COVERAGE_FILE=.coverage-{envname}
672683
passenv =

0 commit comments

Comments
 (0)