Skip to content

Support Python 3.13 (coming Oct 2024) #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sentrivana opened this issue Jan 22, 2024 · 4 comments · Fixed by #3200
Closed

Support Python 3.13 (coming Oct 2024) #2664

sentrivana opened this issue Jan 22, 2024 · 4 comments · Fixed by #3200

Comments

@sentrivana
Copy link
Contributor

Problem Statement

Python 3.13 is scheduled for release in October 2024.

The first RC will be out in July, the second one in September.

Solution Brainstorm

Prepare for 3.13 so that the SDK is compatible by release time.

@rominf
Copy link
Contributor

rominf commented Jul 5, 2024

I started building python3-sentry-sdk on Fedora 41, which will come with Python 3.13, and encountered some issues. Some Sentry SDK dependencies do not support Python 3.13 yet:
celery/kombu#2051
gevent/gevent#2037
python-jsonschema/jsonschema#1264

I also created patches for the Sentry SDK itself; look for "Python 3.13" in https://src.fedoraproject.org/rpms/python-sentry-sdk/pull-request/10#request_diff. I want them to be included in the Sentry SDK. I saw you have #3200 already. What is the most convenient way to submit PR(s)? Should I open PR(s) into master without testing them on Python 3.13, should I open PR(s) into your branch ivana/python-3.13, or should I base my PR(s) on top of yours in master?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jul 5, 2024
@sentrivana
Copy link
Contributor Author

Hey @rominf, first of all thank you for the fixes. I'd say let's go with PRs against the ivana/python-3.13 branch for now so that we have everything tested eventually (once we manage to get the test suite to run -- looks like pytest 8.2.1 works with 3.13, but e.g. pytest-asyncio doesn't yet).

@rominf
Copy link
Contributor

rominf commented Jul 10, 2024

@sentrivana PRs #3271 and #3272 when combined together, should make Python 3.13 tests pass.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jul 10, 2024
@szokeasaurusrex
Copy link
Member

Thanks @rominf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants