From 95bf2b11718aeae1fb005d221a6f61e375a18cd7 Mon Sep 17 00:00:00 2001 From: Ash Anand Date: Thu, 20 Jun 2024 15:18:38 -0400 Subject: [PATCH 1/2] do not include command in span description --- sentry_sdk/integrations/pymongo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sentry_sdk/integrations/pymongo.py b/sentry_sdk/integrations/pymongo.py index 1269fc6538..3492b9c5a6 100644 --- a/sentry_sdk/integrations/pymongo.py +++ b/sentry_sdk/integrations/pymongo.py @@ -155,7 +155,7 @@ def started(self, event): if not should_send_default_pii(): command = _strip_pii(command) - query = "{} {}".format(event.command_name, command) + query = "{}".format(command) span = sentry_sdk.start_span(op=op, description=query) for tag, value in tags.items(): From 788e48188644f38143224cf24a78cd4bc645c4fe Mon Sep 17 00:00:00 2001 From: Ash Anand Date: Thu, 20 Jun 2024 17:01:12 -0400 Subject: [PATCH 2/2] update test --- tests/integrations/pymongo/test_pymongo.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/integrations/pymongo/test_pymongo.py b/tests/integrations/pymongo/test_pymongo.py index 89701c9f3a..c25310e361 100644 --- a/tests/integrations/pymongo/test_pymongo.py +++ b/tests/integrations/pymongo/test_pymongo.py @@ -71,9 +71,9 @@ def test_transactions(sentry_init, capture_events, mongo_server, with_pii): assert insert_success["tags"]["db.operation"] == "insert" assert insert_fail["tags"]["db.operation"] == "insert" - assert find["description"].startswith("find {") - assert insert_success["description"].startswith("insert {") - assert insert_fail["description"].startswith("insert {") + assert find["description"].startswith("{'find") + assert insert_success["description"].startswith("{'insert") + assert insert_fail["description"].startswith("{'insert") if with_pii: assert "1" in find["description"] assert "2" in insert_success["description"] @@ -113,7 +113,7 @@ def test_breadcrumbs(sentry_init, capture_events, mongo_server, with_pii): (crumb,) = event["breadcrumbs"]["values"] assert crumb["category"] == "query" - assert crumb["message"].startswith("find {") + assert crumb["message"].startswith("{'find") if with_pii: assert "1" in crumb["message"] else: