Skip to content

Commit bab8d22

Browse files
Merge 1a71f24 into cc471c7
2 parents cc471c7 + 1a71f24 commit bab8d22

File tree

4 files changed

+21
-8
lines changed

4 files changed

+21
-8
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
```
3737

3838
- Export `Span` type from `@sentry/types` ([#4345](https://github.com/getsentry/sentry-react-native/pull/4345))
39+
- Add RN SDK package to `sdk.packages` on Android ([#4380](https://github.com/getsentry/sentry-react-native/pull/4380))
3940

4041
### Fixes
4142

packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java

+8-7
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,6 @@ public class RNSentryModuleImpl {
9393

9494
public static final String NAME = "RNSentry";
9595

96-
private static final String NATIVE_SDK_NAME = "sentry.native.android.react-native";
97-
private static final String ANDROID_SDK_NAME = "sentry.java.android.react-native";
9896
private static final ILogger logger = new AndroidLogger(NAME);
9997
private static final BuildInfoProvider buildInfo = new BuildInfoProvider(logger);
10098
private static final String modulesPath = "modules.json";
@@ -191,13 +189,16 @@ protected void getSentryAndroidOptions(
191189
@NotNull SentryAndroidOptions options, @NotNull ReadableMap rnOptions, ILogger logger) {
192190
@Nullable SdkVersion sdkVersion = options.getSdkVersion();
193191
if (sdkVersion == null) {
194-
sdkVersion = new SdkVersion(ANDROID_SDK_NAME, BuildConfig.VERSION_NAME);
192+
sdkVersion = new SdkVersion(RNSentryVersion.ANDROID_SDK_NAME, BuildConfig.VERSION_NAME);
195193
} else {
196-
sdkVersion.setName(ANDROID_SDK_NAME);
194+
sdkVersion.setName(RNSentryVersion.ANDROID_SDK_NAME);
197195
}
196+
sdkVersion.addPackage(
197+
RNSentryVersion.REACT_NATIVE_SDK_PACKAGE_NAME,
198+
RNSentryVersion.REACT_NATIVE_SDK_PACKAGE_VERSION);
198199

199200
options.setSentryClientName(sdkVersion.getName() + "/" + sdkVersion.getVersion());
200-
options.setNativeSdkName(NATIVE_SDK_NAME);
201+
options.setNativeSdkName(RNSentryVersion.NATIVE_SDK_NAME);
201202
options.setSdkVersion(sdkVersion);
202203

203204
if (rnOptions.hasKey("debug") && rnOptions.getBoolean("debug")) {
@@ -970,10 +971,10 @@ private void setEventOriginTag(SentryEvent event) {
970971
SdkVersion sdk = event.getSdk();
971972
if (sdk != null) {
972973
switch (sdk.getName()) {
973-
case NATIVE_SDK_NAME:
974+
case RNSentryVersion.NATIVE_SDK_NAME:
974975
setEventEnvironmentTag(event, "native");
975976
break;
976-
case ANDROID_SDK_NAME:
977+
case RNSentryVersion.ANDROID_SDK_NAME:
977978
setEventEnvironmentTag(event, "java");
978979
break;
979980
default:
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package io.sentry.react;
2+
3+
class RNSentryVersion {
4+
static final String REACT_NATIVE_SDK_PACKAGE_NAME = "npm:@sentry/react-native";
5+
static final String REACT_NATIVE_SDK_PACKAGE_VERSION = "6.4.0";
6+
static final String NATIVE_SDK_NAME = "sentry.native.android.react-native";
7+
static final String ANDROID_SDK_NAME = "sentry.java.android.react-native";
8+
}

scripts/version-bump.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@ const replace = require('replace-in-file');
44
const pjson = require('../packages/core/package.json');
55

66
replace({
7-
files: ['packages/core/src/js/version.ts'],
7+
files: [
8+
'packages/core/src/js/version.ts',
9+
'packages/core/android/src/main/java/io/sentry/react/RNSentryVersion.java',
10+
],
811
from: /\d+\.\d+.\d+(?:-\w+(?:\.\w+)?)?/g,
912
to: pjson.version,
1013
})

0 commit comments

Comments
 (0)