Merge d2dd1f3 into 56a113e

Author: antonis

packages/core/src/js/feedback/FeedbackForm.tsx

@@ -155,9 +155,17 @@ export class FeedbackForm extends React.Component<FeedbackFormProps, FeedbackFor
       } else {
         // Defaulting to the onAddScreenshot callback
         const { onAddScreenshot } = { ...defaultConfiguration, ...this.props };
-        onAddScreenshot((filename: string, attachement: Uint8Array) => {
-          // TODO: Add support for image uri when using onAddScreenshot
-          this.setState({ filename, attachment: attachement, attachmentUri: undefined }, this._saveFormState);
+        onAddScreenshot((filename: string, fileUri: string) => {
+          NATIVE.getDataFromUri(fileUri).then((data) => {
+            if (data != null) {
+              this.setState({ filename, attachment: data, attachmentUri: fileUri }, this._saveFormState);
+            } else {
+              logger.error('Failed to read image data from uri:', fileUri);
+            }
+          })
+          .catch((error) => {
+            logger.error('Failed to read image data from uri:', fileUri, 'error: ', error);
+          });
         });
       }
     } else {

packages/core/src/js/feedback/FeedbackForm.types.ts

@@ -171,7 +171,7 @@ export interface FeedbackCallbacks {
   /**
    * Callback when a screenshot is added
    */
-  onAddScreenshot?: (attachFile: (filename: string, data: Uint8Array) => void) => void;
+  onAddScreenshot?: (attachFile: (filename: string, fileUri: string) => void) => void;
 
   /**
    * Callback when feedback is successfully submitted

packages/core/src/js/feedback/defaults.ts

@@ -33,7 +33,7 @@ export const defaultConfiguration: Partial<FeedbackFormProps> = {
       );
     }
   },
-  onAddScreenshot: (_: (filename: string, data: Uint8Array) => void) => {
+  onAddScreenshot: (_: (filename: string, fileUri: string) => void) => {
     if (__DEV__) {
       Alert.alert('Development note', 'onAddScreenshot callback is not implemented.');
     }