Skip to content

Commit f14197d

Browse files
committed
Use only the uri parameter for the onAddScreenshot callback
1 parent 91117e3 commit f14197d

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

packages/core/src/js/feedback/FeedbackWidget.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -155,16 +155,16 @@ export class FeedbackWidget extends React.Component<FeedbackWidgetProps, Feedbac
155155
} else {
156156
// Defaulting to the onAddScreenshot callback
157157
const { onAddScreenshot } = { ...defaultConfiguration, ...this.props };
158-
onAddScreenshot((filename: string, fileUri: string) => {
159-
NATIVE.getDataFromUri(fileUri).then((data) => {
158+
onAddScreenshot((uri: string) => {
159+
NATIVE.getDataFromUri(uri).then((data) => {
160160
if (data != null) {
161-
this.setState({ filename, attachment: data, attachmentUri: fileUri });
161+
this.setState({ filename: 'feedback_screenshot', attachment: data, attachmentUri: uri });
162162
} else {
163-
logger.error('Failed to read image data from uri:', fileUri);
163+
logger.error('Failed to read image data from uri:', uri);
164164
}
165165
})
166166
.catch((error) => {
167-
logger.error('Failed to read image data from uri:', fileUri, 'error: ', error);
167+
logger.error('Failed to read image data from uri:', uri, 'error: ', error);
168168
});
169169
});
170170
}

packages/core/src/js/feedback/FeedbackWidget.types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export interface FeedbackCallbacks {
171171
/**
172172
* Callback when a screenshot is added
173173
*/
174-
onAddScreenshot?: (attachFile: (filename: string, fileUri: string) => void) => void;
174+
onAddScreenshot?: (screenshotAdded: (uri: string) => void) => void;
175175

176176
/**
177177
* Callback when feedback is successfully submitted

packages/core/src/js/feedback/defaults.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export const defaultConfiguration: Partial<FeedbackWidgetProps> = {
3333
);
3434
}
3535
},
36-
onAddScreenshot: (_: (filename: string, fileUri: string) => void) => {
36+
onAddScreenshot: (_: (uri: string) => void) => {
3737
if (__DEV__) {
3838
Alert.alert('Development note', 'onAddScreenshot callback is not implemented.');
3939
}

0 commit comments

Comments
 (0)