Skip to content

Commit f6e950e

Browse files
committed
Merge branch 'feedback-ui-2' into antonis/capture-screenshot-error
2 parents 9590707 + 4610d7f commit f6e950e

File tree

2 files changed

+17
-11
lines changed

2 files changed

+17
-11
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
- Fixes Feedback Widget accessibility issue on iOS ([#4739](https://github.com/getsentry/sentry-react-native/pull/4739))
2121
- Prevent crash on iOS during profiling stop when debug images are missing ([#4738](https://github.com/getsentry/sentry-react-native/pull/4738))
2222
- Attach only App Starts within the 60s threshold (fixed comparison units, use ms) ([#4746](https://github.com/getsentry/sentry-react-native/pull/4746))
23+
- Add missing `popTimeToDisplayFor` in to the Android Old Arch Native interface([#4751](https://github.com/getsentry/sentry-react-native/pull/4751))
2324

2425
### Dependencies
2526

packages/core/android/src/oldarch/java/io/sentry/react/RNSentryModule.java

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -152,16 +152,6 @@ public String fetchNativePackageName() {
152152
return this.impl.fetchNativePackageName();
153153
}
154154

155-
@ReactMethod
156-
public void getDataFromUri(String uri, Promise promise) {
157-
this.impl.getDataFromUri(uri, promise);
158-
}
159-
160-
@ReactMethod
161-
public void encodeToBase64(ReadableArray array, Promise promise) {
162-
this.impl.encodeToBase64(array, promise);
163-
}
164-
165155
@ReactMethod(isBlockingSynchronousMethod = true)
166156
public WritableMap fetchNativeStackFramesBy(ReadableArray instructionsAddr) {
167157
// Not used on Android
@@ -183,11 +173,26 @@ public void crashedLastRun(Promise promise) {
183173
this.impl.crashedLastRun(promise);
184174
}
185175

186-
@ReactMethod()
176+
@ReactMethod
187177
public void getNewScreenTimeToDisplay(Promise promise) {
188178
this.impl.getNewScreenTimeToDisplay(promise);
189179
}
190180

181+
@ReactMethod
182+
public void getDataFromUri(String uri, Promise promise) {
183+
this.impl.getDataFromUri(uri, promise);
184+
}
185+
186+
@ReactMethod
187+
public void encodeToBase64(ReadableArray array, Promise promise) {
188+
this.impl.encodeToBase64(array, promise);
189+
}
190+
191+
@ReactMethod
192+
public void popTimeToDisplayFor(String key, Promise promise) {
193+
this.impl.popTimeToDisplayFor(key, promise);
194+
}
195+
191196
@ReactMethod
192197
public boolean setActiveSpanId(String spanId) {
193198
return this.impl.setActiveSpanId(spanId);

0 commit comments

Comments
 (0)