Skip to content

Commit 02d2282

Browse files
ArthurKnausarmenzg
authored andcommitted
ref(cardinality-limit): Streamline option names for cardinality limits (#69563)
The options for cardinality limits used the old `performance` and `releasehealth` names instead of the regular namespace identifiers `transactions` and `sessions`, respectively. Options with the correct naming had been registered before. This PR swaps out the mapping to use the correct naming and deprecates the old options. Requires getsentry/sentry-options-automator#1210
1 parent 63994a8 commit 02d2282

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/sentry/sentry_metrics/use_case_id_registry.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ class UseCaseID(Enum):
5555
}
5656

5757
USE_CASE_ID_CARDINALITY_LIMIT_QUOTA_OPTIONS = {
58-
UseCaseID.TRANSACTIONS: "sentry-metrics.cardinality-limiter.limits.performance.per-org",
59-
UseCaseID.SESSIONS: "sentry-metrics.cardinality-limiter.limits.releasehealth.per-org",
58+
UseCaseID.TRANSACTIONS: "sentry-metrics.cardinality-limiter.limits.transactions.per-org",
59+
UseCaseID.SESSIONS: "sentry-metrics.cardinality-limiter.limits.sessions.per-org",
6060
UseCaseID.SPANS: "sentry-metrics.cardinality-limiter.limits.spans.per-org",
6161
UseCaseID.CUSTOM: "sentry-metrics.cardinality-limiter.limits.custom.per-org",
6262
UseCaseID.PROFILES: "sentry-metrics.cardinality-limiter.limits.profiles.per-org",

tests/sentry/relay/test_config.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -885,10 +885,10 @@ def test_performance_calculate_score(default_project):
885885
@pytest.mark.parametrize("passive", [False, True])
886886
def test_project_config_cardinality_limits(default_project, insta_snapshot, passive):
887887
options: dict[Any, Any] = {
888-
"sentry-metrics.cardinality-limiter.limits.performance.per-org": [
888+
"sentry-metrics.cardinality-limiter.limits.transactions.per-org": [
889889
{"window_seconds": 1000, "granularity_seconds": 100, "limit": 10}
890890
],
891-
"sentry-metrics.cardinality-limiter.limits.releasehealth.per-org": [
891+
"sentry-metrics.cardinality-limiter.limits.sessions.per-org": [
892892
{"window_seconds": 2000, "granularity_seconds": 200, "limit": 20}
893893
],
894894
"sentry-metrics.cardinality-limiter.limits.spans.per-org": [

0 commit comments

Comments
 (0)