Skip to content

Commit 0729289

Browse files
Revert "ref(quick-start): Update backend enums names (#83361)"
This reverts commit 361d204. Co-authored-by: asottile-sentry <[email protected]>
1 parent ba96065 commit 0729289

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

src/sentry/models/organizationonboardingtask.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ class AbstractOnboardingTask(Model):
103103

104104
# abstract
105105
TASK_LOOKUP_BY_KEY: dict[str, int]
106-
SKIPPABLE_TASKS: frozenset[int]
106+
NEW_SKIPPABLE_TASKS: frozenset[int]
107107

108108
class Meta:
109109
abstract = True
@@ -141,7 +141,7 @@ class OrganizationOnboardingTask(AbstractOnboardingTask):
141141

142142
# Tasks which should be completed for the onboarding to be considered
143143
# complete.
144-
REQUIRED_ONBOARDING_TASKS = frozenset(
144+
NEW_REQUIRED_ONBOARDING_TASKS = frozenset(
145145
[
146146
OnboardingTask.FIRST_PROJECT,
147147
OnboardingTask.FIRST_EVENT,
@@ -156,14 +156,14 @@ class OrganizationOnboardingTask(AbstractOnboardingTask):
156156
]
157157
)
158158

159-
REQUIRED_ONBOARDING_TASKS_WITH_SOURCE_MAPS = frozenset(
159+
NEW_REQUIRED_ONBOARDING_TASKS_WITH_SOURCE_MAPS = frozenset(
160160
[
161-
*REQUIRED_ONBOARDING_TASKS,
161+
*NEW_REQUIRED_ONBOARDING_TASKS,
162162
OnboardingTask.SOURCEMAPS,
163163
]
164164
)
165165

166-
SKIPPABLE_TASKS = frozenset(
166+
NEW_SKIPPABLE_TASKS = frozenset(
167167
[
168168
OnboardingTask.INVITE_MEMBER,
169169
OnboardingTask.SECOND_PLATFORM,

src/sentry/onboarding_tasks/backends/organization_onboarding_task.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,9 @@ def try_mark_onboarding_complete(
5656
# It's possible that the first project doesn't have source maps,
5757
# but the second project (which users are guided to create in the "Add Sentry to other parts of the app" step) may have source maps.
5858
required_tasks = (
59-
OrganizationOnboardingTask.REQUIRED_ONBOARDING_TASKS_WITH_SOURCE_MAPS
59+
OrganizationOnboardingTask.NEW_REQUIRED_ONBOARDING_TASKS_WITH_SOURCE_MAPS
6060
if project_with_source_maps
61-
else OrganizationOnboardingTask.REQUIRED_ONBOARDING_TASKS
61+
else OrganizationOnboardingTask.NEW_REQUIRED_ONBOARDING_TASKS
6262
)
6363

6464
if completed >= required_tasks:

src/sentry/onboarding_tasks/base.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def get_status_lookup_by_key(self, key):
3131
return self.Model.STATUS_LOOKUP_BY_KEY.get(key)
3232

3333
def get_skippable_tasks(self, organization: Organization, user: User | RpcUser | AnonymousUser):
34-
return self.Model.SKIPPABLE_TASKS
34+
return self.Model.NEW_SKIPPABLE_TASKS
3535

3636
def fetch_onboarding_tasks(self, organization, user):
3737
raise NotImplementedError

tests/sentry/api/endpoints/test_onboarding.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def test_skip_skippable_tasks(self):
1717
"""
1818
Test if the tasks marked as skippable in the new quick start are skipped
1919
"""
20-
skippable_tasks = OrganizationOnboardingTask.SKIPPABLE_TASKS
20+
skippable_tasks = OrganizationOnboardingTask.NEW_SKIPPABLE_TASKS
2121

2222
def get_skipped_tasks():
2323
return set(

0 commit comments

Comments
 (0)