Skip to content

Commit 07398c4

Browse files
committed
🔥 rm legacy browser update flag
1 parent b60c72d commit 07398c4

File tree

1 file changed

+5
-15
lines changed

1 file changed

+5
-15
lines changed

static/app/views/settings/project/projectFilters/projectFiltersSettings.tsx

+5-15
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,6 @@ type RowProps = {
188188
data: {
189189
active: string[] | boolean;
190190
};
191-
hasLegacyBrowserUpdate: boolean;
192191
onToggle: (
193192
data: RowProps['data'],
194193
filters: RowState['subfilters'],
@@ -211,8 +210,7 @@ class LegacyBrowserFilterRow extends Component<RowProps, RowState> {
211210
if (props.data.active === true) {
212211
initialSubfilters = new Set(
213212
Object.keys(LEGACY_BROWSER_SUBFILTERS).filter(
214-
key =>
215-
LEGACY_BROWSER_SUBFILTERS[key].legacy === !this.props.hasLegacyBrowserUpdate
213+
key => !LEGACY_BROWSER_SUBFILTERS[key].legacy
216214
)
217215
);
218216
} else if (props.data.active === false) {
@@ -234,8 +232,7 @@ class LegacyBrowserFilterRow extends Component<RowProps, RowState> {
234232
if (subfilter === true) {
235233
subfilters = new Set(
236234
Object.keys(LEGACY_BROWSER_SUBFILTERS).filter(
237-
key =>
238-
LEGACY_BROWSER_SUBFILTERS[key].legacy === !this.props.hasLegacyBrowserUpdate
235+
key => !LEGACY_BROWSER_SUBFILTERS[key].legacy
239236
)
240237
);
241238
} else if (subfilter === false) {
@@ -293,13 +290,10 @@ class LegacyBrowserFilterRow extends Component<RowProps, RowState> {
293290
<FilterGrid>
294291
{Object.keys(LEGACY_BROWSER_SUBFILTERS)
295292
.filter(key => {
296-
if (this.props.hasLegacyBrowserUpdate) {
297-
if (!LEGACY_BROWSER_SUBFILTERS[key].legacy) {
298-
return true;
299-
}
300-
return this.state.subfilters.has(key);
293+
if (!LEGACY_BROWSER_SUBFILTERS[key].legacy) {
294+
return true;
301295
}
302-
return LEGACY_BROWSER_SUBFILTERS[key].legacy;
296+
return this.state.subfilters.has(key);
303297
})
304298
.map(key => {
305299
const subfilter = LEGACY_BROWSER_SUBFILTERS[key];
@@ -405,9 +399,6 @@ type Filter = {
405399
export function ProjectFiltersSettings({project, params, features}: Props) {
406400
const organization = useOrganization();
407401
const {projectId: projectSlug} = params;
408-
409-
const hasLegacyBrowserUpdate = organization.features.includes('legacy-browser-update');
410-
411402
const projectEndpoint = `/projects/${organization.slug}/${projectSlug}/`;
412403
const filtersEndpoint = `${projectEndpoint}filters/`;
413404

@@ -511,7 +502,6 @@ export function ProjectFiltersSettings({project, params, features}: Props) {
511502
onToggle={(_data, subfilters, event) =>
512503
handleLegacyChange({onChange, onBlur, event, subfilters})
513504
}
514-
hasLegacyBrowserUpdate={hasLegacyBrowserUpdate}
515505
/>
516506
)}
517507
</FormField>

0 commit comments

Comments
 (0)