Skip to content

Commit 0756bc9

Browse files
snigdhasandrewshie-sentry
authored andcommitted
feat(metric-issues): Hide log level indicator for non-error issues (#83354)
<img width="444" alt="image" src="https://github.com/user-attachments/assets/8a8e66fe-8efc-4110-ab1b-a6b733260986" /> <img width="444" alt="image" src="https://github.com/user-attachments/assets/e43f9279-0e6c-45ef-81dc-9d2ec74843e5" />
1 parent 4756c7a commit 0756bc9

File tree

5 files changed

+14
-3
lines changed

5 files changed

+14
-3
lines changed

Diff for: static/app/utils/issueTypeConfig/errorConfig.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export const errorConfig: IssueCategoryConfigMapping = {
2323
},
2424
attachments: {enabled: true},
2525
autofix: true,
26+
logLevel: {enabled: true},
2627
mergedIssues: {enabled: true},
2728
replays: {enabled: true},
2829
similarIssues: {enabled: true},

Diff for: static/app/utils/issueTypeConfig/index.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ const BASE_CONFIG: IssueTypeConfig = {
4444
autofix: false,
4545
eventAndUserCounts: {enabled: true},
4646
events: {enabled: true},
47+
logLevel: {enabled: false},
4748
mergedIssues: {enabled: false},
4849
filterAndSearchHeader: {enabled: true},
4950
performanceDurationRegression: {enabled: false},

Diff for: static/app/utils/issueTypeConfig/types.tsx

+4
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,10 @@ export type IssueTypeConfig = {
6464
* Is the Issue Summary available for this issue
6565
*/
6666
issueSummary: DisabledWithReasonConfig;
67+
/**
68+
* Is the Log Level icon shown for this issue
69+
*/
70+
logLevel: DisabledWithReasonConfig;
6771
/**
6872
* Is the Merged Issues tab shown for this issue
6973
*/

Diff for: static/app/views/issueDetails/streamline/header/header.tsx

+7-3
Original file line numberDiff line numberDiff line change
@@ -195,11 +195,15 @@ export default function StreamlinedGroupHeader({
195195
))}
196196
</StatTitle>
197197
<Flex gap={space(1)} align="center" justify="flex-start">
198-
<ErrorLevel level={group.level} size={'10px'} />
199-
{group.isUnhandled && <UnhandledTag />}
198+
<Fragment>
199+
{issueTypeConfig.logLevel.enabled && (
200+
<ErrorLevel level={group.level} size={'10px'} />
201+
)}
202+
{group.isUnhandled && <UnhandledTag />}
203+
{(issueTypeConfig.logLevel.enabled || group.isUnhandled) && <Divider />}
204+
</Fragment>
200205
{statusProps?.status ? (
201206
<Fragment>
202-
<Divider />
203207
<Tooltip title={statusProps?.tooltip}>
204208
<Subtext>{statusProps?.status}</Subtext>
205209
</Tooltip>

Diff for: static/app/views/issueDetails/streamline/sidebar/solutionsSection.spec.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ describe('SolutionsSection', () => {
7272
events: {enabled: false},
7373
evidence: null,
7474
filterAndSearchHeader: {enabled: false},
75+
logLevel: {enabled: true},
7576
mergedIssues: {enabled: false},
7677
performanceDurationRegression: {enabled: false},
7778
profilingDurationRegression: {enabled: false},

0 commit comments

Comments
 (0)