chore: cleanup bitfield (#16031)

Author: josh

src/bitfield/forms.py

@@ -2,9 +2,8 @@
 
 import six
 
-from django.db.models.fields import BigIntegerField, Field
+from django.db.models.fields import BigIntegerField
 
-from bitfield.forms import BitFormField
 from bitfield.query import BitQueryExactLookupStub
 from bitfield.types import Bit, BitHandler
 
@@ -119,10 +118,6 @@ def __init__(self, flags, default=None, *args, **kwargs):
         self.flags = flags
         self.labels = labels
 
-    def formfield(self, form_class=BitFormField, **kwargs):
-        choices = [(k, self.labels[self.flags.index(k)]) for k in self.flags]
-        return Field.formfield(self, form_class, choices=choices, **kwargs)
-
     def pre_save(self, instance, add):
         value = getattr(instance, self.attname)
         return value
@@ -134,20 +129,6 @@ def get_prep_value(self, value):
             value = value.mask
         return int(value)
 
-    def get_db_prep_lookup(self, lookup_type, value, connection, prepared=False):
-        if isinstance(value, (BitHandler, Bit)):
-            raise NotImplementedError("get_db_prep_lookup not supported with types Bit, BitHandler")
-
-        return BigIntegerField.get_db_prep_lookup(
-            self, lookup_type=lookup_type, value=value, connection=connection, prepared=prepared
-        )
-
-    def get_prep_lookup(self, lookup_type, value):
-        if isinstance(value, Bit):
-            raise NotImplementedError("Lookup type %r not supported with Bit type." % lookup_type)
-
-        return BigIntegerField.get_prep_lookup(self, lookup_type, value)
-
     def to_python(self, value):
         if isinstance(value, Bit):
             value = value.mask

src/bitfield/models.py

@@ -367,51 +367,3 @@ def test_added_field(self):
         data = pickle.dumps(bf)
         inst = pickle.loads(data)
         self.assertTrue("FLAG_3" in inst.flags.keys())
-
-
-class BitFormFieldTest(TestCase):
-    def test_form_new_invalid(self):
-        invalid_data_dicts = [
-            {"flags": ["FLAG_0", "FLAG_FLAG"]},
-            {"flags": ["FLAG_4"]},
-            {"flags": [1, 2]},
-        ]
-        for invalid_data in invalid_data_dicts:
-            form = BitFieldTestModelForm(data=invalid_data)
-            self.assertFalse(form.is_valid())
-
-    def test_form_new(self):
-        data_dicts = [{"flags": ["FLAG_0", "FLAG_1"]}, {"flags": ["FLAG_3"]}, {"flags": []}, {}]
-        for data in data_dicts:
-            form = BitFieldTestModelForm(data=data)
-            self.failUnless(form.is_valid())
-            instance = form.save()
-            flags = data["flags"] if "flags" in data else []
-            for k in BitFieldTestModel.flags:
-                self.assertEquals(bool(getattr(instance.flags, k)), k in flags)
-
-    def test_form_update(self):
-        instance = BitFieldTestModel.objects.create(flags=0)
-        for k in BitFieldTestModel.flags:
-            self.assertFalse(bool(getattr(instance.flags, k)))
-
-        data = {"flags": ["FLAG_0", "FLAG_1"]}
-        form = BitFieldTestModelForm(data=data, instance=instance)
-        self.failUnless(form.is_valid())
-        instance = form.save()
-        for k in BitFieldTestModel.flags:
-            self.assertEquals(bool(getattr(instance.flags, k)), k in data["flags"])
-
-        data = {"flags": ["FLAG_2", "FLAG_3"]}
-        form = BitFieldTestModelForm(data=data, instance=instance)
-        self.failUnless(form.is_valid())
-        instance = form.save()
-        for k in BitFieldTestModel.flags:
-            self.assertEquals(bool(getattr(instance.flags, k)), k in data["flags"])
-
-        data = {"flags": []}
-        form = BitFieldTestModelForm(data=data, instance=instance)
-        self.failUnless(form.is_valid())
-        instance = form.save()
-        for k in BitFieldTestModel.flags:
-            self.assertFalse(bool(getattr(instance.flags, k)))