Skip to content

Commit 13ebbc6

Browse files
KevinL10KevinL10
authored
ref(insights): remove performance-sample-panel-search feature (#76206)
We GA'd sample panel search a few months ago. Cleans up the feature flag.
1 parent ca7f548 commit 13ebbc6

File tree

6 files changed

+57
-73
lines changed

6 files changed

+57
-73
lines changed

‎src/sentry/features/temporary.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,8 +269,6 @@ def register_temporary_features(manager: FeatureManager):
269269
manager.add("organizations:performance-queries-mongodb-extraction", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
270270
# Enable removing the fallback for metrics compatibility
271271
manager.add("organizations:performance-remove-metrics-compatibility-fallback", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
272-
# Enable span search bar in Insights module sample panels
273-
manager.add("organizations:performance-sample-panel-search", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
274272
# Enable platform selector for screens flow
275273
manager.add("organizations:performance-screens-platform-selector", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
276274
# Enable screens view powered by span metrics

‎static/app/views/insights/cache/components/samplePanel.tsx

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import styled from '@emotion/styled';
33
import keyBy from 'lodash/keyBy';
44
import * as qs from 'query-string';
55

6-
import Feature from 'sentry/components/acl/feature';
76
import ProjectAvatar from 'sentry/components/avatar/projectAvatar';
87
import {Button} from 'sentry/components/button';
98
import {CompactSelect} from 'sentry/components/compactSelect';
@@ -392,20 +391,18 @@ export function CacheSamplePanel() {
392391
/>
393392
</ModuleLayout.Half>
394393

395-
<Feature features="performance-sample-panel-search">
396-
<ModuleLayout.Full>
397-
<SearchBar
398-
searchSource={`${ModuleName.CACHE}-sample-panel`}
399-
query={query.spanSearchQuery}
400-
onSearch={handleSearch}
401-
placeholder={t('Search for span attributes')}
402-
organization={organization}
403-
supportedTags={supportedTags}
404-
dataset={DiscoverDatasets.SPANS_INDEXED}
405-
projectIds={selection.projects}
406-
/>
407-
</ModuleLayout.Full>
408-
</Feature>
394+
<ModuleLayout.Full>
395+
<SearchBar
396+
searchSource={`${ModuleName.CACHE}-sample-panel`}
397+
query={query.spanSearchQuery}
398+
onSearch={handleSearch}
399+
placeholder={t('Search for span attributes')}
400+
organization={organization}
401+
supportedTags={supportedTags}
402+
dataset={DiscoverDatasets.SPANS_INDEXED}
403+
projectIds={selection.projects}
404+
/>
405+
</ModuleLayout.Full>
409406

410407
<Fragment>
411408
<ModuleLayout.Full>

‎static/app/views/insights/common/views/spanSummaryPage/sampleList/index.tsx

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import debounce from 'lodash/debounce';
44
import omit from 'lodash/omit';
55
import * as qs from 'query-string';
66

7-
import Feature from 'sentry/components/acl/feature';
87
import ProjectAvatar from 'sentry/components/avatar/projectAvatar';
98
import SearchBar from 'sentry/components/events/searchBar';
109
import {COL_WIDTH_UNDEFINED} from 'sentry/components/gridEditable';
@@ -219,18 +218,16 @@ export function SampleList({
219218
highlightedSpanId={highlightedSpanId}
220219
/>
221220

222-
<Feature features="performance-sample-panel-search">
223-
<StyledSearchBar
224-
searchSource={`${moduleName}-sample-panel`}
225-
query={spanSearchQuery}
226-
onSearch={handleSearch}
227-
placeholder={t('Search for span attributes')}
228-
organization={organization}
229-
supportedTags={supportedTags}
230-
dataset={DiscoverDatasets.SPANS_INDEXED}
231-
projectIds={selection.projects}
232-
/>
233-
</Feature>
221+
<StyledSearchBar
222+
searchSource={`${moduleName}-sample-panel`}
223+
query={spanSearchQuery}
224+
onSearch={handleSearch}
225+
placeholder={t('Search for span attributes')}
226+
organization={organization}
227+
supportedTags={supportedTags}
228+
dataset={DiscoverDatasets.SPANS_INDEXED}
229+
projectIds={selection.projects}
230+
/>
234231

235232
<SampleTable
236233
highlightedSpanId={highlightedSpanId}

‎static/app/views/insights/http/components/httpSamplesPanel.tsx

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import {Fragment, useCallback} from 'react';
22
import styled from '@emotion/styled';
33
import * as qs from 'query-string';
44

5-
import Feature from 'sentry/components/acl/feature';
65
import ProjectAvatar from 'sentry/components/avatar/projectAvatar';
76
import {Button} from 'sentry/components/button';
87
import {CompactSelect} from 'sentry/components/compactSelect';
@@ -463,20 +462,18 @@ export function HTTPSamplesPanel() {
463462
</Fragment>
464463
)}
465464

466-
<Feature features="performance-sample-panel-search">
467-
<ModuleLayout.Full>
468-
<SearchBar
469-
searchSource={`${ModuleName.HTTP}-sample-panel`}
470-
query={query.spanSearchQuery}
471-
onSearch={handleSearch}
472-
placeholder={t('Search for span attributes')}
473-
organization={organization}
474-
supportedTags={supportedTags}
475-
dataset={DiscoverDatasets.SPANS_INDEXED}
476-
projectIds={selection.projects}
477-
/>
478-
</ModuleLayout.Full>
479-
</Feature>
465+
<ModuleLayout.Full>
466+
<SearchBar
467+
searchSource={`${ModuleName.HTTP}-sample-panel`}
468+
query={query.spanSearchQuery}
469+
onSearch={handleSearch}
470+
placeholder={t('Search for span attributes')}
471+
organization={organization}
472+
supportedTags={supportedTags}
473+
dataset={DiscoverDatasets.SPANS_INDEXED}
474+
projectIds={selection.projects}
475+
/>
476+
</ModuleLayout.Full>
480477

481478
{query.panel === 'duration' && (
482479
<Fragment>

‎static/app/views/insights/mobile/common/components/spanSamplesPanelContainer.tsx

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import {Fragment, useCallback, useState} from 'react';
22
import styled from '@emotion/styled';
33
import debounce from 'lodash/debounce';
44

5-
import Feature from 'sentry/components/acl/feature';
65
import SearchBar from 'sentry/components/events/searchBar';
76
import {COL_WIDTH_UNDEFINED} from 'sentry/components/gridEditable';
87
import Link from 'sentry/components/links/link';
@@ -198,18 +197,17 @@ export function SpanSamplesContainer({
198197
platform={isProjectCrossPlatform ? selectedPlatform : undefined}
199198
/>
200199

201-
<Feature features="performance-sample-panel-search">
202-
<StyledSearchBar
203-
searchSource={`${moduleName}-sample-panel`}
204-
query={searchQuery}
205-
onSearch={handleSearch}
206-
placeholder={t('Search for span attributes')}
207-
organization={organization}
208-
supportedTags={supportedTags}
209-
dataset={DiscoverDatasets.SPANS_INDEXED}
210-
projectIds={selection.projects}
211-
/>
212-
</Feature>
200+
<StyledSearchBar
201+
searchSource={`${moduleName}-sample-panel`}
202+
query={searchQuery}
203+
onSearch={handleSearch}
204+
placeholder={t('Search for span attributes')}
205+
organization={organization}
206+
supportedTags={supportedTags}
207+
dataset={DiscoverDatasets.SPANS_INDEXED}
208+
projectIds={selection.projects}
209+
/>
210+
213211
<SampleTable
214212
referrer={TraceViewSources.APP_STARTS_MODULE}
215213
spanSearch={spanSearch}

‎static/app/views/insights/queues/components/messageSpanSamplesPanel.tsx

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import {useCallback} from 'react';
22
import styled from '@emotion/styled';
33
import * as qs from 'query-string';
44

5-
import Feature from 'sentry/components/acl/feature';
65
import ProjectAvatar from 'sentry/components/avatar/projectAvatar';
76
import {Button} from 'sentry/components/button';
87
import {CompactSelect, type SelectOption} from 'sentry/components/compactSelect';
@@ -361,20 +360,18 @@ export function MessageSpanSamplesPanel() {
361360
/>
362361
</ModuleLayout.Full>
363362

364-
<Feature features="performance-sample-panel-search">
365-
<ModuleLayout.Full>
366-
<SearchBar
367-
searchSource={`${ModuleName.QUEUE}-sample-panel`}
368-
query={query.spanSearchQuery}
369-
onSearch={handleSearch}
370-
placeholder={t('Search for span attributes')}
371-
organization={organization}
372-
supportedTags={supportedTags}
373-
dataset={DiscoverDatasets.SPANS_INDEXED}
374-
projectIds={selection.projects}
375-
/>
376-
</ModuleLayout.Full>
377-
</Feature>
363+
<ModuleLayout.Full>
364+
<SearchBar
365+
searchSource={`${ModuleName.QUEUE}-sample-panel`}
366+
query={query.spanSearchQuery}
367+
onSearch={handleSearch}
368+
placeholder={t('Search for span attributes')}
369+
organization={organization}
370+
supportedTags={supportedTags}
371+
dataset={DiscoverDatasets.SPANS_INDEXED}
372+
projectIds={selection.projects}
373+
/>
374+
</ModuleLayout.Full>
378375

379376
<ModuleLayout.Full>
380377
<MessageSpanSamplesTable

0 commit comments

Comments
 (0)