perf: Experimentally use orjson in Slack integration (#69409)

This adds an option `"integrations.slack.enable-orjson"` to enable
`orjson` for json parsing (ETA: and dumping) in the slack integration.

Ref: #68903

Author: loewenheim

src/sentry/integrations/slack/actions/notification.py

@@ -97,7 +97,9 @@ def send_notification(event: GroupEvent, futures: Sequence[RuleFuture]) -> None:
             if payload_blocks := blocks.get("blocks"):
                 payload = {
                     "text": blocks.get("text"),
-                    "blocks": json.dumps(payload_blocks),
+                    "blocks": json.dumps_experimental(
+                        "integrations.slack.enable-orjson", payload_blocks
+                    ),
                     "channel": channel,
                     "unfurl_links": False,
                     "unfurl_media": False,
@@ -180,7 +182,9 @@ def send_notification(event: GroupEvent, futures: Sequence[RuleFuture]) -> None:
                     "channel_name": self.get_option("channel"),
                 }
                 # temporarily log the payload so we can debug message failures
-                log_params["payload"] = json.dumps(payload)
+                log_params["payload"] = json.dumps_experimental(
+                    "integrations.slack.enable-orjson", payload
+                )
 
                 self.logger.info(
                     "rule.fail.slack_post",
@@ -250,7 +254,9 @@ def send_confirmation_notification(
         blocks = SlackRuleSaveEditMessageBuilder(rule=rule, new=new, changed=changed).build()
         payload = {
             "text": blocks.get("text"),
-            "blocks": json.dumps(blocks.get("blocks")),
+            "blocks": json.dumps_experimental(
+                "integrations.slack.enable-orjson", blocks.get("blocks")
+            ),
             "channel": channel,
             "unfurl_links": False,
             "unfurl_media": False,

src/sentry/integrations/slack/message_builder/issues.py

@@ -687,6 +687,6 @@ def build(self, notification_uuid: str | None = None) -> SlackBlock:
         return self._build_blocks(
             *blocks,
             fallback_text=self.build_fallback_text(obj, project.slug),
-            block_id=json.dumps(block_id),
+            block_id=json.dumps_experimental("integrations.slack.enable-orjson", block_id),
             skip_fallback=self.skip_fallback,
         )

src/sentry/integrations/slack/message_builder/notifications/base.py

@@ -33,7 +33,11 @@ def build(self) -> SlackBlock:
             self.recipient, ExternalProviders.SLACK
         )
         actions = self.notification.get_message_actions(self.recipient, ExternalProviders.SLACK)
-        callback_id = json.dumps(callback_id_raw) if callback_id_raw else None
+        callback_id = (
+            json.dumps_experimental("integrations.slack.enable-orjson", callback_id_raw)
+            if callback_id_raw
+            else None
+        )
 
         first_block_text = ""
         if title_link:

src/sentry/integrations/slack/message_builder/notifications/daily_summary.py

@@ -189,7 +189,12 @@ def build(self) -> SlackBlock:
 
         text = subject
         callback_id_raw = self.notification.get_callback_data()
-        callback_id = json.dumps(callback_id_raw) if callback_id_raw else None
+        callback_id = (
+            json.dumps_experimental("integrations.slack.enable-orjson", callback_id_raw)
+            if callback_id_raw
+            else None
+        )
+
         footer = self.notification.build_notification_footer(
             self.recipient, ExternalProviders.SLACK
         )

src/sentry/integrations/slack/message_builder/prompt.py

@@ -13,10 +13,11 @@ def __init__(self, url: str) -> None:
 
     def build(self) -> SlackBody:
         return {
-            "blocks": json.dumps(
+            "blocks": json.dumps_experimental(
+                "integrations.slack.enable-orjson",
                 [
                     self.get_markdown_block(LINK_IDENTITY_MESSAGE),
                     self.get_action_block([("Link", self.url, "link"), ("Cancel", None, "ignore")]),
-                ]
+                ],
             )
         }

src/sentry/integrations/slack/notifications.py

@@ -94,15 +94,17 @@ def _notify_recipient(
             "unfurl_links": False,
             "unfurl_media": False,
             "text": text if text else "",
-            "blocks": json.dumps(blocks),
+            "blocks": json.dumps_experimental("integrations.slack.enable-orjson", blocks),
         }
         callback_id = local_attachments.get("callback_id")
         if callback_id:
             # callback_id is now at the same level as blocks, rather than within attachments
             if isinstance(callback_id, str):
                 payload["callback_id"] = callback_id
             else:
-                payload["callback_id"] = json.dumps(local_attachments.get("callback_id"))
+                payload["callback_id"] = json.dumps_experimental(
+                    "integrations.slack.enable-orjson", local_attachments.get("callback_id")
+                )
 
         post_message_task = post_message
         if SiloMode.get_current_mode() == SiloMode.CONTROL:

src/sentry/integrations/slack/requests/action.py

@@ -37,27 +37,39 @@ def callback_data(self) -> JSONData:
             - is_message: did the original message have a 'message' type
         """
         if self.data.get("callback_id"):
-            return json.loads(self.data["callback_id"])
+            return json.loads_experimental(
+                "integrations.slack.enable-orjson", self.data["callback_id"]
+            )
 
         # XXX(CEO): can't really feature flag this but the block kit data is very different
 
         # slack sends us a response when a modal is opened and when an option is selected
         # we don't do anything with it until the user hits "Submit" but we need to handle it anyway
         if self.data["type"] == "block_actions":
             if self.data.get("view"):
-                return json.loads(self.data["view"]["private_metadata"])
+                return json.loads_experimental(
+                    "integrations.slack.enable-orjson", self.data["view"]["private_metadata"]
+                )
+
             elif self.data.get("container", {}).get(
                 "is_app_unfurl"
             ):  # for actions taken on interactive unfurls
-                return json.loads(self.data["app_unfurl"]["blocks"][0]["block_id"])
-            return json.loads(self.data["message"]["blocks"][0]["block_id"])
+                return json.loads_experimental(
+                    "integrations.slack.enable-orjson",
+                    self.data["app_unfurl"]["blocks"][0]["block_id"],
+                )
+            return json.loads_experimental(
+                "integrations.slack.enable-orjson", self.data["message"]["blocks"][0]["block_id"]
+            )
 
         if self.data["type"] == "view_submission":
-            return json.loads(self.data["view"]["private_metadata"])
+            return json.loads_experimental(
+                "integrations.slack.enable-orjson", self.data["view"]["private_metadata"]
+            )
 
         for data in self.data["message"]["blocks"]:
             if data["type"] == "section" and len(data["block_id"]) > 5:
-                return json.loads(data["block_id"])
+                return json.loads_experimental("integrations.slack.enable-orjson", data["block_id"])
                 # a bit hacky, you can only provide a block ID per block (not per entire message),
                 # and if not provided slack generates a 5 char long one. our provided block_id is at least '{issue: <issue_id>}'
                 # so we know it's longer than 5 chars
@@ -74,7 +86,9 @@ def _validate_data(self) -> None:
             raise SlackRequestError(status=status.HTTP_400_BAD_REQUEST)
 
         try:
-            self._data = json.loads(self.data["payload"])
+            self._data = json.loads_experimental(
+                "integrations.slack.enable-orjson", self.data["payload"]
+            )
         except (KeyError, IndexError, TypeError, ValueError):
             raise SlackRequestError(status=status.HTTP_400_BAD_REQUEST)
 

src/sentry/integrations/slack/requests/options_load.py

@@ -19,8 +19,17 @@ class SlackOptionsLoadRequest(SlackRequest):
     @property
     def group_id(self) -> int:
         if self.data.get("container", {}).get("is_app_unfurl"):
-            return int(json.loads(self.data["app_unfurl"]["blocks"][0]["block_id"])["issue"])
-        return int(json.loads(self.data["message"]["blocks"][0]["block_id"])["issue"])
+            return int(
+                json.loads_experimental(
+                    "integrations.slack.enable-orjson",
+                    self.data["app_unfurl"]["blocks"][0]["block_id"],
+                )["issue"]
+            )
+        return int(
+            json.loads_experimental(
+                "integrations.slack.enable-orjson", self.data["message"]["blocks"][0]["block_id"]
+            )["issue"]
+        )
 
     @property
     def substring(self) -> str:
@@ -33,7 +42,9 @@ def _validate_data(self) -> None:
             raise SlackRequestError(status=status.HTTP_400_BAD_REQUEST)
 
         try:
-            self._data = json.loads(self.data["payload"])
+            self._data = json.loads_experimental(
+                "integrations.slack.enable-orjson", self.data["payload"]
+            )
         except (KeyError, IndexError, TypeError, ValueError):
             raise SlackRequestError(status=status.HTTP_400_BAD_REQUEST)
 

src/sentry/integrations/slack/service.py

@@ -201,7 +201,9 @@ def _handle_parent_notification(
         )
         payload.update(slack_payload)
         # TODO (Yash): Users should not have to remember to do this, interface should handle serializing the field
-        payload["blocks"] = json.dumps(payload.get("blocks"))
+        payload["blocks"] = json.dumps_experimental(
+            "integrations.slack.enable-orjson", payload.get("blocks")
+        )
         try:
             client.post("/chat.postMessage", data=payload, timeout=5)
         except Exception as err:

src/sentry/integrations/slack/utils/notifications.py

@@ -63,7 +63,7 @@ def send_incident_alert_notification(
     payload = {
         "channel": channel,
         "text": text,
-        "attachments": json.dumps([blocks]),
+        "attachments": json.dumps_experimental("integrations.slack.enable-orjson", [blocks]),
         # Prevent duplicate unfurl
         # https://api.slack.com/reference/messaging/link-unfurling#no_unfurling_please
         "unfurl_links": False,

src/sentry/integrations/slack/utils/rule_status.py

@@ -38,13 +38,15 @@ def set_value(
     def get_value(self) -> JSONData:
         key = self._get_redis_key()
         value = self.client.get(key)
-        return json.loads(cast(Union[str, bytes], value))
+        return json.loads_experimental(
+            "integrations.slack.enable-orjson", cast(Union[str, bytes], value)
+        )
 
     def _generate_uuid(self) -> str:
         return uuid4().hex
 
     def _set_initial_value(self) -> None:
-        value = json.dumps({"status": "pending"})
+        value = json.dumps_experimental("integrations.slack.enable-orjson", {"status": "pending"})
         self.client.set(self._get_redis_key(), f"{value}", ex=60 * 60, nx=True)
 
     def _get_redis_key(self) -> str:
@@ -64,4 +66,4 @@ def _format_value(
         elif status == "failed":
             value["error"] = SLACK_FAILED_MESSAGE
 
-        return json.dumps(value)
+        return json.dumps_experimental("integrations.slack.enable-orjson", value)

src/sentry/integrations/slack/webhooks/action.py

@@ -197,7 +197,9 @@ def api_error(
             if view:
                 private_metadata = view.get("private_metadata")
                 if private_metadata:
-                    data = json.loads(private_metadata)
+                    data = json.loads_experimental(
+                        "integrations.slack.enable-orjson", private_metadata
+                    )
                     channel_id = data.get("channel_id")
                     response_url = data.get("orig_response_url")
 
@@ -398,7 +400,7 @@ def open_resolve_dialog(self, slack_request: SlackActionRequest, group: Group) -
         if use_block_kit and slack_request.data.get("channel"):
             callback_id["channel_id"] = slack_request.data["channel"]["id"]
             callback_id["rule"] = slack_request.callback_data.get("rule")
-        callback_id = json.dumps(callback_id)
+        callback_id = json.dumps_experimental("integrations.slack.enable-orjson", callback_id)
 
         dialog = {
             "callback_id": callback_id,
@@ -408,7 +410,7 @@ def open_resolve_dialog(self, slack_request: SlackActionRequest, group: Group) -
         }
 
         payload = {
-            "dialog": json.dumps(dialog),
+            "dialog": json.dumps_experimental("integrations.slack.enable-orjson", dialog),
             "trigger_id": slack_request.data["trigger_id"],
         }
         slack_client = SlackClient(integration_id=slack_request.integration.id)
@@ -418,11 +420,17 @@ def open_resolve_dialog(self, slack_request: SlackActionRequest, group: Group) -
             modal_payload = self.build_resolve_modal_payload(callback_id)
             try:
                 payload = {
-                    "view": json.dumps(modal_payload),
+                    "view": json.dumps_experimental(
+                        "integrations.slack.enable-orjson", modal_payload
+                    ),
                     "trigger_id": slack_request.data["trigger_id"],
                 }
                 headers = {"content-type": "application/json; charset=utf-8"}
-                slack_client.post("/views.open", data=json.dumps(payload), headers=headers)
+                slack_client.post(
+                    "/views.open",
+                    data=json.dumps_experimental("integrations.slack.enable-orjson", payload),
+                    headers=headers,
+                )
             except ApiError as e:
                 logger.exception(
                     "slack.action.response-error",
@@ -460,17 +468,21 @@ def open_archive_dialog(self, slack_request: SlackActionRequest, group: Group) -
 
         if slack_request.data.get("channel"):
             callback_id["channel_id"] = slack_request.data["channel"]["id"]
-        callback_id = json.dumps(callback_id)
+        callback_id = json.dumps_experimental("integrations.slack.enable-orjson", callback_id)
 
         slack_client = SlackClient(integration_id=slack_request.integration.id)
         modal_payload = self.build_archive_modal_payload(callback_id)
         try:
             payload = {
-                "view": json.dumps(modal_payload),
+                "view": json.dumps_experimental("integrations.slack.enable-orjson", modal_payload),
                 "trigger_id": slack_request.data["trigger_id"],
             }
             headers = {"content-type": "application/json; charset=utf-8"}
-            slack_client.post("/views.open", data=json.dumps(payload), headers=headers)
+            slack_client.post(
+                "/views.open",
+                data=json.dumps_experimental("integrations.slack.enable-orjson", payload),
+                headers=headers,
+            )
         except ApiError as e:
             logger.exception(
                 "slack.action.response-error",
@@ -571,7 +583,10 @@ def _handle_group_actions(
             # use the original response_url to update the link attachment
             slack_client = SlackClient(integration_id=slack_request.integration.id)
             try:
-                private_metadata = json.loads(slack_request.data["view"]["private_metadata"])
+                private_metadata = json.loads_experimental(
+                    "integrations.slack.enable-orjson",
+                    slack_request.data["view"]["private_metadata"],
+                )
                 slack_client.post(private_metadata["orig_response_url"], data=body, json=True)
             except ApiError as e:
                 logger.error("slack.action.response-error", extra={"error": str(e)})

src/sentry/integrations/slack/webhooks/event.py

@@ -156,7 +156,9 @@ def on_link_shared(self, request: Request, slack_request: SlackDMRequest) -> boo
                 return True
 
             # Don't unfurl the same thing multiple times
-            seen_marker = hash(json.dumps((link_type, args)))
+            seen_marker = hash(
+                json.dumps_experimental("integrations.slack.enable-orjson", (link_type, args))
+            )
             if seen_marker in links_seen:
                 continue
 
@@ -192,7 +194,7 @@ def on_link_shared(self, request: Request, slack_request: SlackDMRequest) -> boo
         payload = {
             "channel": data["channel"],
             "ts": data["message_ts"],
-            "unfurls": json.dumps(results),
+            "unfurls": json.dumps_experimental("integrations.slack.enable-orjson", results),
         }
 
         client = SlackClient(integration_id=slack_request.integration.id)

src/sentry/integrations/slack/webhooks/options_load.py

@@ -99,7 +99,9 @@ def post(self, request: Request) -> Response:
                 extra={
                     "group_id": group.id if group else None,
                     "organization_id": group.project.organization.id if group else None,
-                    "request_data": json.dumps(slack_request.data),
+                    "request_data": json.dumps_experimental(
+                        "integrations.slack.enable-orjson", slack_request.data
+                    ),
                 },
             )
             return self.respond(status=status.HTTP_400_BAD_REQUEST)

src/sentry/options/defaults.py

@@ -637,6 +637,7 @@
 )
 
 register("snuba.snql.enable-orjson", default=0.0, flags=FLAG_AUTOMATOR_MODIFIABLE)
+register("integrations.slack.enable-orjson", default=0.0, flags=FLAG_AUTOMATOR_MODIFIABLE)
 
 # Kafka Publisher
 register("kafka-publisher.raw-event-sample-rate", default=0.0, flags=FLAG_AUTOMATOR_MODIFIABLE)