Release threshold folder imports nit (#56400)

Cleans up release threshold model imports & adds related name to the
relase_threshold table for projects

Author: nhsiehgit

fixtures/backup/model_dependencies/sorted.json

@@ -167,7 +167,6 @@
   "sentry.PullRequest",
   "sentry.PullRequestCommit",
   "sentry.PullRequestComment",
-  "sentry.ReleaseThreshold",
   "sentry.ReleaseActivity",
   "sentry.ReleaseCommit",
   "sentry.ReleaseEnvironment",
@@ -189,6 +188,7 @@
   "sentry.AlertRuleActivity",
   "sentry.TeamKeyTransaction",
   "sentry.MonitorEnvironment",
+  "sentry.ReleaseThreshold",
   "sentry.MonitorCheckIn",
   "sentry.AlertRuleExcludedProjects",
   "sentry.Incident",

src/sentry/api/endpoints/release_threshold.py

@@ -18,7 +18,7 @@
     ReleaseThresholdType,
     TriggerType,
 )
-from sentry.models.release_threshold.releasethreshold import ReleaseThreshold
+from sentry.models.release_threshold.release_threshold import ReleaseThreshold
 
 
 class ReleaseThresholdPOSTSerializer(serializers.Serializer):

src/sentry/api/endpoints/release_threshold_details.py

@@ -11,7 +11,7 @@
 from sentry.api.exceptions import ResourceDoesNotExist
 from sentry.api.serializers import serialize
 from sentry.models.project import Project
-from sentry.models.release_threshold.releasethreshold import ReleaseThreshold
+from sentry.models.release_threshold.release_threshold import ReleaseThreshold
 
 
 @region_silo_endpoint

src/sentry/api/serializers/models/release_threshold.py

@@ -3,7 +3,7 @@
     THRESHOLD_TYPE_INT_TO_STR,
     TRIGGER_TYPE_INT_TO_STR,
 )
-from sentry.models.release_threshold.releasethreshold import ReleaseThreshold
+from sentry.models.release_threshold.release_threshold import ReleaseThreshold
 
 
 @register(ReleaseThreshold)

src/sentry/models/__init__.py

@@ -93,8 +93,6 @@
 from .recentsearch import *  # NOQA
 from .relay import *  # NOQA
 from .release import *  # NOQA
-from .release_threshold.constants import *  # NOQA
-from .release_threshold.releasethreshold import *  # NOQA
 from .releaseactivity import *  # NOQA
 from .releasecommit import *  # NOQA
 from .releaseenvironment import *  # NOQA

src/sentry/models/release_threshold/constants.py

@@ -52,7 +52,7 @@ class TriggerType:
     ABSOLUTE_UNDER_STR = "absolute_under"
 
     @classmethod
-    def as_choices(cls):
+    def as_choices(cls):  # choices for model column
         return (
             (cls.PERCENT_OVER_STR, cls.PERCENT_OVER),
             (cls.PERCENT_UNDER_STR, cls.PERCENT_UNDER),
@@ -61,7 +61,7 @@ def as_choices(cls):
         )
 
     @classmethod
-    def as_str_choices(cls):
+    def as_str_choices(cls):  # choices for serializer
         return (
             (cls.PERCENT_OVER_STR, cls.PERCENT_OVER_STR),
             (cls.PERCENT_UNDER_STR, cls.PERCENT_UNDER_STR),
@@ -72,7 +72,7 @@ def as_str_choices(cls):
 
 THRESHOLD_TYPE_INT_TO_STR = {
     ReleaseThresholdType.TOTAL_ERROR_COUNT: ReleaseThresholdType.TOTAL_ERROR_COUNT_STR,
-    ReleaseThresholdType.NEW_ISSUE_COUNT_STR: ReleaseThresholdType.NEW_ISSUE_COUNT_STR,
+    ReleaseThresholdType.NEW_ISSUE_COUNT: ReleaseThresholdType.NEW_ISSUE_COUNT_STR,
     ReleaseThresholdType.UNHANDLED_ISSUE_COUNT: ReleaseThresholdType.UNHANDLED_ISSUE_COUNT_STR,
     ReleaseThresholdType.REGRESSED_ISSUE_COUNT: ReleaseThresholdType.REGRESSED_ISSUE_COUNT_STR,
     ReleaseThresholdType.FAILURE_RATE: ReleaseThresholdType.FAILURE_RATE_STR,

src/sentry/models/release_threshold/releasethreshold.py renamed to src/sentry/models/release_threshold/release_threshold.py

@@ -1,7 +1,7 @@
 from django.urls import reverse
 
 from sentry.models.environment import Environment
-from sentry.models.release_threshold.releasethreshold import ReleaseThreshold
+from sentry.models.release_threshold.release_threshold import ReleaseThreshold
 from sentry.testutils.cases import APITestCase
 
 

tests/sentry/api/endpoints/test_release_threshold.py

@@ -1,7 +1,7 @@
 from django.urls import reverse
 
 from sentry.models.environment import Environment
-from sentry.models.release_threshold.releasethreshold import ReleaseThreshold
+from sentry.models.release_threshold.release_threshold import ReleaseThreshold
 from sentry.testutils.cases import APITestCase