ref: fix typing for sentry.plugins.bases.data_forwarding

Author: asottile-sentry

pyproject.toml

@@ -243,7 +243,6 @@ module = [
     "sentry.pipeline.base",
     "sentry.pipeline.views.base",
     "sentry.pipeline.views.nested",
-    "sentry.plugins.bases.data_forwarding",
     "sentry.plugins.bases.notify",
     "sentry.plugins.config",
     "sentry.receivers.releases",

src/sentry/plugins/base/v1.py

@@ -429,7 +429,7 @@ def is_regression(self, group, event, **kwargs):
         >>>     return event_version not in seen_versions
         """
 
-    def post_process(self, group, event, is_new, **kwargs):
+    def post_process(self, *, group, event, is_new, **kwargs) -> None:
         """
         Post processes an event after it has been saved.
 

src/sentry/plugins/bases/data_forwarding.py

@@ -55,7 +55,7 @@ def is_ratelimited(self, event):
             return True
         return False
 
-    def post_process(self, event, **kwargs):
+    def post_process(self, *, event, **kwargs) -> None:
         if self.is_ratelimited(event):
             return
 
@@ -64,4 +64,4 @@ def post_process(self, event, **kwargs):
         if success is False:
             # TODO(dcramer): record failure
             pass
-        tsdb.incr(TSDBModel.project_total_forwarded, event.project.id, count=1)
+        tsdb.backend.incr(TSDBModel.project_total_forwarded, event.project.id, count=1)

src/sentry_plugins/jira/plugin.py

@@ -652,7 +652,7 @@ def should_create(self, group, event, is_new):
 
         return True
 
-    def post_process(self, group, event, is_new, **kwargs):
+    def post_process(self, *, group, event, is_new, **kwargs):
         if not self.should_create(group, event, is_new):
             return
 

tests/sentry_plugins/amazon_sqs/test_plugin.py

@@ -39,7 +39,7 @@ def run_test(self):
         )
 
         with self.options({"system.url-prefix": "http://example.com"}):
-            self.plugin.post_process(event)
+            self.plugin.post_process(event=event)
         return event
 
     @patch("boto3.client")

tests/sentry_plugins/segment/test_plugin.py

@@ -36,7 +36,7 @@ def test_simple_notification(self):
         )
 
         with self.options({"system.url-prefix": "http://example.com"}):
-            self.plugin.post_process(event)
+            self.plugin.post_process(event=event)
 
         request = responses.calls[0].request
         payload = orjson.loads(request.body)