Skip to content

Commit 2059ac3

Browse files
committed
stop excluding scores equal to 0
1 parent 1215c25 commit 2059ac3

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

src/sentry/event_manager.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1624,9 +1624,10 @@ def _save_aggregate(
16241624

16251625
group = _create_group(project, event, **kwargs)
16261626

1627-
if features.has(
1628-
"projects:first-event-severity-calculation", event.project
1629-
) and not group.data.get("metadata", {}).get("severity"):
1627+
if (
1628+
features.has("projects:first-event-severity-calculation", event.project)
1629+
and group.data.get("metadata", {}).get("severity") is None
1630+
):
16301631
logger.error(
16311632
"Group created without severity score",
16321633
extra={
@@ -1843,7 +1844,7 @@ def _create_group(project: Project, event: Event, **kwargs: Any) -> Group:
18431844
group_data = kwargs.pop("data", {})
18441845
if features.has("projects:first-event-severity-calculation", event.project):
18451846
severity = _get_severity_score(event)
1846-
if severity:
1847+
if severity is not None: # Severity can be 0
18471848
group_data.setdefault("metadata", {})
18481849
group_data["metadata"]["severity"] = severity
18491850

@@ -2510,9 +2511,10 @@ def _save_grouphash_and_group(
25102511
group = _create_group(project, event, **group_kwargs)
25112512
group_hash.update(group=group)
25122513

2513-
if features.has(
2514-
"projects:first-event-severity-calculation", event.project
2515-
) and not group.data.get("metadata", {}).get("severity"):
2514+
if (
2515+
features.has("projects:first-event-severity-calculation", event.project)
2516+
and group.data.get("metadata", {}).get("severity") is None
2517+
):
25162518
logger.error(
25172519
"Group created without severity score",
25182520
extra={

0 commit comments

Comments
 (0)