add tests

Author: roggenkemper

src/sentry/api/helpers/group_index/update.py

@@ -225,7 +225,6 @@ def update_groups(
         )
         if user_options:
             self_assign_issue = user_options[0].value
-
     if search_fn and not group_ids:
         try:
             cursor_result, _ = search_fn(

src/sentry/api/helpers/group_index/validators/status_details.py

@@ -71,4 +71,4 @@ def validate_inUpcomingRelease(self, value: bool) -> "Release":
                 .order_by("-sort")[0]
             )
         except IndexError:
-            raise serializers.ValidationError("No release data present in the system.'")
+            raise serializers.ValidationError("No release data present in the system.")

tests/sentry/issues/endpoints/test_organization_group_index.py

@@ -4954,6 +4954,22 @@ def test_update_priority_no_change(self) -> None:
             group=group2, type=ActivityType.SET_PRIORITY.value, user_id=self.user.id
         ).exists()
 
+    def test_resolved_in_upcoming_release_multiple_projects(self) -> None:
+        project_2 = self.create_project(slug="foo")
+        group1 = self.create_group(status=GroupStatus.UNRESOLVED)
+        group2 = self.create_group(status=GroupStatus.UNRESOLVED, project=project_2)
+
+        self.login_as(user=self.user)
+        response = self.get_response(
+            qs_params={
+                "id": [group1.id, group2.id],
+                "statd": "resolved",
+                "statusDetails": {"inUpcomingRelease": True},
+            }
+        )
+
+        assert response.status_code == 400
+
 
 class GroupDeleteTest(APITestCase, SnubaTestCase):
     endpoint = "sentry-api-0-organization-group-index"

tests/snuba/api/endpoints/test_project_group_index.py

@@ -830,6 +830,44 @@ def test_set_resolved_in_upcoming_release(self):
         )
         assert activity.data["version"] == ""
 
+    def test_upcoming_release_flag_validation(self):
+        release = Release.objects.create(organization_id=self.project.organization_id, version="a")
+        release.add_project(self.project)
+
+        group = self.create_group(status=GroupStatus.UNRESOLVED)
+
+        self.login_as(user=self.user)
+
+        url = f"{self.path}?id={group.id}"
+        response = self.client.put(
+            url,
+            data={"status": "resolved", "statusDetails": {"inUpcomingRelease": True}},
+            format="json",
+        )
+        assert response.status_code == 400
+        assert (
+            response.data["statusDetails"]["inUpcomingRelease"][0]
+            == "Your organization does not have access to this feature."
+        )
+
+    @with_feature("organizations:resolve-in-upcoming-release")
+    def test_upcoming_release_release_validation(self):
+        group = self.create_group(status=GroupStatus.UNRESOLVED)
+
+        self.login_as(user=self.user)
+
+        url = f"{self.path}?id={group.id}"
+        response = self.client.put(
+            url,
+            data={"status": "resolved", "statusDetails": {"inUpcomingRelease": True}},
+            format="json",
+        )
+        assert response.status_code == 400
+        assert (
+            response.data["statusDetails"]["inUpcomingRelease"][0]
+            == "No release data present in the system."
+        )
+
     def test_set_resolved_in_explicit_commit_unreleased(self):
         repo = self.create_repo(project=self.project, name=self.project.name)
         commit = self.create_commit(project=self.project, repo=repo)