Skip to content

Commit 251ed66

Browse files
billyvgbillyvg
authored
feat(replay): Upgrade rrweb packages to v2 (#56088)
This upgrades our rrweb packages to v2, this will affect the player. It should be backwards compatible with old SDK versions
1 parent 69cc8ff commit 251ed66

File tree

4 files changed

+51
-28
lines changed

4 files changed

+51
-28
lines changed

Diff for: ‎package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,9 @@
4848
"@react-types/shared": "^3.18.1",
4949
"@sentry-internal/global-search": "^0.5.7",
5050
"@sentry-internal/react-inspector": "6.0.1-4",
51-
"@sentry-internal/rrweb": "1.108.0",
52-
"@sentry-internal/rrweb-player": "1.108.0",
51+
"@sentry-internal/rrweb": "2.0.0-beta11.0",
52+
"@sentry-internal/rrweb-player": "2.0.0-beta11.0",
53+
"@sentry-internal/rrweb-snapshot": "2.0.0-beta11.0",
5354
"@sentry/integrations": "7.70.0-beta.1",
5455
"@sentry/node": "7.70.0-beta.1",
5556
"@sentry/react": "7.70.0-beta.1",

Diff for: ‎static/app/utils/replays/extractDomNodes.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import type {Mirror} from '@sentry-internal/rrweb';
21
import {Replayer} from '@sentry-internal/rrweb';
2+
import type {Mirror} from '@sentry-internal/rrweb-snapshot';
33

44
import type {RecordingFrame, ReplayFrame} from 'sentry/utils/replays/types';
55

Diff for: ‎static/app/utils/replays/highlightNode.tsx

+7-1
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,14 @@ export function highlightNode(replayer: Replayer, props: AddHighlightParams) {
8282
// want on top of the replay. We may need to revisit this strategy as we
8383
// create a new canvas for every highlight. See additional notes in
8484
// removeHighlight() method.
85+
const element = node.nodeType === Node.ELEMENT_NODE ? (node as HTMLElement) : null;
86+
87+
if (!element) {
88+
return null;
89+
}
90+
8591
const canvas = mouseTail.cloneNode();
86-
const boundingClientRect = node.getBoundingClientRect();
92+
const boundingClientRect = element.getBoundingClientRect();
8793
const drawProps = {
8894
annotation: props.annotation ?? '',
8995
color: props.color ?? DEFAULT_HIGHLIGHT_COLOR,

Diff for: ‎yarn.lock

+40-24
Original file line numberDiff line numberDiff line change
@@ -2379,30 +2379,46 @@
23792379
resolved "https://registry.yarnpkg.com/@sentry-internal/react-inspector/-/react-inspector-6.0.1-4.tgz#10758f3461cf2cf48df8c80f0514c55ca18872c5"
23802380
integrity sha512-uL2RyvW8EqDEchnbo8Hu/c4IpBqM3LLxUpZPHs8o40kynerzPset6bC/m5SU124gEhy4PqjdvJ7DhTYR75NetQ==
23812381

2382-
"@sentry-internal/[email protected].0":
2383-
version "1.108.0"
2384-
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-player/-/rrweb-player-1.108.0.tgz#52ccb6f8adc65f0032136a43d02439c43dbbdde6"
2385-
integrity sha512-KYu75z493qhg8Km9BsjlkA1rr6qx+vF5YHVSMF4e9udsFcYezK3SMp+IFuMVugN/s0uuKIx+FZuVppq18zIyTg==
2382+
"@sentry-internal/[email protected].0":
2383+
version "2.0.0-beta11.0"
2384+
resolved "https://registry.yarnpkg.com/@sentry-internal/rrdom/-/rrdom-2.0.0-beta11.0.tgz#83110a5db9434383eba3c7506aaa6a5f8b32ea78"
2385+
integrity sha512-6yL23XeauKi4FtRewFnX5SL22HOVirwgCj9VYb31It8kVaE+aFWxcMo8bkkgxO9orokox2iW4fjr+zsuvGkTgg==
23862386
dependencies:
2387-
"@sentry-internal/rrweb" "1.108.0"
2388-
"@tsconfig/svelte" "^3.0.0"
2387+
"@sentry-internal/rrweb-snapshot" "2.0.0-beta11.0"
23892388

2390-
"@sentry-internal/[email protected]":
2391-
version "1.108.0"
2392-
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-snapshot/-/rrweb-snapshot-1.108.0.tgz#9b09b7e5d6b13d4d7493017ee190b097f9916284"
2393-
integrity sha512-ypR/4oBB8s7d5+7JTkdk+VvlMPRRhbuz3xSFMXShCH2LJ6kINGfYBAYr6rr6o2Bko9j5rVHjYDDrVWkTw4CXSg==
2389+
"@sentry-internal/[email protected]":
2390+
version "2.0.0-beta11.0"
2391+
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-player/-/rrweb-player-2.0.0-beta11.0.tgz#518f8003ae398c7694148b12da30d9f37b4cafb0"
2392+
integrity sha512-/uPw1jP8Dkqwz8QsmaY4xQcIJH/ukFt60h1CUtQjJ8Cf3uvcdyvmYPMCGksU6azDVAOG8hy/ElvJQDxFM5Pj+g==
2393+
dependencies:
2394+
"@sentry-internal/rrweb" "2.0.0-beta11.0"
2395+
"@tsconfig/svelte" "^1.0.0"
2396+
2397+
"@sentry-internal/[email protected]":
2398+
version "2.0.0-beta11.0"
2399+
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-snapshot/-/rrweb-snapshot-2.0.0-beta11.0.tgz#54a5f54a0b5ae66927ef77d21be6750bceac692a"
2400+
integrity sha512-IF0NuVja+f5PrRYy5xwMZlv3gNmm46ODti3ECLuuxqZ0n93DKnicZ/Bc03sHpne2cVla+6x0+lGk6eHX4fqauw==
2401+
2402+
"@sentry-internal/[email protected]":
2403+
version "2.0.0-beta11.0"
2404+
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-types/-/rrweb-types-2.0.0-beta11.0.tgz#12ebea406a2813deab534b35ccc7a7081466ec21"
2405+
integrity sha512-LzaVyUOnd1SDMVeO9Mo8KndHIAMxBNPn972/rx+pB4lxOWUQiV627ymu9uUZR5XzvBUDmtpeEQalBsoFHJDDJQ==
2406+
dependencies:
2407+
"@sentry-internal/rrweb-snapshot" "2.0.0-beta11.0"
23942408

2395-
"@sentry-internal/rrweb@1.108.0":
2396-
version "1.108.0"
2397-
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb/-/rrweb-1.108.0.tgz#4b724c1fff44fb4705723c121ca424c00fabc398"
2398-
integrity sha512-IuRuA1k2N23e6oTRnV9866mauoOvesYFZFlQHgOvt7p3pJDfXhDUZj1DKaQZJrbooTUUIh7YrpZ2Vukoq0wCFw==
2409+
"@sentry-internal/rrweb@2.0.0-beta11.0":
2410+
version "2.0.0-beta11.0"
2411+
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb/-/rrweb-2.0.0-beta11.0.tgz#9bcc760bd8b494ea87eea9ead54226146d8c27c6"
2412+
integrity sha512-9nLYk2ks+cdAKRQNycKhypPHMcF2f/N+yrcaqLVESotEbOgiJlH5CbNjW7XHNTXw6rWLkFtulBveghC4vSInlg==
23992413
dependencies:
2400-
"@sentry-internal/rrweb-snapshot" "1.108.0"
2414+
"@sentry-internal/rrdom" "2.0.0-beta11.0"
2415+
"@sentry-internal/rrweb-snapshot" "2.0.0-beta11.0"
2416+
"@sentry-internal/rrweb-types" "2.0.0-beta11.0"
24012417
"@types/css-font-loading-module" "0.0.7"
24022418
"@xstate/fsm" "^1.4.0"
24032419
base64-arraybuffer "^1.0.1"
24042420
fflate "^0.4.4"
2405-
mitt "^1.1.3"
2421+
mitt "^3.0.0"
24062422

24072423
"@sentry-internal/[email protected]":
24082424
version "7.66.0"
@@ -2709,10 +2725,10 @@
27092725
resolved "https://registry.yarnpkg.com/@tsconfig/node16/-/node16-1.0.2.tgz#423c77877d0569db20e1fc80885ac4118314010e"
27102726
integrity sha512-eZxlbI8GZscaGS7kkc/trHTT5xgrjH3/1n2JDwusC9iahPKWMRvRjJSAN5mCXviuTGQ/lHnhvv8Q1YTpnfz9gA==
27112727

2712-
"@tsconfig/svelte@^3.0.0":
2713-
version "3.0.0"
2714-
resolved "https://registry.yarnpkg.com/@tsconfig/svelte/-/svelte-3.0.0.tgz#b06e059209f04c414de0069f2f0e2796d979fc6f"
2715-
integrity sha512-pYrtLtOwku/7r1i9AMONsJMVYAtk3hzOfiGNekhtq5tYBGA7unMve8RvUclKLMT3PrihvJqUmzsRGh0RP84hKg==
2728+
"@tsconfig/svelte@^1.0.0":
2729+
version "1.0.13"
2730+
resolved "https://registry.yarnpkg.com/@tsconfig/svelte/-/svelte-1.0.13.tgz#2fa34376627192c0d643ce54964915e2bd3a58e4"
2731+
integrity sha512-5lYJP45Xllo4yE/RUBccBT32eBlRDbqN8r1/MIvQbKxW3aFqaYPCNgm8D5V20X4ShHcwvYWNlKg3liDh1MlBoA==
27162732

27172733
"@types/aria-query@^4.2.0":
27182734
version "4.2.1"
@@ -8424,10 +8440,10 @@ minizlib@^2.1.1, minizlib@^2.1.2:
84248440
minipass "^3.0.0"
84258441
yallist "^4.0.0"
84268442

8427-
mitt@^1.1.3:
8428-
version "1.2.0"
8429-
resolved "https://registry.yarnpkg.com/mitt/-/mitt-1.2.0.tgz#cb24e6569c806e31bd4e3995787fe38a04fdf90d"
8430-
integrity sha512-r6lj77KlwqLhIUku9UWYes7KJtsczvolZkzp8hbaDPPaE24OmWl5s539Mytlj22siEQKosZ26qCBgda2PKwoJw==
8443+
mitt@^3.0.0:
8444+
version "3.0.1"
8445+
resolved "https://registry.yarnpkg.com/mitt/-/mitt-3.0.1.tgz#ea36cf0cc30403601ae074c8f77b7092cdab36d1"
8446+
integrity sha512-vKivATfr97l2/QBCYAkXYDbrIWPM2IIKEl7YPhjCvKlG3kE2gm+uBo6nEXK3M5/Ffh/FLpKExzOQ3JJoJGFKBw==
84318447

84328448
mkdirp@^1.0.3, mkdirp@^1.0.4:
84338449
version "1.0.4"

0 commit comments

Comments
 (0)