fix(search): Dont create an empty "query" param

This ensures we're not passing an invalid 'query=[]' token to upstream users, which would commonly treat this as 'find something with a blank string' and exclude searches that might have been operating on NULL columns.

Author: dcramer

src/sentry/search/utils.py

@@ -331,7 +331,8 @@ def tokenize_query(query):
                 break
         query_params[state].append(token)
 
-    result["query"] = map(format_query, query_params["query"])
+    if "query" in query_params:
+        result["query"] = map(format_query, query_params["query"])
     for tag in query_params["tags"]:
         key, value = format_tag(tag)
         result[key].append(value)

tests/sentry/search/test_utils.py

@@ -21,6 +21,7 @@
     get_latest_release,
     get_numeric_field_value,
     convert_user_tag_to_query,
+    tokenize_query,
     InvalidQuery,
 )
 
@@ -47,6 +48,10 @@ def test_get_numeric_field_value():
     }
 
 
+def test_tokenize_query_only_keyed_fields():
+    assert tokenize_query("foo:bar") == {"foo": ["bar"]}
+
+
 def test_get_numeric_field_value_invalid():
     with pytest.raises(InvalidQuery):
         get_numeric_field_value("foo", ">=1k")