Skip to content

Commit 2b60ac5

Browse files
committed
feat(taskworker) Add metrics for RPC durations
We'll need to know RPC latency from both the broker and worker perspectives
1 parent 7909e90 commit 2b60ac5

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

Diff for: src/sentry/taskworker/client.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
)
1313
from sentry_protos.taskbroker.v1.taskbroker_pb2_grpc import ConsumerServiceStub
1414

15-
from sentry import options
15+
from sentry import metrics, options
1616

1717
logger = logging.getLogger("sentry.taskworker.client")
1818

@@ -57,7 +57,8 @@ def get_task(self, namespace: str | None = None) -> TaskActivation | None:
5757
"""
5858
request = GetTaskRequest(namespace=namespace)
5959
try:
60-
response = self._stub.GetTask(request)
60+
with metrics.timer("taskworker.get_task.rpc"):
61+
response = self._stub.GetTask(request)
6162
except grpc.RpcError as err:
6263
if err.code() == grpc.StatusCode.NOT_FOUND:
6364
return None
@@ -83,7 +84,8 @@ def update_task(
8384
fetch_next_task=fetch_next_task,
8485
)
8586
try:
86-
response = self._stub.SetTaskStatus(request)
87+
with metrics.timer("taskworker.update_task.rpc"):
88+
response = self._stub.SetTaskStatus(request)
8789
except grpc.RpcError as err:
8890
if err.code() == grpc.StatusCode.NOT_FOUND:
8991
return None

0 commit comments

Comments
 (0)