feat(feedback): set feedback issue to ignored if spam

Author: JoshFerge

src/sentry/feedback/usecases/create_feedback.py

@@ -16,6 +16,8 @@
 from sentry.issues.issue_occurrence import IssueEvidence, IssueOccurrence
 from sentry.issues.json_schemas import EVENT_PAYLOAD_SCHEMA, LEGACY_EVENT_PAYLOAD_SCHEMA
 from sentry.issues.producer import PayloadType, produce_occurrence_to_kafka
+from sentry.issues.status_change_message import StatusChangeMessage
+from sentry.models.group import GroupStatus
 from sentry.models.project import Project
 from sentry.signals import first_feedback_received, first_new_feedback_received
 from sentry.utils import metrics
@@ -194,13 +196,12 @@ def create_feedback_issue(event, project_id, source: FeedbackCreationSource):
     evidence_data, evidence_display = make_evidence(
         event["contexts"]["feedback"], source, is_message_spam
     )
+    issue_fingerprint = [uuid4().hex]
     occurrence = IssueOccurrence(
         id=uuid4().hex,
         event_id=event.get("event_id") or uuid4().hex,
         project_id=project_id,
-        fingerprint=[
-            uuid4().hex
-        ],  # random UUID for fingerprint so feedbacks are grouped individually
+        fingerprint=issue_fingerprint,  # random UUID for fingerprint so feedbacks are grouped individually
         issue_title="User Feedback",
         subtitle=event["contexts"]["feedback"]["message"],
         resource_id=None,
@@ -240,6 +241,16 @@ def create_feedback_issue(event, project_id, source: FeedbackCreationSource):
     produce_occurrence_to_kafka(
         payload_type=PayloadType.OCCURRENCE, occurrence=occurrence, event_data=event_fixed
     )
+    if is_message_spam:
+        produce_occurrence_to_kafka(
+            payload_type=PayloadType.STATUS_CHANGE,
+            status_change=StatusChangeMessage(
+                fingerprint=issue_fingerprint,
+                project_id=project_id,
+                new_status=GroupStatus.RESOLVED,
+                new_substatus=None,
+            ),
+        )
     metrics.incr(
         "feedback.create_feedback_issue.produced_occurrence",
         tags={"referrer": source.value},

tests/sentry/feedback/usecases/test_create_feedback.py

@@ -14,6 +14,7 @@
     fix_for_issue_platform,
     validate_issue_platform_event_schema,
 )
+from sentry.models.group import GroupStatus
 from sentry.testutils.helpers import Feature
 from sentry.testutils.pytest.fixtures import django_db_all
 
@@ -528,12 +529,22 @@ def dummy_response(*args, **kwargs):
         # Check if the 'is_spam' evidence in the Kafka message matches the expected result
         is_spam_evidence = [
             evidence.value
-            for evidence in mock_produce_occurrence_to_kafka.call_args.kwargs[
-                "occurrence"
-            ].evidence_display
+            for evidence in mock_produce_occurrence_to_kafka.call_args_list[0]
+            .kwargs["occurrence"]
+            .evidence_display
             if evidence.name == "is_spam"
         ]
         found_is_spam = is_spam_evidence[0] if is_spam_evidence else None
         assert (
             found_is_spam == expected_result
         ), f"Expected {expected_result} but found {found_is_spam} for {input_message} and feature flag {feature_flag}"
+
+        if expected_result and feature_flag:
+            assert (
+                mock_produce_occurrence_to_kafka.call_args_list[1]
+                .kwargs["status_change"]
+                .new_status
+                == GroupStatus.RESOLVED
+            )
+        if not (expected_result and feature_flag):
+            assert mock_produce_occurrence_to_kafka.call_count == 1