Skip to content

Commit 328b925

Browse files
author
Stephen Cefali
authored
logging(vsts): update logging for secret verification for vsts (#18486)
1 parent 8c2b8ca commit 328b925

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

src/sentry/integrations/vsts/webhooks.py

+5-13
Original file line numberDiff line numberDiff line change
@@ -75,23 +75,15 @@ def check_webhook_secret(self, request, integration):
7575
try:
7676
integration_secret = integration.metadata["subscription"]["secret"]
7777
webhook_payload_secret = request.META["HTTP_SHARED_SECRET"]
78+
# TODO(Steve): remove
7879
logger.info(
79-
"vsts.simple-webhook-check",
80+
"vsts.special-webhook-secret",
8081
extra={
81-
"equality1": integration_secret == webhook_payload_secret,
82-
"equality2": constant_time_compare(integration_secret, webhook_payload_secret),
82+
"integration_id": integration.id,
83+
"integration_secret": six.text_type(integration_secret)[:6],
84+
"webhook_payload_secret": six.text_type(webhook_payload_secret)[:6],
8385
},
8486
)
85-
# TODO(Steve): remove
86-
# I don't want to put the webhook secret in logs except for my own integration I don't care about :)
87-
if integration.id == 58554:
88-
logger.info(
89-
"vst.special-webhook-sercret",
90-
extra={
91-
"integration_secret": six.text_type(integration_secret),
92-
"webhook_payload_secret": six.text_type(webhook_payload_secret),
93-
},
94-
)
9587
except KeyError as e:
9688
logger.info(
9789
"vsts.missing-webhook-secret",

0 commit comments

Comments
 (0)