Skip to content

Commit 3888eac

Browse files
authored
chore(widget-builder): Remove organization props (#81248)
These aren't necessary since we can just use hooks and get the org.
1 parent 5b70513 commit 3888eac

File tree

14 files changed

+25
-59
lines changed

14 files changed

+25
-59
lines changed

static/app/views/dashboards/datasetConfig/base.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ export type WidgetBuilderSearchBarProps = {
3333
getFilterWarning: SearchBarProps['getFilterWarning'];
3434
onClose: SearchBarProps['onClose'];
3535
onSearch: SearchBarProps['onSearch'];
36-
organization: Organization;
3736
pageFilters: PageFilters;
3837
widgetQuery: WidgetQuery;
3938
dataset?: DiscoverDatasets;

static/app/views/dashboards/widgetBuilder/buildSteps/columnsStep/index.tsx

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import ExternalLink from 'sentry/components/links/externalLink';
22
import {t, tct} from 'sentry/locale';
33
import type {TagCollection} from 'sentry/types/group';
4-
import type {Organization} from 'sentry/types/organization';
54
import type {QueryFieldValue} from 'sentry/utils/discover/fields';
65
import useCustomMeasurements from 'sentry/utils/useCustomMeasurements';
6+
import useOrganization from 'sentry/utils/useOrganization';
77
import {getDatasetConfig} from 'sentry/views/dashboards/datasetConfig/base';
88
import type {DisplayType, WidgetQuery, WidgetType} from 'sentry/views/dashboards/types';
99
import {hasDatasetSelector} from 'sentry/views/dashboards/utils';
@@ -20,7 +20,6 @@ interface Props {
2020
handleColumnFieldChange: (newFields: QueryFieldValue[]) => void;
2121
isOnDemandWidget: boolean;
2222
onQueryChange: (queryIndex: number, newQuery: WidgetQuery) => void;
23-
organization: Organization;
2423
tags: TagCollection;
2524
widgetType: WidgetType;
2625
queryErrors?: Record<string, any>[];
@@ -29,14 +28,14 @@ interface Props {
2928
export function ColumnsStep({
3029
dataSet,
3130
displayType,
32-
organization,
3331
widgetType,
3432
handleColumnFieldChange,
3533
queryErrors,
3634
explodedFields,
3735
tags,
3836
isOnDemandWidget,
3937
}: Props) {
38+
const organization = useOrganization();
4039
const {customMeasurements} = useCustomMeasurements();
4140
const datasetConfig = getDatasetConfig(widgetType);
4241

static/app/views/dashboards/widgetBuilder/buildSteps/filterResultsStep/eventsSearchBar.tsx

+3-9
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,22 @@
11
import type {SearchBarProps} from 'sentry/components/events/searchBar';
22
import type {PageFilters} from 'sentry/types/core';
3-
import type {Organization} from 'sentry/types/organization';
43
import {generateAggregateFields} from 'sentry/utils/discover/fields';
54
import type {DiscoverDatasets} from 'sentry/utils/discover/types';
65
import useCustomMeasurements from 'sentry/utils/useCustomMeasurements';
6+
import useOrganization from 'sentry/utils/useOrganization';
77
import type {WidgetQuery} from 'sentry/views/dashboards/types';
88
import {eventViewFromWidget, hasDatasetSelector} from 'sentry/views/dashboards/utils';
99
import ResultsSearchQueryBuilder from 'sentry/views/discover/resultsSearchQueryBuilder';
1010

1111
interface Props {
1212
onClose: SearchBarProps['onClose'];
13-
organization: Organization;
1413
pageFilters: PageFilters;
1514
widgetQuery: WidgetQuery;
1615
dataset?: DiscoverDatasets;
1716
}
1817

19-
export function EventsSearchBar({
20-
organization,
21-
pageFilters,
22-
onClose,
23-
widgetQuery,
24-
dataset,
25-
}: Props) {
18+
export function EventsSearchBar({pageFilters, onClose, widgetQuery, dataset}: Props) {
19+
const organization = useOrganization();
2620
const {customMeasurements} = useCustomMeasurements();
2721
const eventView = eventViewFromWidget('', widgetQuery, pageFilters);
2822
const fields = eventView.hasAggregateField()

static/app/views/dashboards/widgetBuilder/buildSteps/filterResultsStep/index.tsx

+1-4
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import {IconAdd, IconDelete} from 'sentry/icons';
1414
import {t, tct} from 'sentry/locale';
1515
import {space} from 'sentry/styles/space';
1616
import type {PageFilters} from 'sentry/types/core';
17-
import type {Organization} from 'sentry/types/organization';
1817
import {
1918
createOnDemandFilterWarning,
2019
isOnDemandQueryString,
@@ -48,7 +47,6 @@ interface Props {
4847
onQueryChange: (queryIndex: number, newQuery: WidgetQuery) => void;
4948
onQueryConditionChange: (isQueryConditionValid: boolean) => void;
5049
onQueryRemove: (queryIndex: number) => void;
51-
organization: Organization;
5250
queries: WidgetQuery[];
5351
selection: PageFilters;
5452
validatedWidgetResponse: UseApiQueryResult<ValidateWidgetResponse, RequestError>;
@@ -66,14 +64,14 @@ export function FilterResultsStep({
6664
onQueryRemove,
6765
onAddSearchConditions,
6866
onQueryChange,
69-
organization,
7067
hideLegendAlias,
7168
queryErrors,
7269
widgetType,
7370
selection,
7471
onQueryConditionChange,
7572
validatedWidgetResponse,
7673
}: Props) {
74+
const organization = useOrganization();
7775
const [queryConditionValidity, setQueryConditionValidity] = useState<boolean[]>([]);
7876

7977
const handleSearch = useCallback(
@@ -174,7 +172,6 @@ export function FilterResultsStep({
174172
? getOnDemandFilterWarning
175173
: undefined
176174
}
177-
organization={organization}
178175
pageFilters={selection}
179176
onClose={handleClose(queryIndex)}
180177
onSearch={handleSearch(queryIndex)}

static/app/views/dashboards/widgetBuilder/buildSteps/filterResultsStep/issuesSearchBar.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@ import styled from '@emotion/styled';
44
import type {SearchBarProps} from 'sentry/components/events/searchBar';
55
import type {SearchQueryBuilderProps} from 'sentry/components/searchQueryBuilder';
66
import {t} from 'sentry/locale';
7-
import type {Organization} from 'sentry/types/organization';
7+
import useOrganization from 'sentry/utils/useOrganization';
88
import type {WidgetQuery} from 'sentry/views/dashboards/types';
99
import IssueListSearchBar from 'sentry/views/issueList/searchBar';
1010

1111
interface Props {
1212
onClose: SearchBarProps['onClose'];
13-
organization: Organization;
1413
widgetQuery: WidgetQuery;
1514
}
1615

17-
function IssuesSearchBar({onClose, widgetQuery, organization}: Props) {
16+
function IssuesSearchBar({onClose, widgetQuery}: Props) {
17+
const organization = useOrganization();
1818
const onChange = useCallback<NonNullable<SearchQueryBuilderProps['onChange']>>(
1919
(query, state) => {
2020
onClose?.(query, {validSearch: state.queryIsValid});

static/app/views/dashboards/widgetBuilder/buildSteps/filterResultsStep/releaseSearchBar.tsx

+3-8
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import {t} from 'sentry/locale';
77
import type {PageFilters} from 'sentry/types/core';
88
import type {Tag, TagValue} from 'sentry/types/group';
99
import {SavedSearchType} from 'sentry/types/group';
10-
import type {Organization} from 'sentry/types/organization';
1110
import useApi from 'sentry/utils/useApi';
11+
import useOrganization from 'sentry/utils/useOrganization';
1212
import type {WidgetQuery} from 'sentry/views/dashboards/types';
1313

1414
import {SESSION_STATUSES, SESSIONS_FILTER_TAGS} from '../../releaseWidget/fields';
@@ -31,17 +31,12 @@ const invalidMessages = {
3131

3232
interface Props {
3333
onClose: SearchBarProps['onClose'];
34-
organization: Organization;
3534
pageFilters: PageFilters;
3635
widgetQuery: WidgetQuery;
3736
}
3837

39-
export function ReleaseSearchBar({
40-
organization,
41-
pageFilters,
42-
widgetQuery,
43-
onClose,
44-
}: Props) {
38+
export function ReleaseSearchBar({pageFilters, widgetQuery, onClose}: Props) {
39+
const organization = useOrganization();
4540
const orgSlug = organization.slug;
4641
const projectIds = pageFilters.projects;
4742

static/app/views/dashboards/widgetBuilder/buildSteps/groupByStep/index.tsx

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import {t} from 'sentry/locale';
22
import type {TagCollection} from 'sentry/types/group';
3-
import type {Organization} from 'sentry/types/organization';
43
import type {QueryFieldValue} from 'sentry/utils/discover/fields';
54
import type {UseApiQueryResult} from 'sentry/utils/queryClient';
65
import type RequestError from 'sentry/utils/requestError/requestError';
6+
import useOrganization from 'sentry/utils/useOrganization';
77
import {getDatasetConfig} from 'sentry/views/dashboards/datasetConfig/base';
88
import type {ValidateWidgetResponse} from 'sentry/views/dashboards/types';
99

@@ -17,7 +17,6 @@ interface Props {
1717
columns: QueryFieldValue[];
1818
dataSet: DataSet;
1919
onGroupByChange: (newFields: QueryFieldValue[]) => void;
20-
organization: Organization;
2120
tags: TagCollection;
2221
validatedWidgetResponse: UseApiQueryResult<ValidateWidgetResponse, RequestError>;
2322
}
@@ -26,10 +25,10 @@ export function GroupByStep({
2625
dataSet,
2726
columns,
2827
onGroupByChange,
29-
organization,
3028
tags,
3129
validatedWidgetResponse,
3230
}: Props) {
31+
const organization = useOrganization();
3332
const datasetConfig = getDatasetConfig(DATA_SET_TO_WIDGET_TYPE[dataSet]);
3433

3534
const groupByOptions = datasetConfig.getGroupByFieldOptions

static/app/views/dashboards/widgetBuilder/buildSteps/sortByStep/index.tsx

-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import {t, tn} from 'sentry/locale';
99
import {space} from 'sentry/styles/space';
1010
import type {SelectValue} from 'sentry/types/core';
1111
import type {TagCollection} from 'sentry/types/group';
12-
import type {Organization} from 'sentry/types/organization';
1312
import {getDatasetConfig} from 'sentry/views/dashboards/datasetConfig/base';
1413
import type {WidgetQuery, WidgetType} from 'sentry/views/dashboards/types';
1514
import {DisplayType} from 'sentry/views/dashboards/types';
@@ -30,7 +29,6 @@ interface Props {
3029
displayType: DisplayType;
3130
onLimitChange: (newLimit: number) => void;
3231
onSortByChange: (newSortBy: string) => void;
33-
organization: Organization;
3432
queries: WidgetQuery[];
3533
tags: TagCollection;
3634
widgetType: WidgetType;

static/app/views/dashboards/widgetBuilder/buildSteps/visualizationStep.spec.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,6 @@ describe('VisualizationStep', function () {
321321
<MEPSettingProvider>
322322
<DashboardsMEPProvider>
323323
<VisualizationStep
324-
organization={organization}
325324
pageFilters={PageFiltersFixture()}
326325
displayType={DisplayType.TABLE}
327326
error={undefined}

static/app/views/dashboards/widgetBuilder/buildSteps/visualizationStep.tsx

+2-3
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ import {DEFAULT_DEBOUNCE_DURATION} from 'sentry/constants';
1414
import {t} from 'sentry/locale';
1515
import {space} from 'sentry/styles/space';
1616
import type {PageFilters, SelectValue} from 'sentry/types/core';
17-
import type {Organization} from 'sentry/types/organization';
1817
import type {TableDataWithTitle} from 'sentry/utils/discover/discoverQuery';
18+
import useOrganization from 'sentry/utils/useOrganization';
1919
import usePrevious from 'sentry/utils/usePrevious';
2020
import type {DashboardFilters, Widget, WidgetType} from 'sentry/views/dashboards/types';
2121
import {DisplayType} from 'sentry/views/dashboards/types';
@@ -34,7 +34,6 @@ interface Props {
3434
isWidgetInvalid: boolean;
3535
location: Location;
3636
onChange: (displayType: DisplayType) => void;
37-
organization: Organization;
3837
pageFilters: PageFilters;
3938
widget: Widget;
4039
widgetLegendState: WidgetLegendSelectionState;
@@ -45,7 +44,6 @@ interface Props {
4544
}
4645

4746
export function VisualizationStep({
48-
organization,
4947
pageFilters,
5048
displayType,
5149
error,
@@ -58,6 +56,7 @@ export function VisualizationStep({
5856
onWidgetSplitDecision,
5957
widgetLegendState,
6058
}: Props) {
59+
const organization = useOrganization();
6160
const [debouncedWidget, setDebouncedWidget] = useState(widget);
6261

6362
const previousWidget = usePrevious(widget);

static/app/views/dashboards/widgetBuilder/buildSteps/yAxisStep/index.tsx

-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import {t} from 'sentry/locale';
22
import type {TagCollection} from 'sentry/types/group';
3-
import type {Organization} from 'sentry/types/organization';
43
import type {QueryFieldValue} from 'sentry/utils/discover/fields';
54
import type {WidgetType} from 'sentry/views/dashboards/types';
65
import {DisplayType} from 'sentry/views/dashboards/types';
@@ -15,7 +14,6 @@ interface Props {
1514
dataSet: DataSet;
1615
displayType: DisplayType;
1716
onYAxisChange: (newFields: QueryFieldValue[], newSelectedAggregate?: number) => void;
18-
organization: Organization;
1917
tags: TagCollection;
2018
widgetType: WidgetType;
2119
queryErrors?: Record<string, any>[];

static/app/views/dashboards/widgetBuilder/index.tsx

+1-3
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ import WidgetLegendSelectionState from '../widgetLegendSelectionState';
1010

1111
import WidgetBuilder from './widgetBuilder';
1212

13-
interface WidgetBuilderProps
14-
extends Omit<React.ComponentProps<typeof WidgetBuilder>, 'organization'> {}
13+
interface WidgetBuilderProps extends React.ComponentProps<typeof WidgetBuilder> {}
1514

1615
function WidgetBuilderContainer(props: WidgetBuilderProps) {
1716
const organization = useOrganization();
@@ -32,7 +31,6 @@ function WidgetBuilderContainer(props: WidgetBuilderProps) {
3231
>
3332
<WidgetBuilder
3433
{...props}
35-
organization={organization}
3634
widgetLegendState={
3735
new WidgetLegendSelectionState({
3836
location: props.location,

0 commit comments

Comments
 (0)