ref(slack): Remove unused Slack channel lookup code (#54244)

The new Slack channel lookup has been GA'd for about a month now, it's
safe to remove the old code and the feature flags.

Closes #54004

Author: ceorourke

src/sentry/conf/server.py

@@ -1689,8 +1689,6 @@ def SOCIAL_AUTH_DEFAULT_USERNAME() -> str:
     "organizations:org-auth-tokens": False,
     # Enable detecting SDK crashes during event processing
     "organizations:sdk-crash-detection": False,
-    # Enables slack channel lookup via schedule message
-    "organizations:slack-use-new-lookup": False,
     # Enable functionality for recap server polling.
     "organizations:recap-server": False,
     # Adds additional filters and a new section to issue alert rules.

src/sentry/features/__init__.py

@@ -262,7 +262,6 @@
 default_manager.add("organizations:ds-sliding-window", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
 default_manager.add("organizations:ds-sliding-window-org", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
 default_manager.add("organizations:ds-org-recalibration", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
-default_manager.add("organizations:slack-use-new-lookup", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
 default_manager.add("organizations:slack-disable-on-broken", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
 default_manager.add("organizations:sourcemaps-bundle-flat-file-indexing", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
 default_manager.add("organizations:recap-server", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)

src/sentry/integrations/slack/utils/channel.py

@@ -5,7 +5,6 @@
 
 from django.core.exceptions import ValidationError
 
-from sentry import features
 from sentry.integrations.slack.client import SlackClient
 from sentry.models import Integration, Organization
 from sentry.services.hybrid_cloud.integration import RpcIntegration
@@ -61,14 +60,12 @@ def get_channel_id(
     else:
         timeout = SLACK_DEFAULT_TIMEOUT
 
-    # XXX(meredith): For large accounts that have many, many channels it's
-    # possible for us to timeout while attempting to paginate through to find the channel id
+    # XXX(meredith): For large accounts that have many, many users it's
+    # possible for us to timeout while attempting to paginate through to find the user id
     # This means some users are unable to create/update alert rules. To avoid this, we attempt
     # to find the channel id asynchronously if it takes longer than a certain amount of time,
     # which I have set as the SLACK_DEFAULT_TIMEOUT - arbitrarily - to 10 seconds.
 
-    if features.has("organizations:slack-use-new-lookup", organization):
-        return get_channel_id_with_timeout_new(integration, channel_name, timeout)
     return get_channel_id_with_timeout(integration, channel_name, timeout)
 
 
@@ -106,89 +103,6 @@ def get_channel_id_with_timeout(
     integration: Integration | RpcIntegration,
     name: Optional[str],
     timeout: int,
-) -> Tuple[str, Optional[str], bool]:
-    """
-    Fetches the internal slack id of a channel.
-    :param integration: The slack integration
-    :param name: The name of the channel
-    :param timeout: Our self-imposed time limit.
-    :return: a tuple of three values
-        1. prefix: string (`"#"` or `"@"`)
-        2. channel_id: string or `None`
-        3. timed_out: boolean (whether we hit our self-imposed time limit)
-    """
-
-    payload = {
-        "exclude_archived": False,
-        "exclude_members": True,
-        "types": "public_channel,private_channel",
-    }
-
-    list_types = LIST_TYPES
-
-    time_to_quit = time.time() + timeout
-
-    client = SlackClient(integration_id=integration.id)
-    id_data: Optional[Tuple[str, Optional[str], bool]] = None
-    found_duplicate = False
-    prefix = ""
-    for list_type, result_name, prefix in list_types:
-        cursor = ""
-        while True:
-            endpoint = f"/{list_type}.list"
-            try:
-                # Slack limits the response of `<list_type>.list` to 1000 channels
-                items = client.get(endpoint, params=dict(payload, cursor=cursor, limit=1000))
-            except ApiRateLimitedError as e:
-                logger.info(
-                    f"rule.slack.{list_type}_list_rate_limited",
-                    extra={"error": str(e), "integration_id": integration.id},
-                )
-                raise e
-            except ApiError as e:
-                logger.info(
-                    f"rule.slack.{list_type}_list_other_error",
-                    extra={"error": str(e), "integration_id": integration.id},
-                )
-                return prefix, None, False
-
-            if not isinstance(items, dict):
-                continue
-
-            for c in items[result_name]:
-                # The "name" field is unique (this is the username for users)
-                # so we return immediately if we find a match.
-                # convert to lower case since all names in Slack are lowercase
-                if name and c["name"].lower() == name.lower():
-                    return prefix, c["id"], False
-                # If we don't get a match on a unique identifier, we look through
-                # the users' display names, and error if there is a repeat.
-                if list_type == "users":
-                    profile = c.get("profile")
-                    if profile and profile.get("display_name") == name:
-                        if id_data:
-                            found_duplicate = True
-                        else:
-                            id_data = (prefix, c["id"], False)
-
-            cursor = items.get("response_metadata", {}).get("next_cursor", None)
-            if time.time() > time_to_quit:
-                return prefix, None, True
-
-            if not cursor:
-                break
-        if found_duplicate:
-            raise DuplicateDisplayNameError(name)
-        elif id_data:
-            return id_data
-
-    return prefix, None, False
-
-
-def get_channel_id_with_timeout_new(
-    integration: Integration | RpcIntegration,
-    name: Optional[str],
-    timeout: int,
 ) -> Tuple[str, Optional[str], bool]:
     """
     Fetches the internal slack id of a channel using scheduled message.

tests/sentry/api/endpoints/notifications/test_notification_actions_details.py

@@ -18,6 +18,7 @@
 from sentry.testutils.cases import APITestCase
 from sentry.testutils.helpers.slack import install_slack
 from sentry.testutils.silo import assume_test_silo_mode, region_silo_test
+from sentry.utils import json
 
 
 @region_silo_test(stable=True)
@@ -233,26 +234,23 @@ class MockActionRegistration(ActionRegistration):
 
         self.mock_register(data)(MockActionRegistration)
 
-        # Can't find slack channel
         responses.add(
-            method=responses.GET,
-            url="https://slack.com/api/conversations.list",
-            status=500,
-        )
-        self.get_error_response(
-            self.organization.slug,
-            self.notif_action.id,
-            status_code=status.HTTP_400_BAD_REQUEST,
-            method="PUT",
-            **data,
+            method=responses.POST,
+            url="https://slack.com/api/chat.scheduleMessage",
+            status=200,
+            content_type="application/json",
+            body=json.dumps(
+                {"ok": "true", "channel": channel_id, "scheduled_message_id": "Q1298393284"}
+            ),
         )
-        # Successful search for channel
         responses.add(
-            method=responses.GET,
-            url="https://slack.com/api/conversations.list",
+            method=responses.POST,
+            url="https://slack.com/api/chat.deleteScheduledMessage",
             status=200,
-            json={"ok": True, "channels": [{"name": channel_name, "id": channel_id}]},
+            content_type="application/json",
+            body=json.dumps({"ok": True}),
         )
+
         response = self.get_success_response(
             self.organization.slug,
             self.notif_action.id,

tests/sentry/api/endpoints/notifications/test_notification_actions_index.py

@@ -18,6 +18,7 @@
 from sentry.testutils.cases import APITestCase
 from sentry.testutils.helpers.slack import install_slack
 from sentry.testutils.silo import assume_test_silo_mode, region_silo_test
+from sentry.utils import json
 
 
 @region_silo_test(stable=True)
@@ -281,24 +282,21 @@ class MockActionRegistration(ActionRegistration):
 
         self.mock_register(data)(MockActionRegistration)
 
-        # Can't find slack channel
         responses.add(
-            method=responses.GET,
-            url="https://slack.com/api/conversations.list",
-            status=500,
-        )
-        self.get_error_response(
-            self.organization.slug,
-            status_code=status.HTTP_400_BAD_REQUEST,
-            method="POST",
-            **data,
+            method=responses.POST,
+            url="https://slack.com/api/chat.scheduleMessage",
+            status=200,
+            content_type="application/json",
+            body=json.dumps(
+                {"ok": "true", "channel": channel_id, "scheduled_message_id": "Q1298393284"}
+            ),
         )
-        # Successful search for channel
         responses.add(
-            method=responses.GET,
-            url="https://slack.com/api/conversations.list",
+            method=responses.POST,
+            url="https://slack.com/api/chat.deleteScheduledMessage",
             status=200,
-            json={"ok": True, "channels": [{"name": channel_name, "id": channel_id}]},
+            content_type="application/json",
+            body=json.dumps({"ok": True}),
         )
         response = self.get_success_response(
             self.organization.slug,

tests/sentry/incidents/action_handlers/test_slack.py

@@ -28,14 +28,21 @@ def setUp(self):
         self.channel_id = "some_id"
         self.channel_name = "#hello"
         responses.add(
-            method=responses.GET,
-            url="https://slack.com/api/conversations.list",
+            method=responses.POST,
+            url="https://slack.com/api/chat.scheduleMessage",
             status=200,
             content_type="application/json",
             body=json.dumps(
-                {"ok": "true", "channels": [{"name": self.channel_name[1:], "id": self.channel_id}]}
+                {"ok": "true", "channel": self.channel_id, "scheduled_message_id": "Q1298393284"}
             ),
         )
+        responses.add(
+            method=responses.POST,
+            url="https://slack.com/api/chat.deleteScheduledMessage",
+            status=200,
+            content_type="application/json",
+            body=json.dumps({"ok": True}),
+        )
         self.action = self.create_alert_rule_trigger_action(
             target_identifier=self.channel_name,
             type=AlertRuleTriggerAction.Type.SLACK,