fix(issues): Escape status tag on search

Tag keys that conflict with our issue keys must be escaped

fixes #89369

Author: scttcper

static/app/components/events/eventTags/eventTagsTreeRow.tsx

@@ -17,7 +17,7 @@ import {t} from 'sentry/locale';
 import {space} from 'sentry/styles/space';
 import type {Event} from 'sentry/types/event';
 import type {Project} from 'sentry/types/project';
-import {generateQueryWithTag} from 'sentry/utils';
+import {escapeIssueTagKey, generateQueryWithTag} from 'sentry/utils';
 import {isEmptyObject} from 'sentry/utils/object/isEmptyObject';
 import {isUrl} from 'sentry/utils/string/isUrl';
 import useCopyToClipboard from 'sentry/utils/useCopyToClipboard';
@@ -150,7 +150,14 @@ function EventTagsTreeRowDropdown({
     project?.highlightTags &&
     // Skip tags already highlighted
     highlightTagSet.has(originalTag.key);
-  const query = generateQueryWithTag({referrer}, originalTag);
+  const query = generateQueryWithTag(
+    {referrer},
+    {
+      ...originalTag,
+      key: escapeIssueTagKey(originalTag.key),
+    }
+  );
+
   const isProjectAdmin = hasEveryAccess(['project:admin'], {
     organization,
     project,

static/app/utils.spec.tsx

@@ -0,0 +1,13 @@
+import {escapeIssueTagKey} from './utils';
+
+describe('escapeIssueTagKey', () => {
+  it('should escape conflicting tag keys', () => {
+    expect(escapeIssueTagKey('status')).toBe('tags[status]');
+    expect(escapeIssueTagKey('message')).toBe('tags[message]');
+  });
+
+  it('should not escape environment and project', () => {
+    expect(escapeIssueTagKey('environment')).toBe('environment');
+    expect(escapeIssueTagKey('project')).toBe('project');
+  });
+});

static/app/utils.tsx

@@ -1,6 +1,10 @@
 import type {Query} from 'history';
 
 import type {EventTag} from 'sentry/types/event';
+import {
+  type FieldKey,
+  ISSUE_EVENT_FIELDS_THAT_MAY_CONFLICT_WITH_TAGS,
+} from 'sentry/utils/fields';
 import {appendTagCondition} from 'sentry/utils/queryString';
 
 export function intcomma(x: number): string {
@@ -92,6 +96,22 @@ export function isWebpackChunkLoadingError(error: Error): boolean {
   );
 }
 
+/**
+ * If a tag conflicts with a reserved keyword, change it to `tags[key]:value`
+ */
+export function escapeIssueTagKey(key: string) {
+  // Environment and project should be handled by the page filter
+  if (key === 'environment' || key === 'project') {
+    return key;
+  }
+
+  if (ISSUE_EVENT_FIELDS_THAT_MAY_CONFLICT_WITH_TAGS.has(key as FieldKey)) {
+    return `tags[${key}]`;
+  }
+
+  return key;
+}
+
 export function generateQueryWithTag(prevQuery: Query, tag: EventTag): Query {
   const query = {...prevQuery};
 

static/app/utils/fields/index.ts

@@ -106,6 +106,7 @@ export enum FieldKey {
   STACK_PACKAGE = 'stack.package',
   STACK_RESOURCE = 'stack.resource',
   STACK_STACK_LEVEL = 'stack.stack_level',
+  STATUS = 'status',
   TIMESTAMP = 'timestamp',
   TIMESTAMP_TO_DAY = 'timestamp.to_day',
   TIMESTAMP_TO_HOUR = 'timestamp.to_hour',
@@ -1703,6 +1704,11 @@ const EVENT_FIELD_DEFINITIONS: Record<AllEventFieldKeys, FieldDefinition> = {
     kind: FieldKind.FIELD,
     valueType: FieldValueType.NUMBER,
   },
+  [FieldKey.STATUS]: {
+    desc: t('Status of the issue'),
+    kind: FieldKind.FIELD,
+    valueType: FieldValueType.STRING,
+  },
   [FieldKey.TIMES_SEEN]: {
     desc: t('Total number of events'),
     kind: FieldKind.FIELD,
@@ -1993,6 +1999,7 @@ export const ISSUE_EVENT_FIELDS_THAT_MAY_CONFLICT_WITH_TAGS: Set<FieldKey> = new
   FieldKey.STACK_MODULE,
   FieldKey.STACK_PACKAGE,
   FieldKey.STACK_STACK_LEVEL,
+  FieldKey.STATUS,
   FieldKey.TIMESTAMP,
   FieldKey.TITLE,
   FieldKey.TRACE,

static/app/views/issueDetails/groupTags/tagDetailsDrawerContent.tsx

@@ -18,7 +18,7 @@ import {IconArrow, IconEllipsis, IconOpen} from 'sentry/icons';
 import {t, tct} from 'sentry/locale';
 import {space} from 'sentry/styles/space';
 import type {Group, Tag, TagValue} from 'sentry/types/group';
-import {percent} from 'sentry/utils';
+import {escapeIssueTagKey, generateQueryWithTag, percent} from 'sentry/utils';
 import {SavedQueryDatasets} from 'sentry/utils/discover/types';
 import {isUrl} from 'sentry/utils/string/isUrl';
 import useCopyToClipboard from 'sentry/utils/useCopyToClipboard';
@@ -251,8 +251,13 @@ function TagValueActionsMenu({
   const {onClick: handleCopy} = useCopyToClipboard({
     text: tagValue.value,
   });
-  const key = tagValue.key ?? tag.key;
-  const query = {query: tagValue.query || `${key}:"${tagValue.value}"`};
+  const referrer = 'tag-details-drawer';
+  const key = escapeIssueTagKey(tagValue.key ?? tag.key);
+  const query = tagValue.query
+    ? {
+        query: tagValue.query,
+      }
+    : generateQueryWithTag({referrer}, {key, value: tagValue.value});
   const eventView = useIssueDetailsEventView({group, queryProps: query});
   const [isVisible, setIsVisible] = useState(false);