Skip to content

Commit 4842a66

Browse files
authored
fix(widget-builder): Visualize field overflows on long field names (#85271)
some weird UI that I fixed | Before | After | |--------|--------| | <img width="569" alt="image" src="https://github.com/user-attachments/assets/5f0df3a5-4157-4cc4-8e96-4706701560a1" /> | <img width="518" alt="image" src="https://github.com/user-attachments/assets/0d36773b-196d-4452-b3d9-1cc4cba7e703" /> |
1 parent e736724 commit 4842a66

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

Diff for: static/app/views/dashboards/widgetBuilder/components/common/sortableFieldWrapper.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ function SortableVisualizeFieldWrapper({
3030
transition,
3131
zIndex: 'auto',
3232
display: 'flex',
33-
gap: space(1),
33+
gap: space(0.5),
3434
width: '100%',
3535
} as React.CSSProperties;
3636

Diff for: static/app/views/dashboards/widgetBuilder/components/visualize/index.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -899,12 +899,13 @@ export const FieldBar = styled('div')`
899899
grid-template-columns: 1fr;
900900
gap: ${space(1)};
901901
flex: 3;
902+
min-width: 0;
902903
`;
903904

904905
export const PrimarySelectRow = styled('div')<{hasColumnParameter: boolean}>`
905906
display: flex;
906907
width: 100%;
907-
flex: 3;
908+
min-width: 0;
908909
909910
& > ${ColumnCompactSelect} > button {
910911
border-top-left-radius: 0;
@@ -926,6 +927,7 @@ export const FieldRow = styled('div')`
926927
flex-direction: row;
927928
gap: ${space(1)};
928929
width: 100%;
930+
min-width: 0;
929931
`;
930932

931933
export const StyledDeleteButton = styled(Button)``;

Diff for: static/app/views/dashboards/widgetBuilder/components/visualize/selectRow.tsx

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ import {
1717
} from 'sentry/utils/discover/fields';
1818
import useOrganization from 'sentry/utils/useOrganization';
1919
import {getDatasetConfig} from 'sentry/views/dashboards/datasetConfig/base';
20-
import {WidgetType} from 'sentry/views/dashboards/types';
21-
import {DisplayType} from 'sentry/views/dashboards/types';
20+
import {DisplayType, WidgetType} from 'sentry/views/dashboards/types';
2221
import {
2322
AggregateCompactSelect,
2423
getAggregateValueKey,

0 commit comments

Comments
 (0)