Skip to content

Commit 4a189c1

Browse files
ref: remove xfail_if_not_postgres (#82097)
this hasn't been functional since sentry moved to github actions <!-- Describe your PR here. -->
1 parent a5750fd commit 4a189c1

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

Diff for: src/sentry/testutils/skips.py

-10
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from __future__ import annotations
22

3-
import os
43
import socket
54
from collections.abc import Callable
65
from typing import Any, TypeVar
@@ -12,15 +11,6 @@
1211
T = TypeVar("T", bound=Callable[..., Any])
1312

1413

15-
def xfail_if_not_postgres(reason: str) -> Callable[[T], T]:
16-
def decorator(function: T) -> T:
17-
return pytest.mark.xfail(os.environ.get("TEST_SUITE") != "postgres", reason=reason)(
18-
function
19-
)
20-
21-
return decorator
22-
23-
2414
def skip_for_relay_store(reason: str) -> Callable[[T], T]:
2515
"""
2616
Decorator factory will skip marked tests if Relay is enabled.

Diff for: tests/snuba/search/test_backend.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
from sentry.testutils.cases import SnubaTestCase, TestCase, TransactionTestCase
3636
from sentry.testutils.helpers import Feature, apply_feature_flag_on_cls
3737
from sentry.testutils.helpers.datetime import before_now, iso_format
38-
from sentry.testutils.skips import xfail_if_not_postgres
3938
from sentry.types.group import GroupSubStatus, PriorityLevel
4039
from sentry.utils import json
4140
from sentry.utils.snuba import SENTRY_SNUBA_MAP
@@ -121,7 +120,7 @@ def setUp(self):
121120
data={
122121
"fingerprint": ["put-me-in-group1"],
123122
"event_id": "a" * 32,
124-
"message": "foo. Also, this message is intended to be greater than 256 characters so that we can put some unique string identifier after that point in the string. The purpose of this is in order to verify we are using snuba to search messages instead of Postgres (postgres truncates at 256 characters and clickhouse does not). santryrox.",
123+
"message": "foo. Indeed, this message is intended to be greater than 256 characters such that we can put this unique string identifier after that point in the string. The purpose of this is in order to verify we are using snuba to search messages instead of Postgres (postgres truncates at 256 characters and clickhouse does not). santryrox.",
125124
"environment": "production",
126125
"tags": {"server": "example.com", "sentry:user": "[email protected]"},
127126
"timestamp": event1_timestamp,
@@ -2120,7 +2119,6 @@ def test_query_enclosed_in_quotes(self):
21202119
results = self.make_query(search_filter_query='"bar"')
21212120
assert set(results) == {self.group2}
21222121

2123-
@xfail_if_not_postgres("Wildcard searching only supported in Postgres")
21242122
def test_wildcard(self):
21252123
escaped_event = self.store_event(
21262124
data={

0 commit comments

Comments
 (0)