Remove excluded_projects & include_all_projects columns (#81204)

In preparation for removing the `AlertRuleExcludedProjects` model (see
#81020) we need to first remove
the many to many `excluded_projects` column on the `AlertRule` model. We
can take the opportunity to remove the now unused `include_all_projects`
column. This PR uses the brand new `SafeRemoveField` option added in
#81098

Author: ceorourke

migrations_lockfile.txt

@@ -15,7 +15,7 @@ remote_subscriptions: 0003_drop_remote_subscription
 
 replays: 0004_index_together
 
-sentry: 0793_remove_db_constraint_alert_rule_exclusion
+sentry: 0794_rm_excluded_included_projects_alertrule
 
 social_auth: 0002_default_auto_field
 

src/sentry/deletions/defaults/project.py

@@ -93,7 +93,7 @@ def get_child_relations(self, instance: Project) -> list[BaseRelation]:
         relations.append(
             ModelRelation(
                 AlertRule,
-                {"snuba_query__subscriptions__project": instance, "include_all_projects": False},
+                {"snuba_query__subscriptions__project": instance},
             )
         )
 

src/sentry/incidents/models/alert_rule.py

@@ -301,15 +301,6 @@ class AlertRule(Model):
 
     user_id = HybridCloudForeignKey(settings.AUTH_USER_MODEL, null=True, on_delete="SET_NULL")
     team = FlexibleForeignKey("sentry.Team", null=True, on_delete=models.SET_NULL)
-
-    excluded_projects = models.ManyToManyField(
-        "sentry.Project", related_name="alert_rule_exclusions", through=AlertRuleExcludedProjects
-    )  # NOTE: This feature is not currently utilized.
-    # Determines whether we include all current and future projects from this
-    # organization in this rule.
-    include_all_projects = models.BooleanField(
-        default=False
-    )  # NOTE: This feature is not currently utilized.
     name = models.TextField()
     status = models.SmallIntegerField(default=AlertRuleStatus.PENDING.value)
     threshold_type = models.SmallIntegerField(null=True)

src/sentry/migrations/0794_rm_excluded_included_projects_alertrule.py

@@ -0,0 +1,45 @@
+# Generated by Django 5.1.1 on 2024-11-22 19:12
+
+from django.db import migrations, models
+
+from sentry.new_migrations.migrations import CheckedMigration
+from sentry.new_migrations.monkey.fields import SafeRemoveField
+from sentry.new_migrations.monkey.state import DeletionAction
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production.
+    # This should only be used for operations where it's safe to run the migration after your
+    # code has deployed. So this should not be used for most operations that alter the schema
+    # of a table.
+    # Here are some things that make sense to mark as post deployment:
+    # - Large data migrations. Typically we want these to be run manually so that they can be
+    #   monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   run this outside deployments so that we don't block them. Note that while adding an index
+    #   is a schema change, it's completely safe to run the operation after the code has deployed.
+    # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
+
+    is_post_deployment = False
+
+    dependencies = [
+        ("sentry", "0793_remove_db_constraint_alert_rule_exclusion"),
+    ]
+
+    operations = [
+        SafeRemoveField(
+            model_name="alertrule",
+            name="excluded_projects",
+            deletion_action=DeletionAction.MOVE_TO_PENDING,
+        ),
+        migrations.AlterField(
+            model_name="alertrule",
+            name="include_all_projects",
+            field=models.BooleanField(default=False, null=True),
+        ),
+        SafeRemoveField(
+            model_name="alertrule",
+            name="include_all_projects",
+            deletion_action=DeletionAction.MOVE_TO_PENDING,
+        ),
+    ]