Merge branch 'priscila/ref/quick-start/clean-up-deprecated-code' into priscila/ref/quick-start/rename-variables

Author: priscilawebdev

requirements-dev-frozen.txt

@@ -238,7 +238,7 @@ unidiff==0.7.4
 uritemplate==4.1.1
 urllib3==2.2.2
 vine==5.1.0
-virtualenv==20.25.0
+virtualenv==20.26.6
 wcwidth==0.2.10
 werkzeug==3.0.6
 wheel==0.38.4

src/sentry/api/helpers/group_index/update.py

@@ -52,6 +52,7 @@
 from sentry.types.group import SUBSTATUS_UPDATE_CHOICES, GroupSubStatus, PriorityLevel
 from sentry.users.models.user import User
 from sentry.users.services.user import RpcUser
+from sentry.users.services.user.serial import serialize_generic_user
 from sentry.users.services.user.service import user_service
 from sentry.users.services.user_option import user_option_service
 from sentry.utils import metrics
@@ -194,8 +195,6 @@ def update_groups(
 
     result = dict(serializer.validated_data)
 
-    acting_user = user if user.is_authenticated else None
-
     discard = result.get("discard")
     if discard:
         return handle_discard(request, groups, projects, acting_user)
@@ -219,7 +218,6 @@ def update_groups(
                 projects,
                 project_lookup,
                 acting_user,
-                user,
                 result,
             )
         except MultipleProjectsError:
@@ -232,7 +230,6 @@ def update_groups(
             project_lookup,
             status_details,
             acting_user,
-            user,
         )
 
     return prepare_response(
@@ -344,19 +341,25 @@ def handle_resolve_in_release(
     projects: Sequence[Project],
     project_lookup: Mapping[int, Project],
     acting_user: RpcUser | User | None,
-    user: RpcUser | User | AnonymousUser,
     result: MutableMapping[str, Any],
 ) -> tuple[dict[str, Any], int | None]:
     res_type = None
     release = None
     commit = None
     self_assign_issue = "0"
+    new_status_details = {}
     if acting_user:
         user_options = user_option_service.get_many(
             filter={"user_ids": [acting_user.id], "keys": ["self_assign_issue"]}
         )
         if user_options:
             self_assign_issue = user_options[0].value
+        serialized_user = user_service.serialize_many(
+            filter=dict(user_ids=[acting_user.id]), as_user=serialize_generic_user(acting_user)
+        )
+        if serialized_user:
+            new_status_details["actor"] = serialized_user[0]
+
     res_status = None
     if status == "resolvedInNextRelease" or status_details.get("inNextRelease"):
         # TODO(jess): We may want to support this for multi project, but punting on it for now
@@ -371,12 +374,7 @@ def handle_resolve_in_release(
             "version": ""
         }
 
-        serialized_user = user_service.serialize_many(filter=dict(user_ids=[user.id]), as_user=user)
-        new_status_details = {
-            "inNextRelease": True,
-        }
-        if serialized_user:
-            new_status_details["actor"] = serialized_user[0]
+        new_status_details["inNextRelease"] = True
         res_type = GroupResolution.Type.in_next_release
         res_type_str = "in_next_release"
         res_status = GroupResolution.Status.pending
@@ -387,12 +385,7 @@ def handle_resolve_in_release(
         activity_type = ActivityType.SET_RESOLVED_IN_RELEASE.value
         activity_data = {"version": ""}
 
-        serialized_user = user_service.serialize_many(filter=dict(user_ids=[user.id]), as_user=user)
-        new_status_details = {
-            "inUpcomingRelease": True,
-        }
-        if serialized_user:
-            new_status_details["actor"] = serialized_user[0]
+        new_status_details["inUpcomingRelease"] = True
         res_type = GroupResolution.Type.in_upcoming_release
         res_type_str = "in_upcoming_release"
         res_status = GroupResolution.Status.pending
@@ -409,12 +402,7 @@ def handle_resolve_in_release(
             "version": release.version
         }
 
-        serialized_user = user_service.serialize_many(filter=dict(user_ids=[user.id]), as_user=user)
-        new_status_details = {
-            "inRelease": release.version,
-        }
-        if serialized_user:
-            new_status_details["actor"] = serialized_user[0]
+        new_status_details["inRelease"] = release.version
         res_type = GroupResolution.Type.in_release
         res_type_str = "in_release"
         res_status = GroupResolution.Status.resolved
@@ -426,13 +414,8 @@ def handle_resolve_in_release(
         commit = status_details["inCommit"]
         activity_type = ActivityType.SET_RESOLVED_IN_COMMIT.value
         activity_data = {"commit": commit.id}
-        serialized_user = user_service.serialize_many(filter=dict(user_ids=[user.id]), as_user=user)
+        new_status_details["inCommit"] = serialize(commit, acting_user)
 
-        new_status_details = {
-            "inCommit": serialize(commit, user),
-        }
-        if serialized_user:
-            new_status_details["actor"] = serialized_user[0]
         res_type_str = "in_commit"
     else:
         res_type_str = "now"
@@ -473,7 +456,6 @@ def handle_resolve_in_release(
                 res_type,
                 res_status,
                 acting_user,
-                user,
                 self_assign_issue,
                 activity_type,
                 activity_data,
@@ -482,7 +464,7 @@ def handle_resolve_in_release(
 
         issue_resolved.send_robust(
             organization_id=projects[0].organization_id,
-            user=(acting_user or user),
+            user=acting_user,
             group=group,
             project=project_lookup[group.project_id],
             resolution_type=res_type_str,
@@ -506,7 +488,6 @@ def process_group_resolution(
     res_type: int | None,
     res_status: int | None,
     acting_user: RpcUser | User | None,
-    user: RpcUser | User | AnonymousUser,
     self_assign_issue: str,
     activity_type: int,
     activity_data: MutableMapping[str, Any],
@@ -521,7 +502,7 @@ def process_group_resolution(
             "release": release,
             "type": res_type,
             "status": res_status,
-            "actor_id": user.id if user and user.is_authenticated else None,
+            "actor_id": acting_user.id if acting_user and acting_user.is_authenticated else None,
         }
 
         # We only set `current_release_version` if GroupResolution type is
@@ -700,7 +681,6 @@ def handle_other_status_updates(
     project_lookup: Mapping[int, Project],
     status_details: dict[str, Any],
     acting_user: RpcUser | User | None,
-    user: RpcUser | User | AnonymousUser,
 ) -> dict[str, Any]:
     group_ids = [group.id for group in group_list]
     queryset = Group.objects.filter(id__in=group_ids)
@@ -721,9 +701,7 @@ def handle_other_status_updates(
                     group_list, acting_user, projects, sender=update_groups
                 )
             else:
-                result["statusDetails"] = handle_ignored(
-                    group_list, status_details, acting_user, user
-                )
+                result["statusDetails"] = handle_ignored(group_list, status_details, acting_user)
             result["inbox"] = None
         else:
             result["statusDetails"] = {}

src/sentry/conf/server.py

@@ -826,6 +826,7 @@ def SOCIAL_AUTH_DEFAULT_USERNAME() -> str:
     "sentry.tasks.auto_ongoing_issues",
     "sentry.tasks.check_am2_compatibility",
     "sentry.tasks.statistical_detectors",
+    "sentry.tempest.tasks",
     "sentry.debug_files.tasks",
     "sentry.tasks.on_demand_metrics",
     "sentry.middleware.integrations.tasks",

src/sentry/issues/ignored.py

@@ -6,7 +6,6 @@
 from datetime import datetime, timedelta
 from typing import Any, TypedDict
 
-from django.contrib.auth.models import AnonymousUser
 from django.utils import timezone
 
 from sentry.db.postgres.transactions import in_test_hide_transaction_boundary
@@ -90,7 +89,6 @@ def handle_ignored(
     group_list: Sequence[Group],
     status_details: dict[str, Any],
     acting_user: RpcUser | User | None,
-    user: User | RpcUser | AnonymousUser,
 ) -> IgnoredStatusDetails:
     """
     Handle issues that are ignored and create a snooze for them.
@@ -133,17 +131,19 @@ def handle_ignored(
                     "user_count": ignore_user_count,
                     "user_window": ignore_user_window,
                     "state": state,
-                    "actor_id": user.id if user.is_authenticated else None,
+                    "actor_id": acting_user.id if acting_user else None,
                 },
             )
 
             Group.objects.filter(id=group.id, status=GroupStatus.UNRESOLVED).update(
                 substatus=GroupSubStatus.UNTIL_CONDITION_MET, status=GroupStatus.IGNORED
             )
             with in_test_hide_transaction_boundary():
-                serialized_user = user_service.serialize_many(
-                    filter=dict(user_ids=[user.id]), as_user=serialize_generic_user(user)
-                )
+                if acting_user:
+                    serialized_user = user_service.serialize_many(
+                        filter=dict(user_ids=[acting_user.id]),
+                        as_user=serialize_generic_user(acting_user),
+                    )
             new_status_details = IgnoredStatusDetails(
                 ignoreCount=ignore_count,
                 ignoreUntil=ignore_until,

src/sentry/testutils/fixtures.py

@@ -61,7 +61,12 @@ def projectkey(self):
 
     @cached_property
     def user(self) -> User:
-        return self.create_user("admin@localhost", is_superuser=True, is_staff=True)
+        return self.create_user(
+            "admin@localhost",
+            is_superuser=True,
+            is_staff=True,
+            is_sentry_app=False,
+        )
 
     @cached_property
     def organization(self):

static/app/components/onboardingWizard/newSidebar.tsx

@@ -267,7 +267,6 @@ function Task({task, hidePanel, showWaitingIndicator}: TaskProps) {
         todo_id: task.task,
         todo_title: task.title,
         action: 'clickthrough',
-        new_experience: true,
       });
 
       e.stopPropagation();
@@ -305,7 +304,6 @@ function Task({task, hidePanel, showWaitingIndicator}: TaskProps) {
         todo_id: task.task,
         todo_title: task.title,
         action: 'skipped',
-        new_experience: true,
       });
       updateOnboardingTask(api, organization, {
         task: taskKey,