Skip to content

Commit 677415e

Browse files
authored
feat(alerts): Remove "Suspects" UI and endpoint (#16378)
This was used on the Incidents details view, but is no longer used
1 parent d1ab22f commit 677415e

File tree

7 files changed

+0
-307
lines changed

7 files changed

+0
-307
lines changed

src/sentry/api/endpoints/organization_incident_suspects_index.py

Lines changed: 0 additions & 35 deletions
This file was deleted.

src/sentry/api/urls.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,6 @@
108108
from .endpoints.organization_incident_subscription_index import (
109109
OrganizationIncidentSubscriptionIndexEndpoint,
110110
)
111-
from .endpoints.organization_incident_suspects_index import (
112-
OrganizationIncidentSuspectsIndexEndpoint,
113-
)
114111
from .endpoints.organization_index import OrganizationIndexEndpoint
115112
from .endpoints.organization_integration_details import OrganizationIntegrationDetailsEndpoint
116113
from .endpoints.organization_integration_repos import OrganizationIntegrationReposEndpoint
@@ -641,11 +638,6 @@
641638
OrganizationIncidentSubscriptionIndexEndpoint.as_view(),
642639
name="sentry-api-0-organization-incident-subscription-index",
643640
),
644-
url(
645-
r"^(?P<organization_slug>[^\/]+)/incidents/(?P<incident_identifier>[^\/]+)/suspects/$",
646-
OrganizationIncidentSuspectsIndexEndpoint.as_view(),
647-
name="sentry-api-0-organization-incident-suspect-index",
648-
),
649641
url(
650642
r"^(?P<organization_slug>[^\/]+)/chunk-upload/$",
651643
ChunkUploadEndpoint.as_view(),

src/sentry/static/sentry/app/views/incidents/details/body.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import space from 'app/styles/space';
1616
import theme from 'app/utils/theme';
1717

1818
import Activity from './activity';
19-
import Suspects from './suspects';
2019

2120
import {Incident} from '../types';
2221

@@ -84,8 +83,6 @@ export default class DetailsBody extends React.Component<Props> {
8483
</div>
8584
)}
8685
</div>
87-
88-
<Suspects {...this.props} />
8986
</PageContent>
9087
</Sidebar>
9188
</StyledPageContent>

src/sentry/static/sentry/app/views/incidents/details/suspects.tsx

Lines changed: 0 additions & 153 deletions
This file was deleted.
Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +0,0 @@
1-
import {Repository} from './repository';
2-
import {User} from './user';
3-
4-
export function IncidentSuspectCommit(params = []) {
5-
return {
6-
data: {
7-
repository: Repository(),
8-
author: User(),
9-
dateCreated: '2019-03-28T01:36:35.457Z',
10-
score: 2,
11-
message:
12-
'feat: Do something to raven/base.py\nvenenatis curae tincidunt feugiat duis parturient metus',
13-
id: 'ec85fa0c622c13a09cd27443132711551f45f504',
14-
...params,
15-
},
16-
type: 'commit',
17-
};
18-
}

tests/js/spec/views/incidents/details/index.spec.jsx

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,10 @@ describe('IncidentDetails', function() {
3636
method: 'POST',
3737
});
3838

39-
MockApiClient.addMockResponse({
40-
url: '/organizations/org-slug/incidents/123/suspects/',
41-
body: [TestStubs.IncidentSuspectCommit()],
42-
});
4339
MockApiClient.addMockResponse({
4440
url: '/organizations/org-slug/incidents/456/',
4541
statusCode: 404,
4642
});
47-
MockApiClient.addMockResponse({
48-
url: '/organizations/org-slug/incidents/456/suspects/',
49-
statusCode: 404,
50-
});
5143
MockApiClient.addMockResponse({
5244
url: '/organizations/org-slug/incidents/456/activity/',
5345
statusCode: 404,
@@ -89,15 +81,6 @@ describe('IncidentDetails', function() {
8981
.at(2)
9082
.text()
9183
).toBe('20');
92-
93-
expect(wrapper.find('SuspectItem')).toHaveLength(1);
94-
expect(
95-
wrapper
96-
.find('SuspectItem')
97-
.at(0)
98-
.find('MessageOverflow')
99-
.text()
100-
).toBe('feat: Do something to raven/base.py');
10184
});
10285

10386
it('handles invalid incident', async function() {

tests/sentry/api/endpoints/test_organization_incident_suspects_index.py

Lines changed: 0 additions & 73 deletions
This file was deleted.

0 commit comments

Comments
 (0)