feat(notifications): remove logic to remove notificationsetting rows when the user uninstalls slack (#60535)

This PR removes logic to change notification settings when a user
uninstalls Slack. This is unnecessary, if the user doesn't have Slack
installed we don't need to worry about clearing out settings as we won't
show Slack as a possible option in the notification settings UI and it
won't notify them.

Author: Stephen Cefali

src/sentry/integrations/slack/integration.py

@@ -16,12 +16,7 @@
 )
 from sentry.models.integrations.integration import Integration
 from sentry.pipeline import NestedPipelineView
-from sentry.services.hybrid_cloud.notifications import notifications_service
-from sentry.services.hybrid_cloud.organization import (
-    RpcOrganizationSummary,
-    RpcUserOrganizationContext,
-    organization_service,
-)
+from sentry.services.hybrid_cloud.organization import RpcOrganizationSummary
 from sentry.shared_integrations.exceptions import ApiError, IntegrationError
 from sentry.tasks.integrations.slack import link_slack_user_identities
 from sentry.utils.http import absolute_uri
@@ -87,21 +82,6 @@ def get_config_data(self) -> Mapping[str, str]:
         )
         return {"installationType": metadata_.get("installation_type", default_installation)}
 
-    def uninstall(self) -> None:
-        """
-        Delete all parent-specific notification settings. For each user and team,
-        if this is their ONLY Slack integration, set their parent-independent
-        Slack notification setting to NEVER.
-        """
-        org_context: RpcUserOrganizationContext | None = (
-            organization_service.get_organization_by_id(id=self.organization_id, user_id=None)
-        )
-        if org_context:
-            notifications_service.uninstall_slack_settings(
-                organization_id=self.organization_id,
-                project_ids=[p.id for p in org_context.organization.projects],
-            )
-
 
 class SlackIntegrationProvider(IntegrationProvider):
     key = "slack"

src/sentry/notifications/manager.py

@@ -2,7 +2,7 @@
 
 import logging
 from collections import defaultdict
-from typing import TYPE_CHECKING, Iterable, List, Mapping, MutableSet, Optional, Set, Union
+from typing import TYPE_CHECKING, Iterable, Mapping, MutableSet, Optional, Set, Union
 
 from django.db import router, transaction
 from django.db.models import Q, QuerySet
@@ -20,7 +20,6 @@
     NOTIFICATION_SCOPE_TYPE,
     NOTIFICATION_SETTING_OPTION_VALUES,
     NOTIFICATION_SETTING_TYPES,
-    VALID_VALUES_FOR_KEY,
     VALID_VALUES_FOR_KEY_V2,
     NotificationScopeEnum,
     NotificationScopeType,
@@ -485,39 +484,3 @@ def update_provider_settings(self, user_id: int | None, team_id: int | None):
                 **base_query,
                 type__in=[NOTIFICATION_SETTING_TYPES[type] for type in types_to_delete],
             ).delete()
-
-    def remove_parent_settings_for_organization(
-        self, organization_id: int, project_ids: List[int], provider: ExternalProviders
-    ) -> None:
-        """Delete all parent-specific notification settings referencing this organization."""
-        kwargs = {}
-        kwargs["provider"] = provider.value
-
-        self.filter(
-            Q(scope_type=NotificationScopeType.PROJECT.value, scope_identifier__in=project_ids)
-            | Q(
-                scope_type=NotificationScopeType.ORGANIZATION.value,
-                scope_identifier=organization_id,
-            ),
-            **kwargs,
-        ).delete()
-
-    def disable_settings_for_users(
-        self, provider: ExternalProviders, users: Iterable[User]
-    ) -> None:
-        """
-        Given a list of users, overwrite all of their parent-independent
-        notification settings to NEVER.
-        TODO(mgaeta): Django 3 has self.bulk_create() which would allow us to do
-         this in a single query.
-        """
-        for user in users:
-            for type in VALID_VALUES_FOR_KEY.keys():
-                self.update_or_create(
-                    provider=provider.value,
-                    type=type.value,
-                    scope_type=NotificationScopeType.USER.value,
-                    scope_identifier=user.id,
-                    user_id=user.id,
-                    defaults={"value": NotificationSettingOptionValues.NEVER.value},
-                )

src/sentry/services/hybrid_cloud/notifications/impl.py

@@ -35,17 +35,6 @@
 
 
 class DatabaseBackedNotificationsService(NotificationsService):
-    def uninstall_slack_settings(self, organization_id: int, project_ids: List[int]) -> None:
-        provider = ExternalProviders.SLACK
-        users = User.objects.get_users_with_only_one_integration_for_provider(
-            provider, organization_id
-        )
-
-        NotificationSetting.objects.remove_parent_settings_for_organization(
-            organization_id, project_ids, provider
-        )
-        NotificationSetting.objects.disable_settings_for_users(provider, users)
-
     def update_settings(
         self,
         *,

src/sentry/services/hybrid_cloud/notifications/service.py

@@ -74,15 +74,6 @@ def update_notification_options(
     ) -> None:
         pass
 
-    @rpc_method
-    @abstractmethod
-    def uninstall_slack_settings(
-        self,
-        organization_id: int,
-        project_ids: List[int],
-    ) -> None:
-        pass
-
     @rpc_method
     @abstractmethod
     def remove_notification_settings_for_team(