Skip to content

Commit 690aa3b

Browse files
armenzgameliahsu
authored andcommitted
fix(derived_code_mappings): Do not let NeedsExtension report as an error (#85976)
This will prevent unnecessary blocks on the deployment pipeline.
1 parent d7ec29c commit 690aa3b

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

Diff for: src/sentry/issues/auto_source_code_config/code_mapping.py

+9-2
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,13 @@ def derive_code_mappings(
6060
return []
6161
trees = installation.get_trees_for_org()
6262
trees_helper = CodeMappingTreesHelper(trees)
63-
frame_filename = FrameFilename(frame)
64-
return trees_helper.list_file_matches(frame_filename)
63+
try:
64+
frame_filename = FrameFilename(frame)
65+
return trees_helper.list_file_matches(frame_filename)
66+
except NeedsExtension:
67+
logger.warning("Needs extension: %s", frame.get("filename"))
68+
69+
return []
6570

6671

6772
# XXX: Look at sentry.interfaces.stacktrace and maybe use that
@@ -200,6 +205,8 @@ def _stacktrace_buckets(
200205
buckets[frame_filename.root].append(frame_filename)
201206
except UnsupportedFrameFilename:
202207
logger.warning("Frame's filepath not supported: %s", frame.get("filename"))
208+
except NeedsExtension:
209+
logger.warning("Needs extension: %s", frame.get("filename"))
203210
except Exception:
204211
logger.exception("Unable to split stacktrace path into buckets")
205212

0 commit comments

Comments
 (0)