Skip to content

Commit 6a478a2

Browse files
♻️ check if url is link before opening modal
1 parent c1bb7ae commit 6a478a2

File tree

1 file changed

+15
-8
lines changed

1 file changed

+15
-8
lines changed

static/app/components/feedback/feedbackItem/feedbackItem.tsx

+15-8
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,11 @@ export default function FeedbackItem({feedbackItem, eventData, tags}: Props) {
4545
}, 100);
4646
}, [feedbackItem.id, overflowRef]);
4747

48+
const URL_NOT_FOUND = t('URL not found');
49+
const displayUrl =
50+
eventData?.contexts.feedback || eventData?.tags ? url ?? URL_NOT_FOUND : '';
51+
const urlIsLink = displayUrl.length && displayUrl !== URL_NOT_FOUND;
52+
4853
return (
4954
<Fragment>
5055
<FeedbackItemHeader eventData={eventData} feedbackItem={feedbackItem} />
@@ -56,15 +61,17 @@ export default function FeedbackItem({feedbackItem, eventData, tags}: Props) {
5661
{!crashReportId || (crashReportId && url) ? (
5762
<Section icon={<IconLink size="xs" />} title={t('URL')}>
5863
<TextCopyInput
59-
style={{color: `${theme.blue400}`}}
60-
onClick={e => {
61-
e.preventDefault();
62-
openNavigateToExternalLinkModal({linkText: url});
63-
}}
64+
style={urlIsLink ? {color: `${theme.blue400}`} : undefined}
65+
onClick={
66+
urlIsLink
67+
? e => {
68+
e.preventDefault();
69+
openNavigateToExternalLinkModal({linkText: displayUrl});
70+
}
71+
: () => {}
72+
}
6473
>
65-
{eventData?.contexts.feedback || eventData?.tags
66-
? url ?? t('URL not found')
67-
: ''}
74+
{displayUrl}
6875
</TextCopyInput>
6976
</Section>
7077
) : null}

0 commit comments

Comments
 (0)