Skip to content

Commit 6e6ed91

Browse files
fix(ui): added context device model and model_id (#18224)
1 parent 31eb906 commit 6e6ed91

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

src/sentry/static/sentry/app/components/events/contexts/device/device.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ type Props = {
1212
const deviceKnownDataValues = [
1313
DeviceKnownDataType.NAME,
1414
DeviceKnownDataType.FAMILY,
15-
DeviceKnownDataType.RENDERED_MODEL,
1615
DeviceKnownDataType.CPU_DESCRIPTION,
1716
DeviceKnownDataType.ARCH,
1817
DeviceKnownDataType.BATTERY_LEVEL,
@@ -38,6 +37,7 @@ const deviceKnownDataValues = [
3837
DeviceKnownDataType.SCREEN_HEIGHT_PIXELS,
3938
DeviceKnownDataType.SCREEN_RESOLUTION,
4039
DeviceKnownDataType.SCREEN_WIDTH_PIXELS,
40+
DeviceKnownDataType.MODEL,
4141
];
4242

4343
const Device = ({data}: Props) => (

src/sentry/static/sentry/app/components/events/contexts/device/getDeviceKnownDataDetails.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ function getDeviceKnownDataDetails(data: DeviceData, type: DeviceKnownDataType):
2525
subject: t('Family'),
2626
value: data.family,
2727
};
28-
case DeviceKnownDataType.RENDERED_MODEL:
28+
case DeviceKnownDataType.MODEL:
2929
return {
3030
subject: t('Model'),
3131
value:
3232
typeof data.model === 'string' ? (
3333
<DeviceName
34-
value={`${data.model} ${data.model_id ? `(${data.model_id})` : ''}`}
34+
value={`${data.model} ${data?.model_id ? `(${data.model_id})` : ''}`}
3535
/>
3636
) : (
3737
undefined

src/sentry/static/sentry/app/components/events/contexts/device/types.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ export enum DeviceKnownDataType {
22
NAME = 'name',
33
FAMILY = 'family',
44
RENDERED_MODEL = 'renderedModel',
5+
MODEL = 'model',
6+
MODEL_ID = 'model_id',
57
CPU_DESCRIPTION = 'cpu_description',
68
ARCH = 'arch',
79
BATTERY_LEVEL = 'battery_level',

src/sentry/static/sentry/app/components/events/interfaces/keyValueList/keyValueListV2.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ const KeyValueList = ({
4343
{getData().map(
4444
({key, subject, value = null, meta, subjectIcon, subjectDataTestId}) => {
4545
const dataValue =
46-
typeof value === 'object' ? JSON.stringify(value, null, 2) : value;
46+
typeof value === 'object' && !React.isValidElement(value)
47+
? JSON.stringify(value, null, 2)
48+
: value;
4749
return (
4850
<tr key={key}>
4951
<TableSubject className="key" wide={longKeys}>

src/sentry/static/sentry/app/components/events/meta/annotatedText.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ const AnnotatedText = ({value, chunks, errors, remarks, ...props}) => (
114114
);
115115

116116
AnnotatedText.propTypes = {
117-
value: PropTypes.string,
117+
value: PropTypes.node,
118118
chunks: PropTypes.array,
119119
errors: PropTypes.array,
120120
remarks: PropTypes.array,

0 commit comments

Comments
 (0)