feat(grouping): Deprecate mobile grouping config (#74457)

When events come in for projects with the mobile grouping config, they
will start transitioning to the latest project config.

Once we can run the one-off script in GoCD, we can also transition
projects without any events.

This takes advantage of the feature added in #74203.

Author: armenzg

src/sentry/grouping/ingest/config.py

@@ -18,7 +18,9 @@
 Job = MutableMapping[str, Any]
 
 # We are moving all projects off these configuration without waiting for events
-CONFIGS_TO_DEPRECATE: list[str] = []
+CONFIGS_TO_DEPRECATE: list[str] = [
+    "mobile:2021-02-12",
+]
 
 
 def update_grouping_config_if_needed(project: Project) -> None:

tests/sentry/event_manager/test_event_manager_grouping.py

@@ -189,19 +189,8 @@ def test_deprecated_configs_upgrade_automatically(self):
         with override_settings(SENTRY_GROUPING_AUTO_UPDATE_ENABLED=True):
             update_grouping_config_if_needed(self.project)
             # Nothing changes
-            assert self.project.get_option("sentry:grouping_config") == "mobile:2021-02-12"
-            assert self.project.get_option("sentry:grouping_auto_update") is False
-
-            # XXX: In the future, once the mobile grouping is added to the list, we will remove this line
-            with mock.patch(
-                "sentry.grouping.ingest.config.CONFIGS_TO_DEPRECATE",
-                new=["mobile:2021-02-12"],
-            ):
-                update_grouping_config_if_needed(self.project)
-                # Even though auto update is disabled we have upgraded the project
-                assert self.project.get_option("sentry:grouping_config") == DEFAULT_GROUPING_CONFIG
-                # We have also updated the auto_update option
-                assert self.project.get_option("sentry:grouping_auto_update") is True
+            assert self.project.get_option("sentry:grouping_config") == DEFAULT_GROUPING_CONFIG
+            assert self.project.get_option("sentry:grouping_auto_update") is True
 
 
 class PlaceholderTitleTest(TestCase):

tests/sentry/event_manager/test_hierarchical_hashes.py

@@ -5,12 +5,11 @@
 
 import pytest
 
-from sentry.event_manager import EventManager, _save_aggregate
+from sentry.event_manager import _save_aggregate
 from sentry.eventstore.models import Event
 from sentry.grouping.result import CalculatedHashes
 from sentry.models.group import Group
 from sentry.models.grouphash import GroupHash
-from sentry.testutils.cases import TestCase
 from sentry.testutils.pytest.fixtures import django_db_all
 
 
@@ -199,98 +198,3 @@ def test_partial_move(default_project, fast_save):
     assert not new_group_info.is_new
     assert not new_group_info.is_regression
     assert new_group_info.group.id == group_info.group.id
-
-
-class EventManagerGroupingTest(TestCase):
-    def test_can_upgrade_to_hierarchical_config(self):
-        self.set_options("legacy:2019-03-12")  # Starting configuration
-
-        event = self.save_event()
-
-        self.transition_to_new_config("mobile:2021-02-12")
-
-        # This event will have two sets of hashes
-        event2 = self.save_event()
-
-        # The hashes property between the two events do not intersect
-        assert not set(event.get_hashes().hashes) & set(event2.get_hashes().hashes)
-        # They are both grouped together
-        assert event.group_id == event2.group_id
-
-        group = Group.objects.get(id=event.group_id)
-
-        assert group.times_seen == 2
-        assert group.last_seen == event2.datetime
-
-        # After expiry, new events are still assigned to the same group:
-        self.project.update_option("sentry:secondary_grouping_expiry", 0)
-        event3 = self.save_event()
-        assert event3.group_id == event2.group_id
-
-    def test_can_downgrade_from_hierarchical_config(self):
-        self.set_options("mobile:2021-02-12")  # Starting configuration
-
-        event = self.save_event()
-
-        self.transition_to_new_config("legacy:2019-03-12")
-
-        # This event will have two sets of hashes
-        event2 = self.save_event()
-
-        # The hashes property between the two events do not intersect
-        assert not set(event.get_hashes().hashes) & set(event2.get_hashes().hashes)
-        # They are both grouped together
-        assert event.group_id == event2.group_id
-
-        group = Group.objects.get(id=event.group_id)
-
-        group_hashes = GroupHash.objects.filter(
-            project=self.project, hash__in=event.get_hashes().hashes
-        )
-        assert group_hashes
-        for hash in group_hashes:
-            assert hash.group_id == event.group_id
-
-        assert group.times_seen == 2
-        assert group.last_seen == event2.datetime
-
-        # After expiry, new events are still assigned to the same group:
-        self.project.update_option("sentry:secondary_grouping_expiry", 0)
-        event3 = self.save_event()
-        assert event3.group_id == event2.group_id
-
-    def save_event(self):
-        manager = EventManager(
-            make_event(
-                message="foo 123",
-                event_id=hex(2**127)[-32:],
-                exception={
-                    "values": [
-                        {
-                            "type": "Hello",
-                            "stacktrace": {
-                                "frames": [
-                                    {"function": "not_in_app_function"},
-                                    {"function": "in_app_function"},
-                                ]
-                            },
-                        }
-                    ]
-                },
-            )
-        )
-        manager.normalize()
-        with self.tasks():
-            return manager.save(self.project.id)
-
-    def set_options(self, primary_config):
-        self.project.update_option("sentry:grouping_config", primary_config)
-        self.project.update_option("sentry:secondary_grouping_expiry", 0)
-
-    def transition_to_new_config(self, new_config):
-        original_config = self.project.get_option("sentry:grouping_config")
-        self.project.update_option("sentry:grouping_config", new_config)
-        self.project.update_option("sentry:secondary_grouping_config", original_config)
-        self.project.update_option(
-            "sentry:secondary_grouping_expiry", time.time() + (24 * 90 * 3600)
-        )