Merge branch 'master' into priscila/ref/quick-start/rename-variables

Author: priscilawebdev

Diff for: .github/actions/setup-sentry/action.yml

@@ -43,6 +43,14 @@ inputs:
     description: 'PostgreSQL version to use'
     default: '14'
     required: false
+  use-new-devservices:
+    description: 'Use new devservices'
+    required: false
+    default: 'false'
+  mode:
+    description: 'Mode to bring up by new devservices'
+    required: false
+    default: 'default'
 
 outputs:
   yarn-cache-dir:
@@ -139,6 +147,7 @@ runs:
 
     - name: Start devservices
       shell: bash --noprofile --norc -eo pipefail -ux {0}
+      if: ${{ inputs.use-new-devservices != 'true' }}
       env:
         NEED_KAFKA: ${{ inputs.kafka }}
         NEED_SNUBA: ${{ inputs.snuba }}
@@ -195,3 +204,23 @@ runs:
         # This is necessary when other repositories (e.g. relay) want to take advantage of this workflow
         # without needing to fork it. The path needed is the one where tools are located
         cd "$WORKDIR"
+
+    - name: Start new devservices
+      if: ${{ inputs.use-new-devservices == 'true' }}
+      shell: bash --noprofile --norc -eo pipefail -ux {0}
+      env:
+        WORKDIR: ${{ inputs.workdir }}
+        ENABLE_AUTORUN_MIGRATION_SEARCH_ISSUES: '1'
+      run: |
+        sentry init
+
+        devservices up --mode ${{ inputs.mode }}
+
+        # have tests listen on the docker gateway ip so loopback can occur
+        echo "DJANGO_LIVE_TEST_SERVER_ADDRESS=$(docker network inspect bridge --format='{{(index .IPAM.Config 0).Gateway}}')" >> "$GITHUB_ENV"
+
+        docker ps -a
+
+        # This is necessary when other repositories (e.g. relay) want to take advantage of this workflow
+        # without needing to fork it. The path needed is the one where tools are located
+        cd "$WORKDIR"

Diff for: .github/workflows/backend.yml

@@ -330,6 +330,7 @@ jobs:
           # mypy does not have granular codes so don't allow specific messages to regress
           set -euo pipefail
           ! grep "'Settings' object has no attribute" .artifacts/mypy-all
+          ! grep 'Argument .* of "dispatch" is incompatible with' .artifacts/mypy-all
           ! grep 'Cannot override class variable' .artifacts/mypy-all
           ! grep 'Exception type must be derived from BaseException' .artifacts/mypy-all
           ! grep 'Incompatible default for argument' .artifacts/mypy-all

Diff for: CHANGES

@@ -1,3 +1,35 @@
+24.12.2
+-------
+
+### Various fixes & improvements
+
+- feat(devservices): Add option to setup sentry with new devservices to existing action (#83415) by @hubertdeng123
+- ref(react19): Remove various styled defaultProps (#83409) by @scttcper
+- feat(new-trace-issues): Updating designs for trace preview in issue details (#83430) by @Abdkhan14
+- feat(metric-issues): Add "correlated issues" section  (#83353) by @snigdhas
+- fix(ui): Clamp timeline zoom to the minute (#83435) by @evanpurkhiser
+- fix(eslint): Enable no-constant-binary-expression and fix violations (#83273) by @ryan953
+- feat(eap): Support eap autocompleting booleans (#83433) by @Zylphrex
+- fix(migrations): Actually fix BoundedPositiveBigIntegerField (#83431) by @wedamija
+- ref: delete dead serializer code (#83429) by @asottile-sentry
+- feat(ui): List available param keys in useParams (#83428) by @scttcper
+- ref: fix types for mentions serializer (#83424) by @asottile-sentry
+- :recycle: feat(workflow_engine): issue alert action migration util for slack (#83123) by @iamrajjoshi
+- feat(metric-issues): Hide log level indicator for non-error issues (#83354) by @snigdhas
+- ref: use types-requests-oauthlib (#83418) by @asottile-sentry
+- ref: use types-unidiff (#83416) by @asottile-sentry
+- ref(profiling) drop drag and drop functionality (#83420) by @JonasBa
+- ref: upgrade django-stubs (#83413) by @asottile-sentry
+- chore(alerts): Remove lingering activated alerts code (#83342) by @ceorourke
+- chore(analytics): Add experimental analytics for new streamlined orgs  (#83390) by @leeandher
+- feat(dashboards): Improve duration Y axis label formatting (#83337) by @gggritso
+- ref(profiling): Merge profile provider for both modes (#83338) by @Zylphrex
+- fix(migrations): Set the correct internal type for BoundedPositiveBigIntegerField (#83412) by @wedamija
+- fix: check user in helper (#83407) by @oioki
+- fix(widget-builder): Aggregates with no column not wiped (#83410) by @narsaynorath
+
+_Plus 775 more_
+
 24.12.1
 -------
 

Diff for: eslint.config.mjs

@@ -281,14 +281,12 @@ export default typescript.config([
       ...eslint.configs.recommended.rules,
       'no-cond-assign': ['error', 'always'],
       'no-case-declarations': 'off', // TODO(ryan953): Fix violations and delete this line
-      'no-constant-binary-expression': 'off', // TODO(ryan953): Fix violations and delete this line
       'no-dupe-class-members': 'off', // TODO(ryan953): Fix violations and delete this line
       'no-import-assign': 'off', // TODO(ryan953): Fix violations and delete this line
       'no-prototype-builtins': 'off', // TODO(ryan953): Fix violations and delete this line
       'no-unsafe-optional-chaining': 'off', // TODO(ryan953): Fix violations and delete this line
       'no-useless-catch': 'off', // TODO(ryan953): Fix violations and delete this line
       'no-useless-escape': 'off', // TODO(ryan953): Fix violations and delete this line
-      'valid-typeof': 'off', // TODO(ryan953): Fix violations and delete this line
     },
   },
   {
@@ -684,7 +682,7 @@ export default typescript.config([
   },
   {
     name: 'files/sentry-stories',
-    files: ['**/*.stories.{tsx}'],
+    files: ['**/*.stories.tsx'],
     rules: {
       'no-loss-of-precision': 'off', // Sometimes we have wild numbers hard-coded in stories
     },

Diff for: jest.config.ts

@@ -234,7 +234,7 @@ const config: Config.InitialOptions = {
     '<rootDir>/tests/js/setup.ts',
     '<rootDir>/tests/js/setupFramework.ts',
   ],
-  testMatch: testMatch || ['<rootDir>/static/**/?(*.)+(spec|test).[jt]s?(x)'],
+  testMatch: testMatch || ['<rootDir>/(static|tests/js)/**/?(*.)+(spec|test).[jt]s?(x)'],
   testPathIgnorePatterns: ['<rootDir>/tests/sentry/lang/javascript/'],
 
   unmockedModulePathPatterns: [

Diff for: migrations_lockfile.txt

@@ -15,7 +15,7 @@ remote_subscriptions: 0003_drop_remote_subscription
 
 replays: 0004_index_together
 
-sentry: 0813_rm_alertruleactivation_models
+sentry: 0815_add_action_cols_to_threads_model
 
 social_auth: 0002_default_auto_field
 

Diff for: package.json

@@ -146,7 +146,7 @@
     "qrcode.react": "^3.1.0",
     "query-string": "7.0.1",
     "react": "18.2.0",
-    "react-autosize-textarea": "7.1.0",
+    "react-textarea-autosize": "8.5.7",
     "react-date-range": "^1.4.0",
     "react-dom": "18.2.0",
     "react-grid-layout": "^1.3.4",

Diff for: pyproject.toml

@@ -103,11 +103,9 @@ module = [
     "onelogin.saml2.idp_metadata_parser.*",
     "phabricator.*",
     "rb.*",
-    "requests_oauthlib.*",
     "sqlparse.*",
     "statsd.*",
     "u2flib_server.model.*",
-    "unidiff.*",
 ]
 ignore_missing_imports = true
 # end: missing 3rd party stubs
@@ -134,7 +132,6 @@ module = [
     "sentry.api.endpoints.organization_events_meta",
     "sentry.api.endpoints.organization_events_spans_performance",
     "sentry.api.endpoints.organization_index",
-    "sentry.api.endpoints.organization_issues_count",
     "sentry.api.endpoints.organization_member.details",
     "sentry.api.endpoints.organization_member.index",
     "sentry.api.endpoints.organization_member.requests.invite.details",
@@ -162,11 +159,9 @@ module = [
     "sentry.api.serializers.models.group",
     "sentry.api.serializers.models.group_stream",
     "sentry.api.serializers.models.organization",
-    "sentry.api.serializers.models.plugin",
     "sentry.api.serializers.models.project",
     "sentry.api.serializers.models.role",
     "sentry.api.serializers.models.rule",
-    "sentry.api.serializers.rest_framework.mentions",
     "sentry.auth.helper",
     "sentry.auth.provider",
     "sentry.auth.system",
@@ -188,10 +183,8 @@ module = [
     "sentry.incidents.tasks",
     "sentry.integrations.aws_lambda.integration",
     "sentry.integrations.bitbucket.client",
-    "sentry.integrations.bitbucket.installed",
     "sentry.integrations.bitbucket.integration",
     "sentry.integrations.bitbucket.issues",
-    "sentry.integrations.bitbucket.uninstalled",
     "sentry.integrations.bitbucket_server.client",
     "sentry.integrations.bitbucket_server.integration",
     "sentry.integrations.example.integration",
@@ -288,7 +281,6 @@ module = [
     "sentry.snuba.metrics.query_builder",
     "sentry.snuba.spans_metrics",
     "sentry.tagstore.snuba.backend",
-    "sentry.tagstore.types",
     "sentry.tasks.auth",
     "sentry.tasks.base",
     "sentry.testutils.cases",
@@ -344,6 +336,7 @@ module = [
     "sentry.api.helpers.group_index.update",
     "sentry.api.helpers.source_map_helper",
     "sentry.api.serializers.models.organization_member.*",
+    "sentry.api.serializers.rest_framework.group_notes",
     "sentry.audit_log.services.*",
     "sentry.auth.services.*",
     "sentry.auth.view",

Diff for: requirements-dev-frozen.txt

@@ -6,13 +6,13 @@
 #
 --index-url https://pypi.devinfra.sentry.io/simple
 
-amqp==5.2.0
+amqp==5.3.1
 anyio==3.7.1
 asgiref==3.8.1
 attrs==24.2.0
 avalara==20.9.0
 beautifulsoup4==4.7.1
-billiard==4.2.0
+billiard==4.2.1
 black==24.10.0
 boto3==1.34.128
 botocore==1.34.128
@@ -44,7 +44,7 @@ django==5.1.4
 django-crispy-forms==1.14.0
 django-csp==3.8
 django-pg-zero-downtime-migrations==0.16
-django-stubs-ext==5.1.1
+django-stubs-ext==5.1.2
 djangorestframework==3.15.2
 docker==7.1.0
 drf-spectacular==0.26.3
@@ -92,7 +92,7 @@ jsonschema==4.20.0
 jsonschema-path==0.3.2
 jsonschema-spec==0.2.4
 jsonschema-specifications==2023.7.1
-kombu==5.3.6
+kombu==5.4.2
 lazy-object-proxy==1.10.0
 lxml==5.3.0
 lxml-stubs==0.4.0
@@ -184,7 +184,7 @@ sentry-arroyo==2.19.9
 sentry-cli==2.16.0
 sentry-covdefaults-disable-branch-coverage==1.0.2
 sentry-devenv==1.14.2
-sentry-forked-django-stubs==5.1.1.post1
+sentry-forked-django-stubs==5.1.2.post1
 sentry-forked-djangorestframework-stubs==3.15.2.post1
 sentry-forked-email-reply-parser==0.5.12.post1
 sentry-kafka-schemas==0.1.128
@@ -229,16 +229,18 @@ types-pytz==2022.1.2
 types-pyyaml==6.0.11
 types-redis==3.5.18
 types-requests==2.32.0.20241016
+types-requests-oauthlib==2.0.0.20240417
 types-setuptools==69.0.0.0
 types-simplejson==3.17.7.2
+types-unidiff==0.7.0.20240505
 typing-extensions==4.12.0
 tzdata==2023.3
 ua-parser==0.10.0
 unidiff==0.7.4
 uritemplate==4.1.1
 urllib3==2.2.2
 vine==5.1.0
-virtualenv==20.25.0
+virtualenv==20.26.6
 wcwidth==0.2.10
 werkzeug==3.0.6
 wheel==0.38.4

Diff for: requirements-dev.txt

@@ -37,7 +37,7 @@ pip-tools>=7.1.0
 packaging>=21.3
 
 # for type checking
-sentry-forked-django-stubs>=5.1.1.post1
+sentry-forked-django-stubs>=5.1.2.post1
 sentry-forked-djangorestframework-stubs>=3.15.2.post1
 lxml-stubs
 msgpack-types>=0.2.0
@@ -57,5 +57,7 @@ types-pyyaml
 # make sure to match close-enough to redis==
 types-redis<4
 types-requests>=2.32.0.20241016
+types-requests-oauthlib
 types-setuptools>=68
 types-simplejson>=3.17.7.2
+types-unidiff

Diff for: requirements-frozen.txt

@@ -6,13 +6,13 @@
 #
 --index-url https://pypi.devinfra.sentry.io/simple
 
-amqp==5.2.0
+amqp==5.3.1
 anyio==3.7.1
 asgiref==3.8.1
 attrs==24.2.0
 avalara==20.9.0
 beautifulsoup4==4.7.1
-billiard==4.2.0
+billiard==4.2.1
 boto3==1.34.128
 botocore==1.34.128
 brotli==1.1.0
@@ -73,7 +73,7 @@ isodate==0.6.1
 jmespath==0.10.0
 jsonschema==4.20.0
 jsonschema-specifications==2023.7.1
-kombu==5.3.6
+kombu==5.4.2
 lxml==5.3.0
 maxminddb==2.3.0
 milksnake==0.1.6

Diff for: src/sentry/api/endpoints/auth_config.py

@@ -1,5 +1,7 @@
 from django.conf import settings
 from django.contrib.auth import REDIRECT_FIELD_NAME
+from django.http.request import HttpRequest
+from django.http.response import HttpResponseBase
 from django.urls import reverse
 from rest_framework.request import Request
 from rest_framework.response import Response
@@ -30,7 +32,7 @@ class AuthConfigEndpoint(Endpoint, OrganizationMixin):
     # Disable authentication and permission requirements.
     permission_classes = ()
 
-    def dispatch(self, request: Request, *args, **kwargs) -> Response:
+    def dispatch(self, request: HttpRequest, *args, **kwargs) -> HttpResponseBase:
         self.determine_active_organization(request)
         return super().dispatch(request, *args, **kwargs)
 

Diff for: src/sentry/api/endpoints/organization_derive_code_mappings.py

@@ -2,7 +2,6 @@
 from rest_framework.request import Request
 from rest_framework.response import Response
 
-from sentry import features
 from sentry.api.api_owners import ApiOwner
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
@@ -42,9 +41,6 @@ def get(self, request: Request, organization: Organization) -> Response:
         :param string stacktraceFilename:
         :auth: required
         """
-        if not features.has("organizations:derive-code-mappings", organization):
-            return Response(status=status.HTTP_403_FORBIDDEN)
-
         stacktrace_filename = request.GET.get("stacktraceFilename")
         installation, _ = get_installation(organization)  # only returns GitHub integrations
         if not installation:
@@ -85,9 +81,6 @@ def post(self, request: Request, organization: Organization) -> Response:
         :param string sourceRoot:
         :auth: required
         """
-        if not features.has("organizations:derive-code-mappings", organization):
-            return Response(status=status.HTTP_403_FORBIDDEN)
-
         installation, organization_integration = get_installation(organization)
         if not installation or not organization_integration:
             return self.respond(